-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Splitted building with Matter OTA and DFU over SMP #14144
Merged
bzbarsky-apple
merged 6 commits into
project-chip:master
from
kkasperczyk-no:dfu_configuration_refactor_pr
Jan 26, 2022
Merged
[nrfconnect] Splitted building with Matter OTA and DFU over SMP #14144
bzbarsky-apple
merged 6 commits into
project-chip:master
from
kkasperczyk-no:dfu_configuration_refactor_pr
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when enabling Matter OTA DFU, the another DFU over Bluetooth LE using SMP configuration is also enabled. It should be available to enable independently. * Enabled Matter OTA by default for lighting-app * Modified cmake BUILD_WITH_DFU option to allow disabling DFU support, enabling Matter OTA DFU and enabling Matter OTA DFU + DFU over Bluetooth LE * Splitted config overlays to extract common DFU parts from SMP specific ones. * Updated examples documentation
kkasperczyk-no
force-pushed
the
dfu_configuration_refactor_pr
branch
from
January 25, 2022 08:49
ce58363
to
4e2c939
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
January 25, 2022 08:50
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 25, 2022 08:50
PR #14144: Size comparison from e169fcf to 2938003 Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
Converted to draft, some work still needs to be done |
PR #14144: Size comparison from e169fcf to 2f79e05 Full report (9 builds for cyw30739, k32w, linux, qpg, telink)
|
PR #14144: Size comparison from e169fcf to a920b65 Increases above 0.2%:
Increases (3 builds for nrfconnect)
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14144: Size comparison from e169fcf to 0a6e15c Increases above 0.2%:
Increases (4 builds for linux, nrfconnect)
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 25, 2022
Damian-Nordic
approved these changes
Jan 25, 2022
bzbarsky-apple
approved these changes
Jan 25, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…ect-chip#14144) * [nrfconnect] Splitted building with Matter OTA and DFU over SMP Currently when enabling Matter OTA DFU, the another DFU over Bluetooth LE using SMP configuration is also enabled. It should be available to enable independently. * Enabled Matter OTA by default for lighting-app * Modified cmake BUILD_WITH_DFU option to allow disabling DFU support, enabling Matter OTA DFU and enabling Matter OTA DFU + DFU over Bluetooth LE * Splitted config overlays to extract common DFU parts from SMP specific ones. * Updated examples documentation * Fixed spellcheck failures * Added cbor module to requirements * Disabled building target with DFU support for nRF52840 dongle * Disabled nRF5340DK shell workflow * Removed additional board check for building DFU target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently when enabling Matter OTA DFU, the another DFU over Bluetooth LE using SMP configuration is also enabled. It should be available to enable independently.
Change overview
By the way of this change:
Testing
Performed manual building tests