Switch Interaction Model client error reporting to just CHIP_ERROR. #13888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
requested review from
mrjerryjohns,
yunhanw-google and
vivien-apple
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02 and
msandstedt
|
PR #13888: Size comparison from 1490461 to 7f73497 Decreases (1 build for k32w)
Full report (4 builds for cyw30739, k32w, telink)
|
bzbarsky-apple
force-pushed
the
fix-im-errors
branch
from
7f73497 to
5315a07
Compare
|
PR #13888: Size comparison from 1490461 to 5315a07 Increases above 0.2%:
Increases (3 builds for esp32, linux)
Decreases (3 builds for k32w, linux, qpg)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-im-errors
branch
from
5315a07 to
5f4a98d
Compare
|
PR #13888: Size comparison from 2926d14 to 5f4a98d Increases above 0.2%:
Increases (9 builds for cyw30739, k32w, linux, p6, qpg, telink)
Decreases (4 builds for k32w, linux, qpg)
Full report (12 builds for cyw30739, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-im-errors
branch
from
5f4a98d to
678778c
Compare
|
PR #13888: Size comparison from 2926d14 to 678778c Increases above 0.2%:
Increases (20 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, qpg, telink)
Decreases (6 builds for esp32, k32w, linux, qpg)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-im-errors
branch
from
678778c to
96e4d89
Compare
|
PR #13888: Size comparison from bb2838f to 96e4d89 Increases above 0.2%:
Increases (12 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Decreases (4 builds for k32w, linux, qpg)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-im-errors
branch
from
96e4d89 to
1fb41b4
Compare
|
PR #13888: Size comparison from 0f9fff5 to 1fb41b4 Increases above 0.2%:
Increases (20 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, qpg, telink)
Decreases (6 builds for esp32, k32w, linux, qpg)
Full report (28 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-im-errors
branch
from
b14a369 to
35ca0cf
Compare
|
PR #13888: Size comparison from 270081a to 35ca0cf Increases (20 builds for cyw30739, efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (4 builds for esp32, k32w, qpg)
Full report (31 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
|
/rebase |
Now that we can put a StatusIB inside a CHIP_ERROR, we can stop passing both, or passing just EmberAfStatus, and pass a CHIP_ERROR that either contains a StatusIB or contains the actual client-side error we ran into (e.g. failure to decode).
woody-apple
force-pushed
the
fix-im-errors
branch
from
35ca0cf to
a7bbc5f
Compare
|
PR #13888: Size comparison from e169fcf to a7bbc5f Increases above 0.2%:
Increases (22 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for esp32, k32w, linux, qpg)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Jan 25, 2022
msandstedt
approved these changes
Jan 25, 2022
andy31415
approved these changes
Jan 25, 2022
woody-apple
approved these changes
Jan 25, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…roject-chip#13888) * Switch Interaction Model client error reporting to just CHIP_ERROR. Now that we can put a StatusIB inside a CHIP_ERROR, we can stop passing both, or passing just EmberAfStatus, and pass a CHIP_ERROR that either contains a StatusIB or contains the actual client-side error we ran into (e.g. failure to decode). * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can put a StatusIB inside a CHIP_ERROR, we can stop
passing both, or passing just EmberAfStatus, and pass a CHIP_ERROR
that either contains a StatusIB or contains the actual client-side
error we ran into (e.g. failure to decode).
Problem
We are trying to force a StatusIB through an EmberAfStatus, it's not clear to consumers how the CHIP_ERROR and the StatusIB (or EmberAfStatus or InteractionModel::Status) interact when both are passed, etc.
Change overview
Switch all the IM failure/error callbacks to take CHIP_ERROR.
Testing
Should be no behavior changes for now. The consumers that could really use this (in CHIPDeviceController, where we are ending up treating a general status as a cluster-specific status) are not using the new APIs yet.