Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cluster association for the NetworkCommissioningFeature enum. #13845

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Fix the cluster association for the NetworkCommissioningFeature enum. #13845

merged 1 commit into from
Jan 24, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Without that, the enum is not being code-generated.

Problem

Enum not being codegenned.

Change overview

Codegen it.

Testing

Looked at the generated code.

@bzbarsky-apple
Fix the cluster association for the NetworkCommissioningFeature enum.
6f473c1 
Without that, the enum is not being code-generated.
@boring-cyborg boring-cyborg bot added the app label Jan 22, 2022
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jan 22, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jan 22, 2022 •
edited
Loading

PR #13845: Size comparison from ed8d276 to 6f473c1

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ed8d276 6f473c1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574398 574398 0 0.0
.app_xip_area 479412 479412 0 0.0
.bss 77724 77724 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835852 835852 0 0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 835844 835844 0 0.0
BRD4161A+rpc (read only) 823256 823256 0 0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 823248 823248 0 0.0
window-app BRD4161A (read only) 806412 806412 0 0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 806404 806404 0 0.0
esp32 all-clusters-app c3devkit (read only) 918558 918558 0 0.0
(read/write) 1383418 1383418 0 0.0
.dram0.bss 70704 70704 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 179344 179344 0 0.0
.flash.text 918558 918558 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967107 967107 0 0.0
(read/write) 449836 449836 0 0.0
.dram0.bss 75168 75168 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208508 208508 0 0.0
.flash.text 961723 961723 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660556 660556 0 0.0
.bss 76608 76608 0 0.0
.data 1868 1868 0 0.0
.text 576280 576280 0 0.0
lock k32w061+release (read/write) 661312 661312 0 0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576776 576776 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8520948 8520948 0 0.0
(read/write) 390753 390753 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260872 260872 0 0.0
.dynamic 560 560 0 0.0
.got 68952 68952 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 436460 436460 0 0.0
.text 7246052 7246052 0 0.0
thermostat-no-ble arm64 (read only) 2051516 2051516 0 0.0
(read/write) 145697 145697 0 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130700 130700 0 0.0
.text 1706320 1706320 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352072 2352072 0 0.0
.bss 189412 189412 0 0.0
.data 5304 5304 0 0.0
.text 1314648 1314648 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334296 2334296 0 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1296896 1296896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304648 2304648 0 0.0
.bss 179960 179960 0 0.0
.data 5560 5560 0 0.0
.text 1267248 1267248 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942879 942879 0 0.0
bss 119044 119044 0 0.0
rodata 108916 108916 0 0.0
text 637312 637312 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928347 928347 0 0.0
bss 116088 116088 0 0.0
rodata 101368 101368 0 0.0
text 632708 632708 0 0.0
nrf52840dongle_nrf52840 (read/write) 993527 993527 0 0.0
bss 121884 121884 0 0.0
rodata 113672 113672 0 0.0
text 669512 669512 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852706 852706 0 0.0
bss 115828 115828 0 0.0
rodata 102092 102092 0 0.0
text 554232 554232 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912223 912223 0 0.0
bss 118196 118196 0 0.0
rodata 103884 103884 0 0.0
text 612756 612756 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822294 822294 0 0.0
bss 115016 115016 0 0.0
rodata 97112 97112 0 0.0
text 529712 529712 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915083 915083 0 0.0
bss 117960 117960 0 0.0
rodata 104248 104248 0 0.0
text 615404 615404 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910267 910267 0 0.0
bss 117984 117984 0 0.0
rodata 103400 103400 0 0.0
text 611428 611428 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798527 798527 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533928 533928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711342 711342 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451608 451608 0 0.0
p6 all-clusters-app default (read/write) 2410408 2410408 0 0.0
.bss 117756 117756 0 0.0
.data 2584 2584 0 0.0
.text 1368672 1368672 0 0.0
light-app default (read/write) 2330672 2330672 0 0.0
.bss 105544 105544 0 0.0
.data 2408 2408 0 0.0
.text 1288936 1288936 0 0.0
lock-app default (read/write) 2299688 2299688 0 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257952 1257952 0 0.0
qpg lighting-app qpg6105+debug (read only) 567428 567428 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89688 89688 0 0.0
.data 1064 1064 0 0.0
.text 562108 562108 0 0.0
lock-app qpg6105+debug (read only) 515904 515904 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510584 510584 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841686 841686 0 0.0
bss 87492 87492 0 0.0
noinit 37160 37160 0 0.0
text 588312 588312 0 0.0

@andy31415
Copy link
Contributor

andy31415 commented Jan 24, 2022 •
edited
Loading

fast track: very small delta and codegen delta shows the change working. PR up for sufficient time for cross timezone review.

@andy31415 andy31415 merged commit 69ab2a9 into project-chip:master Jan 24, 2022
@bzbarsky-apple bzbarsky-apple deleted the network-comissioning-feature-enum branch January 24, 2022 20:46
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Fix the cluster association for the NetworkCommissioningFeature enum. (…
6067e3e 
…project-chip#13845)

Without that, the enum is not being code-generated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @andy31415 @tcarmelveilleux @woody-apple @jmeg-sfy