Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loop function signature #13828

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Update loop function signature #13828

merged 1 commit into from
Jan 21, 2022

Conversation

mkardous-silabs
Copy link
Contributor

Problem

  • Build was failling on mac os because of the loop

Change overview

  • update the loop

Testing

  • manual build to validate fix

@mkardous-silabs mkardous-silabs changed the title loop fix Update loop function signature Jan 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13828: Size comparison from a5a7d92 to 6bf41bd

Increases (6 builds for efr32, p6)
platform target config section a5a7d92 6bf41bd change % change
efr32 lighting-app BRD4161A (read only) 835500 835532 32 0.0
.text 835492 835524 32 0.0
BRD4161A+rpc (read only) 822896 822928 32 0.0
.text 822888 822920 32 0.0
window-app BRD4161A (read only) 806052 806084 32 0.0
.text 806044 806076 32 0.0
p6 all-clusters-app default (read/write) 2409600 2409648 48 0.0
.text 1367864 1367912 48 0.0
light-app default (read/write) 2330584 2330616 32 0.0
.text 1288848 1288880 32 0.0
lock-app default (read/write) 2299576 2299624 48 0.0
.text 1257840 1257888 48 0.0
Decreases (17 builds for cyw30739, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section a5a7d92 6bf41bd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574274 574218 -56 -0.0
.app_xip_area 479288 479232 -56 -0.0
k32w light k32w061+release (read/write) 660424 660376 -48 -0.0
.text 576148 576100 -48 -0.0
lock k32w061+release (read/write) 661180 661132 -48 -0.0
.text 576644 576596 -48 -0.0
linux thermostat-no-ble arm64 (read only) 2049740 2049692 -48 -0.0
.text 1704752 1704704 -48 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2351528 2351464 -64 -0.0
.text 1314104 1314040 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2334144 2334080 -64 -0.0
.text 1296744 1296680 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942747 942699 -48 -0.0
text 637208 637156 -52 -0.0
nrf52840dk_nrf52840+rpc (read/write) 928231 928167 -64 -0.0
text 632600 632548 -52 -0.0
nrf52840dongle_nrf52840 (read/write) 993391 993343 -48 -0.0
text 669404 669352 -52 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852574 852526 -48 -0.0
text 554128 554080 -48 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912091 912043 -48 -0.0
text 612644 612592 -52 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822162 822114 -48 -0.0
text 529600 529552 -48 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 914947 914899 -48 -0.0
text 615292 615240 -52 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910151 910087 -64 -0.0
text 611320 611268 -52 -0.0
qpg lighting-app qpg6105+debug (read only) 567324 567276 -48 -0.0
.text 562004 561956 -48 -0.0
lock-app qpg6105+debug (read only) 515792 515744 -48 -0.0
.text 510472 510424 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 841562 841498 -64 -0.0
text 588208 588142 -66 -0.0
Full report (31 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a5a7d92 6bf41bd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574274 574218 -56 -0.0
.app_xip_area 479288 479232 -56 -0.0
.bss 77724 77724 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835500 835532 32 0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 835492 835524 32 0.0
BRD4161A+rpc (read only) 822896 822928 32 0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 822888 822920 32 0.0
window-app BRD4161A (read only) 806052 806084 32 0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 806044 806076 32 0.0
k32w light k32w061+release (read/write) 660424 660376 -48 -0.0
.bss 76608 76608 0 0.0
.data 1868 1868 0 0.0
.text 576148 576100 -48 -0.0
lock k32w061+release (read/write) 661180 661132 -48 -0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576644 576596 -48 -0.0
linux chip-tool-ipv6only arm64 (read only) 8493172 8493172 0 0.0
(read/write) 390129 390129 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260440 260440 0 0.0
.dynamic 560 560 0 0.0
.got 68760 68760 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435372 435372 0 0.0
.text 7220948 7220948 0 0.0
thermostat-no-ble arm64 (read only) 2049740 2049692 -48 -0.0
(read/write) 145697 145697 0 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130492 130492 0 0.0
.text 1704752 1704704 -48 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351528 2351464 -64 -0.0
.bss 189412 189412 0 0.0
.data 5304 5304 0 0.0
.text 1314104 1314040 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334144 2334080 -64 -0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1296744 1296680 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304496 2304496 0 0.0
.bss 179960 179960 0 0.0
.data 5560 5560 0 0.0
.text 1267096 1267096 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942747 942699 -48 -0.0
bss 119044 119044 0 0.0
rodata 108896 108896 0 0.0
text 637208 637156 -52 -0.0
nrf52840dk_nrf52840+rpc (read/write) 928231 928167 -64 -0.0
bss 116088 116088 0 0.0
rodata 101348 101348 0 0.0
text 632600 632548 -52 -0.0
nrf52840dongle_nrf52840 (read/write) 993391 993343 -48 -0.0
bss 121884 121884 0 0.0
rodata 113648 113648 0 0.0
text 669404 669352 -52 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852574 852526 -48 -0.0
bss 115828 115828 0 0.0
rodata 102072 102072 0 0.0
text 554128 554080 -48 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912091 912043 -48 -0.0
bss 118196 118196 0 0.0
rodata 103864 103864 0 0.0
text 612644 612592 -52 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822162 822114 -48 -0.0
bss 115016 115016 0 0.0
rodata 97092 97092 0 0.0
text 529600 529552 -48 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914947 914899 -48 -0.0
bss 117960 117960 0 0.0
rodata 104224 104224 0 0.0
text 615292 615240 -52 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910151 910087 -64 -0.0
bss 117984 117984 0 0.0
rodata 103380 103380 0 0.0
text 611320 611268 -52 -0.0
shell nrf52840dk_nrf52840 (read/write) 798527 798527 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533928 533928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711342 711342 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451608 451608 0 0.0
p6 all-clusters-app default (read/write) 2409600 2409648 48 0.0
.bss 117756 117756 0 0.0
.data 2584 2584 0 0.0
.text 1367864 1367912 48 0.0
light-app default (read/write) 2330584 2330616 32 0.0
.bss 105544 105544 0 0.0
.data 2408 2408 0 0.0
.text 1288848 1288880 32 0.0
lock-app default (read/write) 2299576 2299624 48 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257840 1257888 48 0.0
qpg lighting-app qpg6105+debug (read only) 567324 567276 -48 -0.0
(read/write) 146940 146940 0 0.0
.bss 89688 89688 0 0.0
.data 1064 1064 0 0.0
.text 562004 561956 -48 -0.0
lock-app qpg6105+debug (read only) 515792 515744 -48 -0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510472 510424 -48 -0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841562 841498 -64 -0.0
bss 87492 87492 0 0.0
noinit 37160 37160 0 0.0
text 588208 588142 -66 -0.0

@bzbarsky-apple bzbarsky-apple added the hotfix urgent fix needed, can bypass review label Jan 21, 2022
@bzbarsky-apple
Copy link
Contributor

Looks like the code we merged builds with the old XCode GitHub Enterprise uses, but not newer XCode versions (like what Github personal uses, or most people at home).

@bzbarsky-apple bzbarsky-apple merged commit b1d40eb into project-chip:master Jan 21, 2022
austinh0 pushed a commit to austinh0/connectedhomeip that referenced this pull request Jan 24, 2022
@mkardous-silabs @austinh0
loop fix (project-chip#13828)
76e17b3
andy31415 added a commit that referenced this pull request Jan 25, 2022
@austinh0 @mkardous-silabs
@andy31415 @bzbarsky-apple
[Android] Support complex types (#13609)
1f8ed00 
* Complex types in Java

* Regenerate

* loop fix (#13828)

* Ran zap regen (#13837)

* Update ZAP to pick up reportability changes. (#13802)

We can now explicitly default all attributes to "reportable".  XML
files will be able to set reportingPolicy="prohibited" for things that
the Matter spec decides are not subscribable.

* Use UniquePtr, fix templates

* Regen with updated ZAP

* Regen again

Co-authored-by: mkardous-silabs <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
@mkardous-silabs mkardous-silabs deleted the fix/loop_build branch January 27, 2022 19:14
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@mkardous-silabs @selissia
loop fix (project-chip#13828)
97bce8e
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@austinh0 @mkardous-silabs
@andy31415 @bzbarsky-apple @selissia
[Android] Support complex types (project-chip#13609)
db82f3c 
* Complex types in Java

* Regenerate

* loop fix (project-chip#13828)

* Ran zap regen (project-chip#13837)

* Update ZAP to pick up reportability changes. (project-chip#13802)

We can now explicitly default all attributes to "reportable".  XML
files will be able to set reportingPolicy="prohibited" for things that
the Matter spec decides are not subscribable.

* Use UniquePtr, fix templates

* Regen with updated ZAP

* Regen again

Co-authored-by: mkardous-silabs <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @bzbarsky-apple @yufengwangca