-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused ActiveLocale from ConfigurationMgr #13826
Merged
andy31415
merged 1 commit into
project-chip:master
from
yufengwangca:pr/configuration/cleanup
Jan 24, 2022
Merged
Remove unused ActiveLocale from ConfigurationMgr #13826
andy31415
merged 1 commit into
project-chip:master
from
yufengwangca:pr/configuration/cleanup
Jan 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel and
LuDuda
January 21, 2022 17:06
pullapprove
bot
requested review from
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
January 21, 2022 17:06
PR #13826: Size comparison from a5a7d92 to 0bdc6b8 Decreases (11 builds for cyw30739, k32w, linux, p6, qpg, telink)
Full report (12 builds for cyw30739, k32w, linux, p6, qpg, telink)
|
andy31415
approved these changes
Jan 21, 2022
bzbarsky-apple
approved these changes
Jan 22, 2022
fast track: cleanup PR, has been up for sufficient time for cross timezone review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Remove unused ActiveLocale from ConfigurationMgr
Testing
How was this tested? (at least one bullet point required)