Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ActiveLocale from ConfigurationMgr #13826

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Remove unused ActiveLocale from ConfigurationMgr #13826

merged 1 commit into from
Jan 24, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • We now use NVM instead of configuration manager to store ActiveLocale attribute. ActiveLocale config key is no more used

Change overview

Remove unused ActiveLocale from ConfigurationMgr

Testing

How was this tested? (at least one bullet point required)

  • Cleanup unused code only

@github-actions
Copy link

github-actions bot commented Jan 21, 2022

PR #13826: Size comparison from a5a7d92 to 0bdc6b8

Decreases (11 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section a5a7d92 0bdc6b8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574274 574222 -52 -0.0
.app_xip_area 479288 479236 -52 -0.0
k32w light k32w061+release (read/write) 660424 660368 -56 -0.0
.text 576148 576092 -56 -0.0
lock k32w061+release (read/write) 661180 661140 -40 -0.0
.text 576644 576604 -40 -0.0
linux chip-tool-ipv6only arm64 (read only) 8493172 8492676 -496 -0.0
(read/write) 390129 390081 -48 -0.0
.data.rel.ro 260440 260408 -32 -0.0
.got 68760 68752 -8 -0.0
.text 7220948 7220580 -368 -0.0
thermostat-no-ble arm64 (read only) 2049740 2049228 -512 -0.0
(read/write) 145697 145649 -48 -0.0
.data.rel.ro 72984 72952 -32 -0.0
.got 4064 4056 -8 -0.2
.rodata 130492 130476 -16 -0.0
.text 1704752 1704384 -368 -0.0
p6 all-clusters-app default (read/write) 2409600 2409488 -112 -0.0
.text 1367864 1367752 -112 -0.0
light-app default (read/write) 2330584 2330456 -128 -0.0
.text 1288848 1288720 -128 -0.0
lock-app default (read/write) 2299576 2299464 -112 -0.0
.text 1257840 1257728 -112 -0.0
qpg lighting-app qpg6105+debug (read only) 567324 567276 -48 -0.0
.text 562004 561956 -48 -0.0
lock-app qpg6105+debug (read only) 515792 515744 -48 -0.0
.text 510472 510424 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 841562 841478 -84 -0.0
text 588208 588158 -50 -0.0
Full report (12 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section a5a7d92 0bdc6b8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574274 574222 -52 -0.0
.app_xip_area 479288 479236 -52 -0.0
.bss 77724 77724 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
k32w light k32w061+release (read/write) 660424 660368 -56 -0.0
.bss 76608 76608 0 0.0
.data 1868 1868 0 0.0
.text 576148 576092 -56 -0.0
lock k32w061+release (read/write) 661180 661140 -40 -0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576644 576604 -40 -0.0
linux chip-tool-ipv6only arm64 (read only) 8493172 8492676 -496 -0.0
(read/write) 390129 390081 -48 -0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260440 260408 -32 -0.0
.dynamic 560 560 0 0.0
.got 68760 68752 -8 -0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435372 435372 0 0.0
.text 7220948 7220580 -368 -0.0
thermostat-no-ble arm64 (read only) 2049740 2049228 -512 -0.0
(read/write) 145697 145649 -48 -0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72984 72952 -32 -0.0
.dynamic 560 560 0 0.0
.got 4064 4056 -8 -0.2
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130492 130476 -16 -0.0
.text 1704752 1704384 -368 -0.0
p6 all-clusters-app default (read/write) 2409600 2409488 -112 -0.0
.bss 117756 117756 0 0.0
.data 2584 2584 0 0.0
.text 1367864 1367752 -112 -0.0
light-app default (read/write) 2330584 2330456 -128 -0.0
.bss 105544 105544 0 0.0
.data 2408 2408 0 0.0
.text 1288848 1288720 -128 -0.0
lock-app default (read/write) 2299576 2299464 -112 -0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257840 1257728 -112 -0.0
qpg lighting-app qpg6105+debug (read only) 567324 567276 -48 -0.0
(read/write) 146940 146940 0 0.0
.bss 89688 89688 0 0.0
.data 1064 1064 0 0.0
.text 562004 561956 -48 -0.0
lock-app qpg6105+debug (read only) 515792 515744 -48 -0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510472 510424 -48 -0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841562 841478 -84 -0.0
bss 87492 87492 0 0.0
noinit 37160 37160 0 0.0
text 588208 588158 -50 -0.0

@andy31415
Copy link
Contributor

fast track: cleanup PR, has been up for sufficient time for cross timezone review.

@andy31415 andy31415 merged commit ad8fa0e into project-chip:master Jan 24, 2022
@yufengwangca yufengwangca deleted the pr/configuration/cleanup branch January 24, 2022 19:26
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants