Stop trying to commission devices that are not in commissioning mode. #13794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-apple
approved these changes
Jan 20, 2022
|
PR #13794: Size comparison from d9b77e9 to 33dc7bc Increases (1 build for linux)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
pairing-check-commissionable
branch
from
33dc7bc to
db5a848
Compare
|
PR #13794: Size comparison from 3a2106c to db5a848 Increases (1 build for linux)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 21, 2022
|
fast track: very small delta |
|
/rebase |
woody-apple
force-pushed
the
pairing-check-commissionable
branch
from
db5a848 to
d48bf34
Compare
|
PR #13794: Size comparison from cf1b254 to d48bf34 Increases (1 build for linux)
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
SetUpCodePairer was filtering devices by discriminator, but not checking for a nonzero CM value, so could end up trying to commission a device that's not commissionable and miss a device with a colliding discriminator that is.
bzbarsky-apple
force-pushed
the
pairing-check-commissionable
branch
from
d48bf34 to
4358504
Compare
|
PR #13794: Size comparison from dd209ce to 4358504 Increases (1 build for linux)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
dhrishi
approved these changes
Jan 21, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…project-chip#13794) SetUpCodePairer was filtering devices by discriminator, but not checking for a nonzero CM value, so could end up trying to commission a device that's not commissionable and miss a device with a colliding discriminator that is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetUpCodePairer was filtering devices by discriminator, but not
checking for a nonzero CM value, so could end up trying to commission
a device that's not commissionable and miss a device with a colliding
discriminator that is.
Problem
See above.
Change overview
Check the
commissioningModeof the returned data before deciding it's OK to use.Testing
Manually tested that without this change we end up trying to commission a device that is not in commissioning mode, and with this change we skip it and discover another device that is.