-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDL] add 'global' property for attributes #13791
Conversation
@bzbarsky-apple @vivien-apple @yufengwangca - I am not clear why featureMap would be global - every cluster has its own feature map now? Am I misusing the attribute? |
PR #13791: Size comparison from 5d2778f to c72d5bb Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
marking as fast track: minor delta and does not affect functionality of the software and having this in master will unblock parser work. Please send any followup comments and I will address after the fact. |
Problem
Our code generation seems to depend on weather an attribute is global or not, so the info should likely be in the IDL.
Change overview
Adds the global property for attributes.
Testing
Checked IDL visually for deltas.
It is a bit unclear to me what 'global' actually means. I understand clusterRevision (since it is basically a protocol revision) but unsure about the rest.