Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDL] add 'global' property for attributes #13791

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Our code generation seems to depend on weather an attribute is global or not, so the info should likely be in the IDL.

Change overview

Adds the global property for attributes.

Testing

Checked IDL visually for deltas.

It is a bit unclear to me what 'global' actually means. I understand clusterRevision (since it is basically a protocol revision) but unsure about the rest.

@andy31415
Copy link
Contributor Author

@bzbarsky-apple @vivien-apple @yufengwangca - I am not clear why featureMap would be global - every cluster has its own feature map now?

Am I misusing the attribute?

@github-actions
Copy link

github-actions bot commented Jan 20, 2022

PR #13791: Size comparison from 5d2778f to c72d5bb

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d2778f c72d5bb change % change
efr32 lighting-app BRD4161A (read only) 833612 833612 0 0.0
(read/write) 127216 127216 0 0.0
.bss 125320 125320 0 0.0
.data 1896 1896 0 0.0
.text 833604 833604 0 0.0
BRD4161A+rpc (read only) 821008 821008 0 0.0
(read/write) 143880 143880 0 0.0
.bss 141880 141880 0 0.0
.data 1996 1996 0 0.0
.text 821000 821000 0 0.0
window-app BRD4161A (read only) 804212 804212 0 0.0
(read/write) 125792 125792 0 0.0
.bss 123944 123944 0 0.0
.data 1848 1848 0 0.0
.text 804204 804204 0 0.0
esp32 all-clusters-app c3devkit (read only) 916854 916854 0 0.0
(read/write) 1317522 1317522 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178968 178968 0 0.0
.flash.text 916854 916854 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965463 965463 0 0.0
(read/write) 449480 449480 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208136 208136 0 0.0
.flash.text 960079 960079 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 658924 658924 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574676 574676 0 0.0
lock k32w061+release (read/write) 659704 659704 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575196 575196 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8425404 8425404 0 0.0
(read/write) 388769 388769 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 259416 259416 0 0.0
.dynamic 560 560 0 0.0
.got 68424 68424 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 434308 434308 0 0.0
.text 7157348 7157348 0 0.0
thermostat-no-ble arm64 (read only) 2043324 2043324 0 0.0
(read/write) 145425 145425 0 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699136 1699136 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349968 2349968 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312544 1312544 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332728 2332728 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1295328 1295328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303080 2303080 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265680 1265680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941287 941287 0 0.0
bss 119020 119020 0 0.0
rodata 108508 108508 0 0.0
text 636164 636164 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926751 926751 0 0.0
bss 116064 116064 0 0.0
rodata 100956 100956 0 0.0
text 631560 631560 0 0.0
nrf52840dongle_nrf52840 (read/write) 991963 991963 0 0.0
bss 121864 121864 0 0.0
rodata 113260 113260 0 0.0
text 668364 668364 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851114 851114 0 0.0
bss 115808 115808 0 0.0
rodata 101684 101684 0 0.0
text 553088 553088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910631 910631 0 0.0
bss 118176 118176 0 0.0
rodata 103476 103476 0 0.0
text 611612 611612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820698 820698 0 0.0
bss 114992 114992 0 0.0
rodata 96700 96700 0 0.0
text 528568 528568 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913503 913503 0 0.0
bss 117940 117940 0 0.0
rodata 103836 103836 0 0.0
text 614260 614260 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908583 908583 0 0.0
bss 117964 117964 0 0.0
rodata 102948 102948 0 0.0
text 610188 610188 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2407464 2407464 0 0.0
.bss 117764 117764 0 0.0
.data 2576 2576 0 0.0
.text 1365728 1365728 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2297704 2297704 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255968 1255968 0 0.0
qpg lighting-app qpg6105+debug (read only) 565720 565720 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89672 89672 0 0.0
.data 1060 1060 0 0.0
.text 560400 560400 0 0.0
lock-app qpg6105+debug (read only) 514212 514212 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88240 88240 0 0.0
.data 984 984 0 0.0
.text 508892 508892 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839882 839882 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586962 586962 0 0.0

@andy31415
Copy link
Contributor Author

marking as fast track: minor delta and does not affect functionality of the software and having this in master will unblock parser work. Please send any followup comments and I will address after the fact.

@andy31415 andy31415 merged commit aa72854 into project-chip:master Jan 20, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@andy31415 andy31415 deleted the idl/global_attrs branch June 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants