Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA Requestor] Implement the CancelImageUpdate() OTARequestor API #13778

Merged
merged 11 commits into from
Jan 26, 2022
Merged

[OTA Requestor] Implement the CancelImageUpdate() OTARequestor API #13778

merged 11 commits into from
Jan 26, 2022

Conversation

selissia
Copy link
Contributor

@selissia selissia commented Jan 20, 2022 •
edited
Loading

Problem

Need an OTARequestor API to cancel image update

Change overview

Implement the CancelImageUpdate() OTARequestor API. Also add the UpdateCancelled API to OTARequestorDriver.

Also add comments and a check to highlight the fact the mProviderNodeId, mProviderFabricIndex and mProviderEndpointId OTARequestor member variables only apply to the image update currently in progress.

Also fix #13393 for Linux (change in src/platform/Linux/OTAImageProcessorImpl.cpp)

Testing

Tested with a custom-coded Linux chip-ota-requestor-app to invoke CancelImageUpdate() at various stages of the image udate flow (idle, download in progress).

@restyled-io restyled-io bot mentioned this pull request Jan 20, 2022
Closed
@boring-cyborg boring-cyborg bot added the app label Jan 20, 2022
@selissia selissia marked this pull request as ready for review January 20, 2022 18:58
@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13778: Size comparison from fd815cd to 06a0c91

Increases (2 builds for k32w, qpg)
platform target config section fd815cd 06a0c91 change % change
k32w light k32w061+release (read/write) 658924 658964 40 0.0
.text 574676 574716 40 0.0
qpg lighting-app qpg6105+debug (read only) 565720 565760 40 0.0
.text 560400 560440 40 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fd815cd 06a0c91 change % change
efr32 lighting-app BRD4161A (read only) 833628 833628 0 0.0
(read/write) 127032 127032 0 0.0
.bss 125136 125136 0 0.0
.data 1896 1896 0 0.0
.text 833620 833620 0 0.0
BRD4161A+rpc (read only) 821008 821008 0 0.0
(read/write) 143696 143696 0 0.0
.bss 141696 141696 0 0.0
.data 1996 1996 0 0.0
.text 821000 821000 0 0.0
window-app BRD4161A (read only) 804196 804196 0 0.0
(read/write) 125720 125720 0 0.0
.bss 123872 123872 0 0.0
.data 1848 1848 0 0.0
.text 804188 804188 0 0.0
esp32 all-clusters-app c3devkit (read only) 916854 916854 0 0.0
(read/write) 1317522 1317522 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178968 178968 0 0.0
.flash.text 916854 916854 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965463 965463 0 0.0
(read/write) 449480 449480 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208136 208136 0 0.0
.flash.text 960079 960079 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 658924 658964 40 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574676 574716 40 0.0
lock k32w061+release (read/write) 659704 659704 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575196 575196 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8390652 8390652 0 0.0
(read/write) 386417 386417 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 257432 257432 0 0.0
.dynamic 560 560 0 0.0
.got 68056 68056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 430228 430228 0 0.0
.text 7131620 7131620 0 0.0
thermostat-no-ble arm64 (read only) 2043324 2043324 0 0.0
(read/write) 145425 145425 0 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699136 1699136 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349968 2349968 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312544 1312544 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332728 2332728 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1295328 1295328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303080 2303080 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265680 1265680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941287 941287 0 0.0
bss 119020 119020 0 0.0
rodata 108508 108508 0 0.0
text 636164 636164 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926751 926751 0 0.0
bss 116064 116064 0 0.0
rodata 100956 100956 0 0.0
text 631560 631560 0 0.0
nrf52840dongle_nrf52840 (read/write) 991963 991963 0 0.0
bss 121864 121864 0 0.0
rodata 113260 113260 0 0.0
text 668364 668364 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851114 851114 0 0.0
bss 115808 115808 0 0.0
rodata 101684 101684 0 0.0
text 553088 553088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910631 910631 0 0.0
bss 118176 118176 0 0.0
rodata 103476 103476 0 0.0
text 611612 611612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820698 820698 0 0.0
bss 114992 114992 0 0.0
rodata 96700 96700 0 0.0
text 528568 528568 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913503 913503 0 0.0
bss 117940 117940 0 0.0
rodata 103836 103836 0 0.0
text 614260 614260 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908583 908583 0 0.0
bss 117964 117964 0 0.0
rodata 102948 102948 0 0.0
text 610188 610188 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2407464 2407464 0 0.0
.bss 117764 117764 0 0.0
.data 2576 2576 0 0.0
.text 1365728 1365728 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2297704 2297704 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255968 1255968 0 0.0
qpg lighting-app qpg6105+debug (read only) 565720 565760 40 0.0
(read/write) 146936 146936 0 0.0
.bss 89672 89672 0 0.0
.data 1060 1060 0 0.0
.text 560400 560440 40 0.0
lock-app qpg6105+debug (read only) 514212 514212 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88240 88240 0 0.0
.data 984 984 0 0.0
.text 508892 508892 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839882 839882 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586962 586962 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13778: Size comparison from 543c752 to 014a079

Increases above 0.2%:

platform target config section 543c752 014a079 change % change
linux chip-tool-ipv6only arm64 .text 7200308 7220948 20640 0.3
Increases (14 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 543c752 014a079 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573814 574274 460 0.1
.app_xip_area 478836 479288 452 0.1
.bss 77716 77724 8 0.0
efr32 lighting-app BRD4161A (read only) 834948 835500 552 0.1
.text 834940 835492 552 0.1
BRD4161A+rpc (read only) 822352 822896 544 0.1
.text 822344 822888 544 0.1
window-app BRD4161A (read only) 805508 806052 544 0.1
.text 805500 806044 544 0.1
k32w light k32w061+release (read/write) 659928 660500 572 0.1
.bss 76600 76608 8 0.0
.text 575660 576224 564 0.1
lock k32w061+release (read/write) 660732 661180 448 0.1
.text 576196 576644 448 0.1
linux chip-tool-ipv6only arm64 (read only) 8472012 8493172 21160 0.2
(read/write) 390001 390129 128 0.0
.data.rel.ro 260368 260440 72 0.0
.got 68704 68760 56 0.1
.rodata 435188 435372 184 0.0
.text 7200308 7220948 20640 0.3
thermostat-no-ble arm64 (read only) 2048444 2049740 1296 0.1
(read/write) 145681 145697 16 0.0
.data.rel.ro 72968 72984 16 0.0
.rodata 130380 130492 112 0.1
.text 1703648 1704752 1104 0.1
p6 all-clusters-app default (read/write) 2409104 2409600 496 0.0
.text 1367368 1367864 496 0.0
light-app default (read/write) 2330040 2330584 544 0.0
.bss 105536 105544 8 0.0
.text 1288304 1288848 544 0.0
lock-app default (read/write) 2299024 2299576 552 0.0
.text 1257288 1257840 552 0.0
qpg lighting-app qpg6105+debug (read only) 566840 567400 560 0.1
.bss 89680 89688 8 0.0
.text 561520 562080 560 0.1
lock-app qpg6105+debug (read only) 515336 515792 456 0.1
.text 510016 510472 456 0.1
telink lighting-app tlsr9518adk80d (read/write) 840934 841562 628 0.1
bss 87488 87492 4 0.0
text 587730 588208 478 0.1
Decreases (1 build for p6)
platform target config section 543c752 014a079 change % change
p6 all-clusters-app default .bss 117788 117756 -32 -0.0
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 543c752 014a079 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573814 574274 460 0.1
.app_xip_area 478836 479288 452 0.1
.bss 77716 77724 8 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 834948 835500 552 0.1
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 834940 835492 552 0.1
BRD4161A+rpc (read only) 822352 822896 544 0.1
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 822344 822888 544 0.1
window-app BRD4161A (read only) 805508 806052 544 0.1
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 805500 806044 544 0.1
k32w light k32w061+release (read/write) 659928 660500 572 0.1
.bss 76600 76608 8 0.0
.data 1868 1868 0 0.0
.text 575660 576224 564 0.1
lock k32w061+release (read/write) 660732 661180 448 0.1
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576196 576644 448 0.1
linux chip-tool-ipv6only arm64 (read only) 8472012 8493172 21160 0.2
(read/write) 390001 390129 128 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260368 260440 72 0.0
.dynamic 560 560 0 0.0
.got 68704 68760 56 0.1
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435188 435372 184 0.0
.text 7200308 7220948 20640 0.3
thermostat-no-ble arm64 (read only) 2048444 2049740 1296 0.1
(read/write) 145681 145697 16 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72968 72984 16 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130380 130492 112 0.1
.text 1703648 1704752 1104 0.1
p6 all-clusters-app default (read/write) 2409104 2409600 496 0.0
.bss 117788 117756 -32 -0.0
.data 2584 2584 0 0.0
.text 1367368 1367864 496 0.0
light-app default (read/write) 2330040 2330584 544 0.0
.bss 105536 105544 8 0.0
.data 2408 2408 0 0.0
.text 1288304 1288848 544 0.0
lock-app default (read/write) 2299024 2299576 552 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257288 1257840 552 0.0
qpg lighting-app qpg6105+debug (read only) 566840 567400 560 0.1
(read/write) 146940 146940 0 0.0
.bss 89680 89688 8 0.0
.data 1064 1064 0 0.0
.text 561520 562080 560 0.1
lock-app qpg6105+debug (read only) 515336 515792 456 0.1
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510016 510472 456 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840934 841562 628 0.1
bss 87488 87492 4 0.0
noinit 37160 37160 0 0.0
text 587730 588208 478 0.1

@restyled-io restyled-io bot mentioned this pull request Jan 24, 2022
Closed
@boring-cyborg boring-cyborg bot added the linux label Jan 25, 2022
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13778: Size comparison from c428576 to ea25e12

Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c428576 ea25e12 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 572022 572258 236 0.0
.app_xip_area 477084 477320 236 0.0
efr32 lighting-app BRD4161A (read only) 832416 832688 272 0.0
.text 832408 832680 272 0.0
BRD4161A+rpc (read only) 819820 820068 248 0.0
.text 819812 820060 248 0.0
window-app BRD4161A (read only) 808608 808864 256 0.0
.text 808600 808856 256 0.0
esp32 all-clusters-app c3devkit (read only) 916812 916980 168 0.0
(read/write) 1317778 1317858 80 0.0
.flash.rodata 179440 179520 80 0.0
.flash.text 916812 916980 168 0.0
m5stack (read only) 965803 965955 152 0.0
(read/write) 450360 450432 72 0.0
.flash.rodata 208760 208832 72 0.0
.flash.text 960419 960571 152 0.0
k32w light k32w061+release (read/write) 660264 660592 328 0.0
.text 575140 575468 328 0.1
lock k32w061+release (read/write) 661156 661392 236 0.0
.text 575744 575980 236 0.0
linux thermostat-no-ble arm64 (read only) 2042268 2043436 1168 0.1
.rodata 130556 130620 64 0.0
.text 1697408 1698512 1104 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2349712 2349912 200 0.0
.text 1312312 1312512 200 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2331968 2332232 264 0.0
.text 1294568 1294832 264 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302552 2302816 264 0.0
.text 1265152 1265416 264 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940803 941035 232 0.0
rodata 109000 109072 72 0.1
text 635196 635356 160 0.0
nrf52840dk_nrf52840+rpc (read/write) 926287 926519 232 0.0
rodata 101452 101524 72 0.1
text 630588 630748 160 0.0
nrf52840dongle_nrf52840 (read/write) 991447 991679 232 0.0
rodata 113752 113824 72 0.1
text 667392 667552 160 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850630 850862 232 0.0
rodata 102176 102248 72 0.1
text 552116 552276 160 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911507 232 0.0
rodata 104056 104128 72 0.1
text 610772 610932 160 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821346 821578 232 0.0
rodata 97284 97356 72 0.1
text 527728 527888 160 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913951 914183 232 0.0
rodata 104444 104516 72 0.1
text 613236 613396 160 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909119 909351 232 0.0
rodata 103548 103620 72 0.1
text 609268 609428 160 0.0
p6 all-clusters-app default (read/write) 2407784 2408048 264 0.0
.text 1366048 1366312 264 0.0
light-app default (read/write) 2327520 2327768 248 0.0
.text 1285784 1286032 248 0.0
lock-app default (read/write) 2296960 2297208 248 0.0
.text 1255224 1255472 248 0.0
qpg lighting-app qpg6105+debug (read only) 565336 565672 336 0.1
.text 560016 560352 336 0.1
lock-app qpg6105+debug (read only) 514092 514324 232 0.0
.text 508772 509004 232 0.0
telink lighting-app tlsr9518adk80d (read/write) 839294 839534 240 0.0
text 585882 586050 168 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c428576 ea25e12 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 572022 572258 236 0.0
.app_xip_area 477084 477320 236 0.0
.bss 77684 77684 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 832416 832688 272 0.0
(read/write) 127216 127216 0 0.0
.bss 125312 125312 0 0.0
.data 1900 1900 0 0.0
.text 832408 832680 272 0.0
BRD4161A+rpc (read only) 819820 820068 248 0.0
(read/write) 143872 143872 0 0.0
.bss 141872 141872 0 0.0
.data 2000 2000 0 0.0
.text 819812 820060 248 0.0
window-app BRD4161A (read only) 808608 808864 256 0.0
(read/write) 125872 125872 0 0.0
.bss 124016 124016 0 0.0
.data 1856 1856 0 0.0
.text 808600 808856 256 0.0
esp32 all-clusters-app c3devkit (read only) 916812 916980 168 0.0
(read/write) 1317778 1317858 80 0.0
.dram0.bss 70696 70696 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 179440 179520 80 0.0
.flash.text 916812 916980 168 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965803 965955 152 0.0
(read/write) 450360 450432 72 0.0
.dram0.bss 75440 75440 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208760 208832 72 0.0
.flash.text 960419 960571 152 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660264 660592 328 0.0
.bss 77456 77456 0 0.0
.data 1868 1868 0 0.0
.text 575140 575468 328 0.1
lock k32w061+release (read/write) 661156 661392 236 0.0
.bss 77720 77720 0 0.0
.data 1892 1892 0 0.0
.text 575744 575980 236 0.0
linux chip-tool-ipv6only arm64 (read only) 8697804 8697804 0 0.0
(read/write) 390817 390817 0 0.0
.bss 56017 56017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260888 260888 0 0.0
.dynamic 560 560 0 0.0
.got 69040 69040 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532532 532532 0 0.0
.text 7326532 7326532 0 0.0
thermostat-no-ble arm64 (read only) 2042268 2043436 1168 0.1
(read/write) 146625 146625 0 0.0
.bss 65649 65649 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73072 73072 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130556 130620 64 0.0
.text 1697408 1698512 1104 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349712 2349912 200 0.0
.bss 189404 189404 0 0.0
.data 5296 5296 0 0.0
.text 1312312 1312512 200 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331968 2332232 264 0.0
.bss 180920 180920 0 0.0
.data 5576 5576 0 0.0
.text 1294568 1294832 264 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302552 2302816 264 0.0
.bss 180824 180824 0 0.0
.data 5568 5568 0 0.0
.text 1265152 1265416 264 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940803 941035 232 0.0
bss 119012 119012 0 0.0
rodata 109000 109072 72 0.1
text 635196 635356 160 0.0
nrf52840dk_nrf52840+rpc (read/write) 926287 926519 232 0.0
bss 116056 116056 0 0.0
rodata 101452 101524 72 0.1
text 630588 630748 160 0.0
nrf52840dongle_nrf52840 (read/write) 991447 991679 232 0.0
bss 121852 121852 0 0.0
rodata 113752 113824 72 0.1
text 667392 667552 160 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850630 850862 232 0.0
bss 115796 115796 0 0.0
rodata 102176 102248 72 0.1
text 552116 552276 160 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911507 232 0.0
bss 119064 119064 0 0.0
rodata 104056 104128 72 0.1
text 610772 610932 160 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821346 821578 232 0.0
bss 115880 115880 0 0.0
rodata 97284 97356 72 0.1
text 527728 527888 160 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913951 914183 232 0.0
bss 118808 118808 0 0.0
rodata 104444 104516 72 0.1
text 613236 613396 160 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909119 909351 232 0.0
bss 118836 118836 0 0.0
rodata 103548 103620 72 0.1
text 609268 609428 160 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451316 451316 0 0.0
p6 all-clusters-app default (read/write) 2407784 2408048 264 0.0
.bss 117748 117748 0 0.0
.data 2584 2584 0 0.0
.text 1366048 1366312 264 0.0
light-app default (read/write) 2327520 2327768 248 0.0
.bss 105512 105512 0 0.0
.data 2408 2408 0 0.0
.text 1285784 1286032 248 0.0
lock-app default (read/write) 2296960 2297208 248 0.0
.bss 105256 105256 0 0.0
.data 2360 2360 0 0.0
.text 1255224 1255472 248 0.0
qpg lighting-app qpg6105+debug (read only) 565336 565672 336 0.1
(read/write) 146936 146936 0 0.0
.bss 89656 89656 0 0.0
.data 1060 1060 0 0.0
.text 560016 560352 336 0.1
lock-app qpg6105+debug (read only) 514092 514324 232 0.0
(read/write) 146940 146940 0 0.0
.bss 89128 89128 0 0.0
.data 992 992 0 0.0
.text 508772 509004 232 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839294 839534 240 0.0
bss 87460 87460 0 0.0
noinit 37160 37160 0 0.0
text 585882 586050 168 0.0

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #13778: Size comparison from 12253c6 to 8f0723c

Increases (6 builds for k32w, mbed, nrfconnect, qpg)
platform target config section 12253c6 8f0723c change % change
k32w light k32w061+release (read/write) 664844 664956 112 0.0
.text 579580 579692 112 0.0
mbed shell CY8CPROTO_062_4343W+release (read/write) 2293900 2293996 96 0.0
.text 1256472 1256568 96 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983315 983411 96 0.0
rodata 116408 116440 32 0.0
text 668284 668356 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 967175 967275 100 0.0
rodata 107940 107976 36 0.0
text 662956 663028 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892518 892630 112 0.0
rodata 109704 109736 32 0.0
text 584464 584536 72 0.0
qpg lighting-app qpg6105+debug (read only) 571684 571788 104 0.0
.text 566364 566468 104 0.0
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12253c6 8f0723c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580050 580050 0 0.0
.app_xip_area 484972 484972 0 0.0
.bss 77824 77824 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842804 842804 0 0.0
(read/write) 127364 127364 0 0.0
.bss 125464 125464 0 0.0
.data 1900 1900 0 0.0
.text 842796 842796 0 0.0
BRD4161A+rpc (read only) 830160 830160 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142024 142024 0 0.0
.data 2000 2000 0 0.0
.text 830152 830152 0 0.0
window-app BRD4161A (read only) 815436 815436 0 0.0
(read/write) 126020 126020 0 0.0
.bss 124164 124164 0 0.0
.data 1856 1856 0 0.0
.text 815428 815428 0 0.0
esp32 all-clusters-app c3devkit (read only) 921048 921048 0 0.0
(read/write) 1384650 1384650 0 0.0
.dram0.bss 70840 70840 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180632 180632 0 0.0
.flash.text 921048 921048 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970015 970015 0 0.0
(read/write) 451664 451664 0 0.0
.dram0.bss 75584 75584 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209920 209920 0 0.0
.flash.text 964631 964631 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 664844 664956 112 0.0
.bss 77596 77596 0 0.0
.data 1868 1868 0 0.0
.text 579580 579692 112 0.0
lock k32w061+release (read/write) 665840 665840 0 0.0
.bss 77860 77860 0 0.0
.data 1892 1892 0 0.0
.text 580288 580288 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8729748 8729748 0 0.0
(read/write) 392273 392273 0 0.0
.bss 56241 56241 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261872 261872 0 0.0
.dynamic 560 560 0 0.0
.got 69280 69280 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534252 534252 0 0.0
.text 7353748 7353748 0 0.0
thermostat-no-ble arm64 (read only) 2059236 2059236 0 0.0
(read/write) 147473 147473 0 0.0
.bss 65857 65857 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73648 73648 0 0.0
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131396 0 0.0
.text 1712048 1712048 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355000 2355000 0 0.0
.bss 189548 189548 0 0.0
.data 5296 5296 0 0.0
.text 1317600 1317600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340992 2340992 0 0.0
.bss 181072 181072 0 0.0
.data 5584 5584 0 0.0
.text 1303592 1303592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307736 2307736 0 0.0
.bss 180968 180968 0 0.0
.data 5568 5568 0 0.0
.text 1270336 1270336 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293900 2293996 96 0.0
.bss 177700 177700 0 0.0
.data 5384 5384 0 0.0
.text 1256472 1256568 96 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983315 983411 96 0.0
bss 120828 120828 0 0.0
rodata 116408 116440 32 0.0
text 668284 668356 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 967175 967275 100 0.0
bss 117872 117872 0 0.0
rodata 107940 107976 36 0.0
text 662956 663028 72 0.0
nrf52840dongle_nrf52840 (read/write) 999499 999499 0 0.0
bss 122000 122000 0 0.0
rodata 115292 115292 0 0.0
text 673744 673744 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892518 892630 112 0.0
bss 117616 117616 0 0.0
rodata 109704 109736 32 0.0
text 584464 584536 72 0.0
lock-app nrf52840dk_nrf52840 (read/write) 915991 915991 0 0.0
bss 119208 119208 0 0.0
rodata 105076 105076 0 0.0
text 614308 614308 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826030 826030 0 0.0
bss 116024 116024 0 0.0
rodata 98304 98304 0 0.0
text 531260 531260 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918667 918667 0 0.0
bss 118952 118952 0 0.0
rodata 105464 105464 0 0.0
text 616772 616772 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 913835 913835 0 0.0
bss 118980 118980 0 0.0
rodata 104568 104568 0 0.0
text 612804 612804 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533652 533652 0 0.0
p6 all-clusters-app default (read/write) 2414912 2414912 0 0.0
.bss 117892 117892 0 0.0
.data 2584 2584 0 0.0
.text 1373176 1373176 0 0.0
light-app default (read/write) 2338392 2338392 0 0.0
.bss 105652 105652 0 0.0
.data 2408 2408 0 0.0
.text 1296656 1296656 0 0.0
lock-app default (read/write) 2303928 2303928 0 0.0
.bss 105396 105396 0 0.0
.data 2360 2360 0 0.0
.text 1262192 1262192 0 0.0
qpg lighting-app qpg6105+debug (read only) 571684 571788 104 0.0
(read/write) 146936 146936 0 0.0
.bss 89808 89808 0 0.0
.data 1060 1060 0 0.0
.text 566364 566468 104 0.0
lock-app qpg6105+debug (read only) 517876 517876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89280 89280 0 0.0
.data 992 992 0 0.0
.text 512556 512556 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 847910 847910 0 0.0
bss 87608 87608 0 0.0
noinit 37160 37160 0 0.0
text 592750 592750 0 0.0

@selissia selissia merged commit 3a1a5b0 into project-chip:master Jan 26, 2022
selissia added a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@selissia @restyled-commits
[OTA Requestor] Implement the CancelImageUpdate() OTARequestor API (p…
646f185 
…roject-chip#13778)

* Implement the CancelImageUpdate() OTARequestor API

* Restyled by clang-format

* Add CancelImageUpdate() to OTARequestorInterface

* Add the override modifier

* Add UpdateCancelled() API to OTARequestorDriver

* Restyled by clang-format

* Fix a bug in SetBlock() where varied block size will kill the download

Issue: project-chip#13393

Co-authored-by: Restyled.io <[email protected]>
@selissia selissia deleted the ota_cancel_download branch May 12, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@carol-apple carol-apple carol-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Most versions of OTAImageProcessorImpl::SetBlock are broken
6 participants
@selissia @LuDuda @woody-apple @carol-apple @jmartinez-silabs @restyled-commits