Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation errors in scenes-client and groups-client #13754

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix compilation errors in scenes-client and groups-client #13754

merged 1 commit into from
Jan 21, 2022

Conversation

chiragatal
Copy link
Contributor

@chiragatal chiragatal commented Jan 20, 2022 •
edited
Loading

Problem

  • Compilation errors when the scenes-client or groups-client cluster is included from src/app/clusters/ like:
error: zero-length gnu_printf format string [-Werror=format-zero-length]: emberAfGroupsClusterPrintln("");

Change overview

  • Updated the error lines similar to how it is done in other clusters
  • Also fixed an include error in scenes-client

Testing

  • Compilation worked fine when including these clusters

@boring-cyborg boring-cyborg bot added the app label Jan 20, 2022
@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13754: Size comparison from 914ba3e to 3d0c27c

Full report (11 builds for k32w, linux, p6, qpg, telink)
platform target config section 914ba3e4 3d0c27c change % change
k32w light k32w061+release (read/write) 656696 656696 0 0.0
.bss 76608 76608 0 0.0
.data 1864 1864 0 0.0
.text 572424 572424 0 0.0
lock k32w061+release (read/write) 659400 659400 0 0.0
.bss 76904 76904 0 0.0
.data 1884 1884 0 0.0
.text 574812 574812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8155868 8155868 0 0.0
(read/write) 376481 376481 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 249928 249928 0 0.0
.dynamic 560 560 0 0.0
.got 65632 65632 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 423044 423044 0 0.0
.text 6928708 6928708 0 0.0
thermostat-no-ble arm64 (read only) 2033476 2033476 0 0.0
(read/write) 144417 144417 0 0.0
.bss 63841 63841 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72704 72704 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129508 129508 0 0.0
.text 1689952 1689952 0 0.0
p6 all-clusters-app default (read/write) 2403648 2403648 0 0.0
.bss 117068 117068 0 0.0
.data 2568 2568 0 0.0
.text 1361912 1361912 0 0.0
light-app default (read/write) 2327768 2327768 0 0.0
.bss 105600 105600 0 0.0
.data 2408 2408 0 0.0
.text 1286032 1286032 0 0.0
lock-app default (read/write) 2296792 2296792 0 0.0
.bss 104448 104448 0 0.0
.data 2352 2352 0 0.0
.text 1255056 1255056 0 0.0
qpg lighting-app qpg6105+debug (read only) 563480 563480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89696 89696 0 0.0
.data 1060 1060 0 0.0
.text 558160 558160 0 0.0
lock-app qpg6105+debug (read only) 513836 513836 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88320 88320 0 0.0
.data 984 984 0 0.0
.text 508516 508516 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838018 838018 0 0.0
bss 86772 86772 0 0.0
noinit 37160 37160 0 0.0
text 585862 585862 0 0.0

@chiragatal chiragatal force-pushed the bugfix/compilation_fixes branch from 3d0c27c to 631a460 Compare January 20, 2022 10:21
@restyled-io restyled-io bot mentioned this pull request Jan 20, 2022
Closed
@chiragatal chiragatal force-pushed the bugfix/compilation_fixes branch from 631a460 to 63cf65c Compare January 20, 2022 10:28
@chiragatal chiragatal force-pushed the bugfix/compilation_fixes branch from 63cf65c to 64bf7da Compare January 20, 2022 10:37
@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13754: Size comparison from 914ba3e to 64bf7da

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 914ba3e4 64bf7da change % change
efr32 lighting-app BRD4161A (read only) 832684 832684 0 0.0
(read/write) 127112 127112 0 0.0
.bss 125216 125216 0 0.0
.data 1896 1896 0 0.0
.text 832676 832676 0 0.0
BRD4161A+rpc (read only) 820080 820080 0 0.0
(read/write) 143776 143776 0 0.0
.bss 141776 141776 0 0.0
.data 1996 1996 0 0.0
.text 820072 820072 0 0.0
window-app BRD4161A (read only) 803268 803268 0 0.0
(read/write) 125800 125800 0 0.0
.bss 123952 123952 0 0.0
.data 1848 1848 0 0.0
.text 803260 803260 0 0.0
esp32 all-clusters-app c3devkit (read only) 910524 910524 0 0.0
(read/write) 1315850 1315850 0 0.0
.dram0.bss 70024 70024 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 178096 178096 0 0.0
.flash.text 910524 910524 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959535 959535 0 0.0
(read/write) 448008 448008 0 0.0
.dram0.bss 74480 74480 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 207368 207368 0 0.0
.flash.text 954151 954151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656696 656696 0 0.0
.bss 76608 76608 0 0.0
.data 1864 1864 0 0.0
.text 572424 572424 0 0.0
lock k32w061+release (read/write) 659400 659400 0 0.0
.bss 76904 76904 0 0.0
.data 1884 1884 0 0.0
.text 574812 574812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8155868 8155868 0 0.0
(read/write) 376481 376481 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 249928 249928 0 0.0
.dynamic 560 560 0 0.0
.got 65632 65632 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 423044 423044 0 0.0
.text 6928708 6928708 0 0.0
thermostat-no-ble arm64 (read only) 2033476 2033476 0 0.0
(read/write) 144417 144417 0 0.0
.bss 63841 63841 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72704 72704 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129508 129508 0 0.0
.text 1689952 1689952 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347504 2347504 0 0.0
.bss 188732 188732 0 0.0
.data 5296 5296 0 0.0
.text 1310080 1310080 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331768 2331768 0 0.0
.bss 180232 180232 0 0.0
.data 5576 5576 0 0.0
.text 1294368 1294368 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302120 2302120 0 0.0
.bss 179240 179240 0 0.0
.data 5552 5552 0 0.0
.text 1264720 1264720 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940967 940967 0 0.0
bss 119100 119100 0 0.0
rodata 108492 108492 0 0.0
text 635796 635796 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926463 926463 0 0.0
bss 116144 116144 0 0.0
rodata 100940 100940 0 0.0
text 631192 631192 0 0.0
nrf52840dongle_nrf52840 (read/write) 991643 991643 0 0.0
bss 121944 121944 0 0.0
rodata 113244 113244 0 0.0
text 667996 667996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850826 850826 0 0.0
bss 115888 115888 0 0.0
rodata 101668 101668 0 0.0
text 552720 552720 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910343 910343 0 0.0
bss 118256 118256 0 0.0
rodata 103460 103460 0 0.0
text 611244 611244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820378 820378 0 0.0
bss 115072 115072 0 0.0
rodata 96684 96684 0 0.0
text 528200 528200 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913215 913215 0 0.0
bss 118020 118020 0 0.0
rodata 103820 103820 0 0.0
text 613892 613892 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908263 908263 0 0.0
bss 118044 118044 0 0.0
rodata 102932 102932 0 0.0
text 609820 609820 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2403648 2403648 0 0.0
.bss 117068 117068 0 0.0
.data 2568 2568 0 0.0
.text 1361912 1361912 0 0.0
light-app default (read/write) 2327768 2327768 0 0.0
.bss 105600 105600 0 0.0
.data 2408 2408 0 0.0
.text 1286032 1286032 0 0.0
lock-app default (read/write) 2296792 2296792 0 0.0
.bss 104448 104448 0 0.0
.data 2352 2352 0 0.0
.text 1255056 1255056 0 0.0
qpg lighting-app qpg6105+debug (read only) 563480 563480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89696 89696 0 0.0
.data 1060 1060 0 0.0
.text 558160 558160 0 0.0
lock-app qpg6105+debug (read only) 513836 513836 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88320 88320 0 0.0
.data 984 984 0 0.0
.text 508516 508516 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838018 838018 0 0.0
bss 86772 86772 0 0.0
noinit 37160 37160 0 0.0
text 585862 585862 0 0.0

@andy31415 andy31415 merged commit 04f39b9 into project-chip:master Jan 21, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@chiragatal @selissia
Fix compilation errors in scenes-client and groups-client (project-ch…
425f350 
…ip#13754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@gjc13 gjc13 gjc13 approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chiragatal @andy31415 @dhrishi @gjc13 @Damian-Nordic