Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ACL event fields to align with the spec #13738

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Update the ACL event fields to align with the spec #13738

merged 1 commit into from
Jan 20, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Some fields of AccessControlEntryChanged and AccessControlExtensionChanged should be marked as nullable per spec

Change overview

Update the ACL event fields to align with the spec

Testing

How was this tested? (at least one bullet point required)

  • xml update only, no source code change

@github-actions
Copy link

github-actions bot commented Jan 20, 2022

PR #13738: Size comparison from 332f97c to f859626

Increases (1 build for linux)
platform target config section 332f97c f859626 change % change
linux chip-tool-ipv6only arm64 (read only) 8144364 8147260 2896 0.0
.text 6923380 6926276 2896 0.0
Decreases (1 build for esp32)
platform target config section 332f97c f859626 change % change
esp32 all-clusters-app m5stack (read only) 961407 961399 -8 -0.0
.flash.text 956023 956015 -8 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 332f97c f859626 change % change
efr32 lighting-app BRD4161A (read only) 834932 834932 0 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834924 834924 0 0.0
BRD4161A+rpc (read only) 822336 822336 0 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822328 822328 0 0.0
window-app BRD4161A (read only) 805520 805520 0 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805512 805512 0 0.0
esp32 all-clusters-app c3devkit (read only) 912642 912642 0 0.0
(read/write) 1316642 1316642 0 0.0
.dram0.bss 70568 70568 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 178344 178344 0 0.0
.flash.text 912642 912642 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961407 961399 -8 -0.0
(read/write) 448792 448792 0 0.0
.dram0.bss 75024 75024 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 207616 207616 0 0.0
.flash.text 956023 956015 -8 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659076 659076 0 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574280 574280 0 0.0
lock k32w061+release (read/write) 661856 661856 0 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576744 576744 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8144364 8147260 2896 0.0
(read/write) 374497 374497 0 0.0
.bss 55345 55345 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 248800 248800 0 0.0
.dynamic 560 560 0 0.0
.got 65512 65512 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 422724 422724 0 0.0
.text 6923380 6926276 2896 0.0
thermostat-no-ble arm64 (read only) 2044092 2044092 0 0.0
(read/write) 145905 145905 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 72952 72952 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129916 129916 0 0.0
.text 1699808 1699808 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350368 2350368 0 0.0
.bss 189260 189260 0 0.0
.data 5288 5288 0 0.0
.text 1312944 1312944 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334568 2334568 0 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297168 1297168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304920 2304920 0 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267520 1267520 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943427 943427 0 0.0
bss 119628 119628 0 0.0
rodata 108760 108760 0 0.0
text 637448 637448 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928895 928895 0 0.0
bss 116672 116672 0 0.0
rodata 101212 101212 0 0.0
text 632840 632840 0 0.0
nrf52840dongle_nrf52840 (read/write) 994107 994107 0 0.0
bss 122472 122472 0 0.0
rodata 113516 113516 0 0.0
text 669644 669644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853254 853254 0 0.0
bss 116416 116416 0 0.0
rodata 101936 101936 0 0.0
text 554368 554368 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912787 912787 0 0.0
bss 118784 118784 0 0.0
rodata 103728 103728 0 0.0
text 612896 612896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822842 822842 0 0.0
bss 115600 115600 0 0.0
rodata 96956 96956 0 0.0
text 529852 529852 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915639 915639 0 0.0
bss 118548 118548 0 0.0
rodata 104092 104092 0 0.0
text 615544 615544 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910723 910723 0 0.0
bss 118572 118572 0 0.0
rodata 103200 103200 0 0.0
text 611472 611472 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2405904 2405904 0 0.0
.bss 117596 117596 0 0.0
.data 2568 2568 0 0.0
.text 1364168 1364168 0 0.0
light-app default (read/write) 2330024 2330024 0 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288288 1288288 0 0.0
lock-app default (read/write) 2299048 2299048 0 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257312 1257312 0 0.0
qpg lighting-app qpg6105+debug (read only) 565128 565128 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559808 559808 0 0.0
lock-app qpg6105+debug (read only) 515540 515540 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510220 510220 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840802 840802 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587822 587822 0 0.0

Copy link
Contributor

@mlepage-google mlepage-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep those should be nullable.

@andy31415
Copy link
Contributor

fast track: small and readable delta, changes approved by a domain owner.

@andy31415 andy31415 merged commit 947d5bd into project-chip:master Jan 20, 2022
@yufengwangca yufengwangca deleted the pr/acl/xml branch January 20, 2022 22:38
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants