Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for contact sensor #13735

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Add support for contact sensor #13735

merged 1 commit into from
Jan 26, 2022

Conversation

nivi-apple
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Add contact sensor support

Change overview

Add contact sensor support

Testing

How was this tested? (at least one bullet point required)
Tested using m5stack

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13735: Size comparison from d5e7431 to 6e64318

Increases (2 builds for esp32)
platform target config section d5e7431 6e64318 change % change
esp32 all-clusters-app c3devkit (read only) 912524 912684 160 0.0
(read/write) 1316642 1316674 32 0.0
.flash.rodata 178344 178376 32 0.0
.flash.text 912524 912684 160 0.0
m5stack (read only) 961311 961451 140 0.0
(read/write) 448800 448832 32 0.0
.flash.rodata 207616 207648 32 0.0
.flash.text 955927 956067 140 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d5e7431 6e64318 change % change
efr32 lighting-app BRD4161A (read only) 834868 834868 0 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834860 834860 0 0.0
BRD4161A+rpc (read only) 822272 822272 0 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822264 822264 0 0.0
window-app BRD4161A (read only) 805440 805440 0 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805432 805432 0 0.0
esp32 all-clusters-app c3devkit (read only) 912524 912684 160 0.0
(read/write) 1316642 1316674 32 0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 178344 178376 32 0.0
.flash.text 912524 912684 160 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961311 961451 140 0.0
(read/write) 448800 448832 32 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207616 207648 32 0.0
.flash.text 955927 956067 140 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659076 659076 0 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574280 574280 0 0.0
lock k32w061+release (read/write) 661808 661808 0 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576696 576696 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8140348 8140348 0 0.0
(read/write) 374497 374497 0 0.0
.bss 55345 55345 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 248800 248800 0 0.0
.dynamic 560 560 0 0.0
.got 65512 65512 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 422692 422692 0 0.0
.text 6919396 6919396 0 0.0
thermostat-no-ble arm64 (read only) 2043900 2043900 0 0.0
(read/write) 145905 145905 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 72952 72952 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129916 129916 0 0.0
.text 1699616 1699616 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350304 2350304 0 0.0
.bss 189220 189220 0 0.0
.data 5328 5328 0 0.0
.text 1312880 1312880 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334568 2334568 0 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297168 1297168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304920 2304920 0 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267520 1267520 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943379 943379 0 0.0
bss 119628 119628 0 0.0
rodata 108760 108760 0 0.0
text 637408 637408 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928863 928863 0 0.0
bss 116672 116672 0 0.0
rodata 101212 101212 0 0.0
text 632804 632804 0 0.0
nrf52840dongle_nrf52840 (read/write) 994059 994059 0 0.0
bss 122472 122472 0 0.0
rodata 113516 113516 0 0.0
text 669608 669608 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853222 853222 0 0.0
bss 116416 116416 0 0.0
rodata 101936 101936 0 0.0
text 554332 554332 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912739 912739 0 0.0
bss 118784 118784 0 0.0
rodata 103728 103728 0 0.0
text 612856 612856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822810 822810 0 0.0
bss 115600 115600 0 0.0
rodata 96956 96956 0 0.0
text 529816 529816 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915607 915607 0 0.0
bss 118548 118548 0 0.0
rodata 104092 104092 0 0.0
text 615508 615508 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910675 910675 0 0.0
bss 118572 118572 0 0.0
rodata 103200 103200 0 0.0
text 611432 611432 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2405568 2405568 0 0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363832 1363832 0 0.0
light-app default (read/write) 2330008 2330008 0 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288272 1288272 0 0.0
lock-app default (read/write) 2299032 2299032 0 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257296 1257296 0 0.0
qpg lighting-app qpg6105+debug (read only) 565096 565096 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559776 559776 0 0.0
lock-app qpg6105+debug (read only) 515492 515492 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510172 510172 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840754 840754 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587778 587778 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13735: Size comparison from d9cc25f to 192eaa7

Increases (2 builds for esp32)
platform target config section d9cc25f 192eaa7 change % change
esp32 all-clusters-app c3devkit (read only) 919274 919430 156 0.0
(read/write) 1376930 1376962 32 0.0
.flash.rodata 176184 176216 32 0.0
.flash.text 919274 919430 156 0.0
m5stack (read only) 967963 968103 140 0.0
(read/write) 443792 443824 32 0.0
.flash.rodata 205504 205536 32 0.0
.flash.text 962579 962719 140 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d9cc25f 192eaa7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573738 573738 0 0.0
.app_xip_area 479040 479040 0 0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835492 835492 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835484 835484 0 0.0
BRD4161A+rpc (read only) 822896 822896 0 0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822888 822888 0 0.0
window-app BRD4161A (read only) 806332 806332 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806324 806324 0 0.0
esp32 all-clusters-app c3devkit (read only) 919274 919430 156 0.0
(read/write) 1376930 1376962 32 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176184 176216 32 0.0
.flash.text 919274 919430 156 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967963 968103 140 0.0
(read/write) 443792 443824 32 0.0
.dram0.bss 72128 72128 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205504 205536 32 0.0
.flash.text 962579 962719 140 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661008 661008 0 0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 576116 576116 0 0.0
lock k32w061+release (read/write) 662104 662104 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576924 576924 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8706740 8706740 0 0.0
(read/write) 390913 390913 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260944 260944 0 0.0
.dynamic 560 560 0 0.0
.got 69048 69048 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532700 532700 0 0.0
.text 7335156 7335156 0 0.0
thermostat-no-ble arm64 (read only) 2050588 2050588 0 0.0
(read/write) 145937 145937 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706288 1706288 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349088 2349088 0 0.0
.bss 186084 186084 0 0.0
.data 5296 5296 0 0.0
.text 1311664 1311664 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334288 2334288 0 0.0
.bss 180688 180688 0 0.0
.data 5576 5576 0 0.0
.text 1296888 1296888 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304872 2304872 0 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267472 1267472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942467 942467 0 0.0
bss 118776 118776 0 0.0
rodata 108824 108824 0 0.0
text 637280 637280 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 927967 927967 0 0.0
bss 115820 115820 0 0.0
rodata 101276 101276 0 0.0
text 632672 632672 0 0.0
nrf52840dongle_nrf52840 (read/write) 993127 993127 0 0.0
bss 121616 121616 0 0.0
rodata 113576 113576 0 0.0
text 669476 669476 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852326 852326 0 0.0
bss 115564 115564 0 0.0
rodata 102000 102000 0 0.0
text 554200 554200 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912971 912971 0 0.0
bss 118828 118828 0 0.0
rodata 103880 103880 0 0.0
text 612856 612856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822994 822994 0 0.0
bss 115648 115648 0 0.0
rodata 97108 97108 0 0.0
text 529812 529812 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915631 915631 0 0.0
bss 118576 118576 0 0.0
rodata 104268 104268 0 0.0
text 615320 615320 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910815 910815 0 0.0
bss 118600 118600 0 0.0
rodata 103372 103372 0 0.0
text 611352 611352 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533644 533644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451320 451320 0 0.0
p6 all-clusters-app default (read/write) 2407808 2407808 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1366072 1366072 0 0.0
light-app default (read/write) 2330624 2330624 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288888 1288888 0 0.0
lock-app default (read/write) 2300048 2300048 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1258312 1258312 0 0.0
qpg lighting-app qpg6105+debug (read only) 567232 567232 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561912 561912 0 0.0
lock-app qpg6105+debug (read only) 516044 516044 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510724 510724 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841334 841334 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588334 588334 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given platform changes.

@woody-apple woody-apple merged commit 4ece9e8 into project-chip:master Jan 26, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@nivi-apple @selissia
Add support for contact sensor (project-chip#13735)
62cacae
@nivi-apple nivi-apple deleted the contact_sensor branch March 5, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nivi-apple @woody-apple @andy31415 @bzbarsky-apple