Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch errors retrieving certs #13724

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Catch errors retrieving certs #13724

merged 1 commit into from
Jan 19, 2022

Conversation

mrjerryjohns
Copy link
Contributor

Problem:

We're not catching errors when calling GetRootPubkey and
GetTrustedRootId. This results in failures happening a fair bit later
in non-obvious ways in some of the Cirque runs.

Fix:

Catch the error so that we can at least log where the error is happening
in CI.

@mrjerryjohns
Catch errors retrieving certs
1774918 
Problem:

We're not catching errors when calling `GetRootPubkey` and
`GetTrustedRootId`. This results in failures happening a fair bit later
in non-obvious ways in some of the Cirque runs.

Fix:

Catch the error so that we can at least log where the error is happening
in CI.
@boring-cyborg boring-cyborg bot added the app label Jan 19, 2022
@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13724: Size comparison from ffd25d8 to 1774918

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ffd25d8 1774918 change % change
efr32 lighting-app BRD4161A (read only) 834836 834868 32 0.0
.text 834828 834860 32 0.0
BRD4161A+rpc (read only) 822224 822272 48 0.0
.text 822216 822264 48 0.0
window-app BRD4161A (read only) 805408 805440 32 0.0
.text 805400 805432 32 0.0
esp32 all-clusters-app c3devkit (read only) 912466 912524 58 0.0
.flash.text 912466 912524 58 0.0
m5stack (read only) 961247 961311 64 0.0
.flash.text 955863 955927 64 0.0
k32w light k32w061+release (read/write) 659060 659076 16 0.0
.text 574264 574280 16 0.0
lock k32w061+release (read/write) 661792 661808 16 0.0
.text 576680 576696 16 0.0
linux chip-tool-ipv6only arm64 (read only) 8122444 8122700 256 0.0
.text 6902804 6903060 256 0.0
thermostat-no-ble arm64 (read only) 2043580 2043900 320 0.0
.text 1699296 1699616 320 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2350160 2350304 144 0.0
.text 1312736 1312880 144 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2334424 2334568 144 0.0
.text 1297024 1297168 144 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304768 2304920 152 0.0
.text 1267368 1267520 152 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943347 943379 32 0.0
text 637368 637408 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 928831 928863 32 0.0
text 632764 632804 40 0.0
nrf52840dongle_nrf52840 (read/write) 994027 994059 32 0.0
text 669568 669608 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853174 853222 48 0.0
text 554292 554332 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912707 912739 32 0.0
text 612816 612856 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822778 822810 32 0.0
text 529776 529816 40 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915559 915607 48 0.0
text 615468 615508 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910643 910675 32 0.0
text 611392 611432 40 0.0
p6 all-clusters-app default (read/write) 2405536 2405568 32 0.0
.text 1363800 1363832 32 0.0
light-app default (read/write) 2329976 2330008 32 0.0
.text 1288240 1288272 32 0.0
lock-app default (read/write) 2299000 2299032 32 0.0
.text 1257264 1257296 32 0.0
qpg lighting-app qpg6105+debug (read only) 565064 565096 32 0.0
.text 559744 559776 32 0.0
lock-app qpg6105+debug (read only) 515476 515492 16 0.0
.text 510156 510172 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 840698 840754 56 0.0
text 587724 587778 54 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ffd25d8 1774918 change % change
efr32 lighting-app BRD4161A (read only) 834836 834868 32 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834828 834860 32 0.0
BRD4161A+rpc (read only) 822224 822272 48 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822216 822264 48 0.0
window-app BRD4161A (read only) 805408 805440 32 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805400 805432 32 0.0
esp32 all-clusters-app c3devkit (read only) 912466 912524 58 0.0
(read/write) 1316642 1316642 0 0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 178344 178344 0 0.0
.flash.text 912466 912524 58 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961247 961311 64 0.0
(read/write) 448800 448800 0 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207616 207616 0 0.0
.flash.text 955863 955927 64 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659060 659076 16 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574264 574280 16 0.0
lock k32w061+release (read/write) 661792 661808 16 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576680 576696 16 0.0
linux chip-tool-ipv6only arm64 (read only) 8122444 8122700 256 0.0
(read/write) 374145 374145 0 0.0
.bss 55217 55217 0 0.0
.data 1112 1112 0 0.0
.data.rel.ro 248632 248632 0 0.0
.dynamic 560 560 0 0.0
.got 65488 65488 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 422212 422212 0 0.0
.text 6902804 6903060 256 0.0
thermostat-no-ble arm64 (read only) 2043580 2043900 320 0.0
(read/write) 145905 145905 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 72952 72952 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129916 129916 0 0.0
.text 1699296 1699616 320 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350160 2350304 144 0.0
.bss 189220 189220 0 0.0
.data 5328 5328 0 0.0
.text 1312736 1312880 144 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334424 2334568 144 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297024 1297168 144 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304768 2304920 152 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267368 1267520 152 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943347 943379 32 0.0
bss 119628 119628 0 0.0
rodata 108760 108760 0 0.0
text 637368 637408 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 928831 928863 32 0.0
bss 116672 116672 0 0.0
rodata 101212 101212 0 0.0
text 632764 632804 40 0.0
nrf52840dongle_nrf52840 (read/write) 994027 994059 32 0.0
bss 122472 122472 0 0.0
rodata 113516 113516 0 0.0
text 669568 669608 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853174 853222 48 0.0
bss 116416 116416 0 0.0
rodata 101936 101936 0 0.0
text 554292 554332 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912707 912739 32 0.0
bss 118784 118784 0 0.0
rodata 103728 103728 0 0.0
text 612816 612856 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822778 822810 32 0.0
bss 115600 115600 0 0.0
rodata 96956 96956 0 0.0
text 529776 529816 40 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915559 915607 48 0.0
bss 118548 118548 0 0.0
rodata 104092 104092 0 0.0
text 615468 615508 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910643 910675 32 0.0
bss 118572 118572 0 0.0
rodata 103200 103200 0 0.0
text 611392 611432 40 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2405536 2405568 32 0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363800 1363832 32 0.0
light-app default (read/write) 2329976 2330008 32 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288240 1288272 32 0.0
lock-app default (read/write) 2299000 2299032 32 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257264 1257296 32 0.0
qpg lighting-app qpg6105+debug (read only) 565064 565096 32 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559744 559776 32 0.0
lock-app qpg6105+debug (read only) 515476 515492 16 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510156 510172 16 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840698 840754 56 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587724 587778 54 0.0

@andy31415
Copy link
Contributor

fast track: small delta, created and approved by domain owners.

@andy31415 andy31415 merged commit d33251b into project-chip:master Jan 19, 2022
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jan 26, 2022
Closed
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@mrjerryjohns @selissia
Catch errors retrieving certs (project-chip#13724)
f9a5c68 
Problem:

We're not catching errors when calling `GetRootPubkey` and
`GetTrustedRootId`. This results in failures happening a fair bit later
in non-obvious ways in some of the Cirque runs.

Fix:

Catch the error so that we can at least log where the error is happening
in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrjerryjohns @andy31415 @bzbarsky-apple