-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDL] Assume readwrite is the default for attributes #13707
Merged
andy31415
merged 1 commit into
project-chip:master
from
andy31415:idl/rw_is_default_for_attrs
Jan 19, 2022
Merged
[IDL] Assume readwrite is the default for attributes #13707
andy31415
merged 1 commit into
project-chip:master
from
andy31415:idl/rw_is_default_for_attrs
Jan 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y special case. Reduce bracketing
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
erjiaqing
January 19, 2022 16:31
pullapprove
bot
requested review from
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
January 19, 2022 16:31
PR #13707: Size comparison from 41d3a6c to 2e89cc2 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 19, 2022
fast track: IDL changes are free form text really, do not affect SDK workings. |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…y special case. Reduce bracketing (project-chip#13707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Based on side discussion with @tcarmelveilleux : readwrite should be assumed default. Added 'readonly' as the only special marker for now and added a TODO for eventual 'writeonly' support which I do not believe zap supports.
Change overview
IDL change to only show readonly. Placed it in front instead of brackets.
Testing
Manual IDL generation and review. CI will also validate.