Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose array size limit in IDL where size limit seems intentional #13699

Merged
merged 10 commits into from
Jan 21, 2022
Merged

Expose array size limit in IDL where size limit seems intentional #13699

merged 10 commits into from
Jan 21, 2022

Conversation

andy31415
Copy link
Contributor

Problem

We have internal size limits for arrays, and some of them are intentional while some development-restriction (i.e. 254 to say "unlimited").

Change overview

Add an array size for attributes in the IDL where the size seems intentional (smaller than 254).

Testing

Manual view of the resulting IDL files.

@andy31415
Copy link
Contributor Author

/rebase

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13699: Size comparison from ffd25d8 to d60c0e6

Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section ffd25d8 d60c0e6 change % change
efr32 lighting-app BRD4161A (read only) 834836 834836 0 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834828 834828 0 0.0
BRD4161A+rpc (read only) 822224 822224 0 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822216 822216 0 0.0
window-app BRD4161A (read only) 805408 805408 0 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805400 805400 0 0.0
esp32 all-clusters-app c3devkit (read only) 912466 912466 0 0.0
(read/write) 1316642 1316642 0 0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 178344 178344 0 0.0
.flash.text 912466 912466 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961247 961247 0 0.0
(read/write) 448800 448800 0 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207616 207616 0 0.0
.flash.text 955863 955863 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659060 659060 0 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574264 574264 0 0.0
lock k32w061+release (read/write) 661792 661792 0 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576680 576680 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350160 2350160 0 0.0
.bss 189220 189220 0 0.0
.data 5328 5328 0 0.0
.text 1312736 1312736 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334424 2334424 0 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297024 1297024 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304768 2304768 0 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267368 1267368 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943347 943347 0 0.0
bss 119628 119628 0 0.0
rodata 108760 108760 0 0.0
text 637368 637368 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928831 928831 0 0.0
bss 116672 116672 0 0.0
rodata 101212 101212 0 0.0
text 632764 632764 0 0.0
nrf52840dongle_nrf52840 (read/write) 994027 994027 0 0.0
bss 122472 122472 0 0.0
rodata 113516 113516 0 0.0
text 669568 669568 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853174 853174 0 0.0
bss 116416 116416 0 0.0
rodata 101936 101936 0 0.0
text 554292 554292 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912707 912707 0 0.0
bss 118784 118784 0 0.0
rodata 103728 103728 0 0.0
text 612816 612816 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822778 822778 0 0.0
bss 115600 115600 0 0.0
rodata 96956 96956 0 0.0
text 529776 529776 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915559 915559 0 0.0
bss 118548 118548 0 0.0
rodata 104092 104092 0 0.0
text 615468 615468 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910643 910643 0 0.0
bss 118572 118572 0 0.0
rodata 103200 103200 0 0.0
text 611392 611392 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2405536 2405536 0 0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363800 1363800 0 0.0
light-app default (read/write) 2329976 2329976 0 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288240 1288240 0 0.0
lock-app default (read/write) 2299000 2299000 0 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257264 1257264 0 0.0
qpg lighting-app qpg6105+debug (read only) 565064 565064 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559744 559744 0 0.0
lock-app qpg6105+debug (read only) 515476 515476 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510156 510156 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840698 840698 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587724 587724 0 0.0

@andy31415 andy31415 force-pushed the attribute_list_sizes branch from d60c0e6 to 0442520 Compare January 19, 2022 22:59
@andy31415 andy31415 dismissed bzbarsky-apple’s stale review January 20, 2022 13:20

I removed the separate list sizing, only the string one remains. Re-requesting review.

@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13699: Size comparison from 59a61a3 to 64d9419

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 59a61a3 64d9419 change % change
efr32 lighting-app BRD4161A (read only) 832684 832684 0 0.0
(read/write) 127032 127032 0 0.0
.bss 125136 125136 0 0.0
.data 1896 1896 0 0.0
.text 832676 832676 0 0.0
BRD4161A+rpc (read only) 820080 820080 0 0.0
(read/write) 143696 143696 0 0.0
.bss 141696 141696 0 0.0
.data 1996 1996 0 0.0
.text 820072 820072 0 0.0
window-app BRD4161A (read only) 803268 803268 0 0.0
(read/write) 125720 125720 0 0.0
.bss 123872 123872 0 0.0
.data 1848 1848 0 0.0
.text 803260 803260 0 0.0
esp32 all-clusters-app c3devkit (read only) 916398 916398 0 0.0
(read/write) 1317506 1317506 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178952 178952 0 0.0
.flash.text 916398 916398 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 964967 964967 0 0.0
(read/write) 449464 449464 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208120 208120 0 0.0
.flash.text 959583 959583 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656680 656680 0 0.0
.bss 76528 76528 0 0.0
.data 1864 1864 0 0.0
.text 572488 572488 0 0.0
lock k32w061+release (read/write) 659320 659320 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 574812 574812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8155948 8155948 0 0.0
(read/write) 376481 376481 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 249928 249928 0 0.0
.dynamic 560 560 0 0.0
.got 65632 65632 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 423044 423044 0 0.0
.text 6928788 6928788 0 0.0
thermostat-no-ble arm64 (read only) 2040652 2040652 0 0.0
(read/write) 145393 145393 0 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72728 72728 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 129948 129948 0 0.0
.text 1696544 1696544 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349632 2349632 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312208 1312208 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332328 2332328 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1294928 1294928 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302680 2302680 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265280 1265280 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940903 940903 0 0.0
bss 119020 119020 0 0.0
rodata 108492 108492 0 0.0
text 635796 635796 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926367 926367 0 0.0
bss 116064 116064 0 0.0
rodata 100940 100940 0 0.0
text 631192 631192 0 0.0
nrf52840dongle_nrf52840 (read/write) 991579 991579 0 0.0
bss 121864 121864 0 0.0
rodata 113244 113244 0 0.0
text 667996 667996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850730 850730 0 0.0
bss 115808 115808 0 0.0
rodata 101668 101668 0 0.0
text 552720 552720 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910247 910247 0 0.0
bss 118176 118176 0 0.0
rodata 103460 103460 0 0.0
text 611244 611244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820314 820314 0 0.0
bss 114992 114992 0 0.0
rodata 96684 96684 0 0.0
text 528200 528200 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913119 913119 0 0.0
bss 117940 117940 0 0.0
rodata 103820 103820 0 0.0
text 613892 613892 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908199 908199 0 0.0
bss 117964 117964 0 0.0
rodata 102932 102932 0 0.0
text 609820 609820 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2406552 2406552 0 0.0
.bss 117764 117764 0 0.0
.data 2576 2576 0 0.0
.text 1364816 1364816 0 0.0
light-app default (read/write) 2327768 2327768 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286032 1286032 0 0.0
lock-app default (read/write) 2296792 2296792 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255056 1255056 0 0.0
qpg lighting-app qpg6105+debug (read only) 563544 563544 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89616 89616 0 0.0
.data 1060 1060 0 0.0
.text 558224 558224 0 0.0
lock-app qpg6105+debug (read only) 513836 513836 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88240 88240 0 0.0
.data 984 984 0 0.0
.text 508516 508516 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839366 839366 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586466 586466 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13699: Size comparison from fd815cd to d4289f0

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fd815cd d4289f0 change % change
efr32 lighting-app BRD4161A (read only) 833628 833628 0 0.0
(read/write) 127032 127032 0 0.0
.bss 125136 125136 0 0.0
.data 1896 1896 0 0.0
.text 833620 833620 0 0.0
BRD4161A+rpc (read only) 821008 821008 0 0.0
(read/write) 143696 143696 0 0.0
.bss 141696 141696 0 0.0
.data 1996 1996 0 0.0
.text 821000 821000 0 0.0
window-app BRD4161A (read only) 804196 804196 0 0.0
(read/write) 125720 125720 0 0.0
.bss 123872 123872 0 0.0
.data 1848 1848 0 0.0
.text 804188 804188 0 0.0
esp32 all-clusters-app c3devkit (read only) 916854 916854 0 0.0
(read/write) 1317522 1317522 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178968 178968 0 0.0
.flash.text 916854 916854 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965463 965463 0 0.0
(read/write) 449480 449480 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208136 208136 0 0.0
.flash.text 960079 960079 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 658924 658924 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574676 574676 0 0.0
lock k32w061+release (read/write) 659704 659704 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575196 575196 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8390652 8390652 0 0.0
(read/write) 386417 386417 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 257432 257432 0 0.0
.dynamic 560 560 0 0.0
.got 68056 68056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 430228 430228 0 0.0
.text 7131620 7131620 0 0.0
thermostat-no-ble arm64 (read only) 2043324 2043324 0 0.0
(read/write) 145425 145425 0 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699136 1699136 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349968 2349968 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312544 1312544 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332728 2332728 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1295328 1295328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303080 2303080 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265680 1265680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941287 941287 0 0.0
bss 119020 119020 0 0.0
rodata 108508 108508 0 0.0
text 636164 636164 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926751 926751 0 0.0
bss 116064 116064 0 0.0
rodata 100956 100956 0 0.0
text 631560 631560 0 0.0
nrf52840dongle_nrf52840 (read/write) 991963 991963 0 0.0
bss 121864 121864 0 0.0
rodata 113260 113260 0 0.0
text 668364 668364 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851114 851114 0 0.0
bss 115808 115808 0 0.0
rodata 101684 101684 0 0.0
text 553088 553088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910631 910631 0 0.0
bss 118176 118176 0 0.0
rodata 103476 103476 0 0.0
text 611612 611612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820698 820698 0 0.0
bss 114992 114992 0 0.0
rodata 96700 96700 0 0.0
text 528568 528568 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913503 913503 0 0.0
bss 117940 117940 0 0.0
rodata 103836 103836 0 0.0
text 614260 614260 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908583 908583 0 0.0
bss 117964 117964 0 0.0
rodata 102948 102948 0 0.0
text 610188 610188 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2407464 2407464 0 0.0
.bss 117764 117764 0 0.0
.data 2576 2576 0 0.0
.text 1365728 1365728 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2297704 2297704 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255968 1255968 0 0.0
qpg lighting-app qpg6105+debug (read only) 565720 565720 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89672 89672 0 0.0
.data 1060 1060 0 0.0
.text 560400 560400 0 0.0
lock-app qpg6105+debug (read only) 514212 514212 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88240 88240 0 0.0
.data 984 984 0 0.0
.text 508892 508892 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839882 839882 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586962 586962 0 0.0

@andy31415 andy31415 merged commit 2f1301b into project-chip:master Jan 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13699: Size comparison from cf1b254 to 917e524

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cf1b254 917e524 change % change
efr32 lighting-app BRD4161A (read only) 833660 833660 0 0.0
(read/write) 127216 127216 0 0.0
.bss 125320 125320 0 0.0
.data 1896 1896 0 0.0
.text 833652 833652 0 0.0
BRD4161A+rpc (read only) 821056 821056 0 0.0
(read/write) 143880 143880 0 0.0
.bss 141880 141880 0 0.0
.data 1996 1996 0 0.0
.text 821048 821048 0 0.0
window-app BRD4161A (read only) 804212 804212 0 0.0
(read/write) 125792 125792 0 0.0
.bss 123944 123944 0 0.0
.data 1848 1848 0 0.0
.text 804204 804204 0 0.0
esp32 all-clusters-app c3devkit (read only) 917030 917030 0 0.0
(read/write) 1317522 1317522 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178968 178968 0 0.0
.flash.text 917030 917030 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965579 965579 0 0.0
(read/write) 449480 449480 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208136 208136 0 0.0
.flash.text 960195 960195 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 658940 658940 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574692 574692 0 0.0
lock k32w061+release (read/write) 659720 659720 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575212 575212 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8428364 8428364 0 0.0
(read/write) 388769 388769 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 259416 259416 0 0.0
.dynamic 560 560 0 0.0
.got 68424 68424 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 434308 434308 0 0.0
.text 7160308 7160308 0 0.0
thermostat-no-ble arm64 (read only) 2043340 2043340 0 0.0
(read/write) 145441 145441 0 0.0
.bss 64769 64769 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699152 1699152 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350160 2350160 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312736 1312736 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332728 2332728 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1295328 1295328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303080 2303080 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265680 1265680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941303 941303 0 0.0
bss 119020 119020 0 0.0
rodata 108508 108508 0 0.0
text 636188 636188 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926783 926783 0 0.0
bss 116064 116064 0 0.0
rodata 100956 100956 0 0.0
text 631580 631580 0 0.0
nrf52840dongle_nrf52840 (read/write) 991979 991979 0 0.0
bss 121864 121864 0 0.0
rodata 113260 113260 0 0.0
text 668384 668384 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851130 851130 0 0.0
bss 115808 115808 0 0.0
rodata 101684 101684 0 0.0
text 553108 553108 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910647 910647 0 0.0
bss 118176 118176 0 0.0
rodata 103476 103476 0 0.0
text 611624 611624 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820714 820714 0 0.0
bss 114992 114992 0 0.0
rodata 96700 96700 0 0.0
text 528584 528584 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913519 913519 0 0.0
bss 117940 117940 0 0.0
rodata 103836 103836 0 0.0
text 614276 614276 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908583 908583 0 0.0
bss 117964 117964 0 0.0
rodata 102948 102948 0 0.0
text 610200 610200 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533884 533884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711294 711294 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451564 451564 0 0.0
p6 all-clusters-app default (read/write) 2407768 2407768 0 0.0
.bss 117772 117772 0 0.0
.data 2584 2584 0 0.0
.text 1366032 1366032 0 0.0
light-app default (read/write) 2328728 2328728 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286992 1286992 0 0.0
lock-app default (read/write) 2297736 2297736 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1256000 1256000 0 0.0
qpg lighting-app qpg6105+debug (read only) 565856 565856 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89664 89664 0 0.0
.data 1060 1060 0 0.0
.text 560536 560536 0 0.0
lock-app qpg6105+debug (read only) 514344 514344 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88232 88232 0 0.0
.data 984 984 0 0.0
.text 509024 509024 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839906 839906 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586988 586988 0 0.0

@andy31415 andy31415 mentioned this pull request Jan 21, 2022
Merged
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@andy31415 @selissia
Expose array size limit in IDL where size limit seems intentional (pr…
9b2949d 
…oject-chip#13699)

* Expose array size limit in IDL where size limit seems intentional

* Only use sizes for strings and place it together with the data type

* Remove if_valid_list_size usage

* ZAP regen

* Fix removal of list sizes - had an extra maxLength remaining, now removed

* Add unless check in structure member for string size. Not that no output diff

* Add size info for attribute string types as well
@andy31415 andy31415 deleted the attribute_list_sizes branch June 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tcarmelveilleux @bzbarsky-apple @jmartinez-silabs