-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ameba] Update dockerfile for 'otar' name change #13695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
January 19, 2022 11:22
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 19, 2022 11:22
PR #13695: Size comparison from 150c479 to ec61358 Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
pankore
force-pushed
the
otar_name_change
branch
from
January 19, 2022 12:01
ec61358
to
85a3bba
Compare
PR #13695: Size comparison from 150c479 to 85a3bba Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
/rebase |
woody-apple
force-pushed
the
otar_name_change
branch
from
January 19, 2022 14:00
85a3bba
to
ac08beb
Compare
PR #13695: Size comparison from a04bf54 to ac08beb Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Jan 19, 2022
andy31415
approved these changes
Jan 19, 2022
/rebase |
woody-apple
force-pushed
the
otar_name_change
branch
from
January 20, 2022 14:32
ac08beb
to
d5a137d
Compare
PR #13695: Size comparison from 786fdfa to d5a137d Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Hi @andy31415 , @woody-apple , Could you please help to check this PR again? Thanks |
andy31415
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
Tested docker build