Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default initializers to cluster-objects structs. #13678

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Add default initializers to cluster-objects structs. #13678

merged 2 commits into from
Jan 19, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

These were missed when adding initializers to other things, because
the structs' members are defined in a separate file now.

Problem

Struct members left with random values.

Change overview

Initialize them.

Testing

Examined generated code and made sure we are now initializing struct members.

@boring-cyborg boring-cyborg bot added the app label Jan 19, 2022
@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13678: Size comparison from 4f84672 to 11c6647

Increases (9 builds for esp32, linux, mbed, p6, telink)
platform target config section 4f84672 11c6647 change % change
esp32 all-clusters-app c3devkit (read only) 912452 912554 102 0.0
.flash.text 912452 912554 102 0.0
m5stack (read only) 961295 961395 100 0.0
.flash.text 955911 956011 100 0.0
linux chip-tool-ipv6only arm64 (read only) 8090660 8091604 944 0.0
.text 6873764 6874708 944 0.0
thermostat-no-ble arm64 (read only) 2044156 2044348 192 0.0
.text 1699616 1699808 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2350176 2350240 64 0.0
.text 1312752 1312816 64 0.0
p6 all-clusters-app default (read/write) 2405304 2405592 288 0.0
.text 1363568 1363856 288 0.0
light-app default (read/write) 2330160 2330176 16 0.0
.text 1288424 1288440 16 0.0
lock-app default (read/write) 2299168 2299184 16 0.0
.text 1257432 1257448 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 840902 840934 32 0.0
text 587854 587892 38 0.0
Full report (13 builds for esp32, linux, mbed, p6, telink)
platform target config section 4f84672 11c6647 change % change
esp32 all-clusters-app c3devkit (read only) 912452 912554 102 0.0
(read/write) 1316698 1316698 0 0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14292 14292 0 0.0
.flash.rodata 178384 178384 0 0.0
.flash.text 912452 912554 102 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961295 961395 100 0.0
(read/write) 448856 448856 0 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207672 207672 0 0.0
.flash.text 955911 956011 100 0.0
.iram0.text 123399 123399 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8090660 8091604 944 0.0
(read/write) 373409 373409 0 0.0
.bss 55217 55217 0 0.0
.data 1112 1112 0 0.0
.data.rel.ro 248088 248088 0 0.0
.dynamic 560 560 0 0.0
.got 65296 65296 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 421100 421100 0 0.0
.text 6873764 6874708 944 0.0
thermostat-no-ble arm64 (read only) 2044156 2044348 192 0.0
(read/write) 145985 145985 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129932 129932 0 0.0
.text 1699616 1699808 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350176 2350240 64 0.0
.bss 189220 189220 0 0.0
.data 5328 5328 0 0.0
.text 1312752 1312816 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334632 2334632 0 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297232 1297232 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304984 2304984 0 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267584 1267584 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
p6 all-clusters-app default (read/write) 2405304 2405592 288 0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363568 1363856 288 0.0
light-app default (read/write) 2330160 2330176 16 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288424 1288440 16 0.0
lock-app default (read/write) 2299168 2299184 16 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257432 1257448 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 840902 840934 32 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587854 587892 38 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the default-init-cluster-structs branch from 11c6647 to b97a4cd Compare January 19, 2022 03:22
@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13678: Size comparison from 150c479 to b97a4cd

Increases (22 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 150c479 b97a4cd change % change
efr32 lighting-app BRD4161A (read only) 834948 835028 80 0.0
.text 834940 835020 80 0.0
BRD4161A+rpc (read only) 822352 822416 64 0.0
.text 822344 822408 64 0.0
window-app BRD4161A (read only) 805536 805600 64 0.0
.text 805528 805592 64 0.0
esp32 all-clusters-app c3devkit (read only) 912364 912466 102 0.0
.flash.text 912364 912466 102 0.0
m5stack (read only) 961231 961319 88 0.0
.flash.text 955847 955935 88 0.0
k32w lock k32w061+release (read/write) 661888 661936 48 0.0
.text 576776 576824 48 0.0
linux chip-tool-ipv6only arm64 (read only) 8123052 8123996 944 0.0
.text 6903140 6904084 944 0.0
thermostat-no-ble arm64 (read only) 2044156 2044348 192 0.0
.text 1699616 1699808 192 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943491 943539 48 0.0
text 637456 637496 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 928975 929007 32 0.0
text 632852 632888 36 0.0
nrf52840dongle_nrf52840 (read/write) 994171 994219 48 0.0
text 669656 669692 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853334 853366 32 0.0
text 554380 554416 36 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912851 912899 48 0.0
text 612904 612944 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822922 822954 32 0.0
text 529864 529900 36 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915719 915751 32 0.0
text 615556 615592 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910787 910835 48 0.0
text 611480 611520 40 0.0
p6 all-clusters-app default (read/write) 2405304 2405592 288 0.0
.text 1363568 1363856 288 0.0
light-app default (read/write) 2330160 2330176 16 0.0
.text 1288424 1288440 16 0.0
lock-app default (read/write) 2299168 2299184 16 0.0
.text 1257432 1257448 16 0.0
qpg lighting-app qpg6105+debug (read only) 565160 565192 32 0.0
.text 559840 559872 32 0.0
lock-app qpg6105+debug (read only) 515572 515604 32 0.0
.text 510252 510284 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 840902 840942 40 0.0
text 587854 587898 44 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 150c479 b97a4cd change % change
efr32 lighting-app BRD4161A (read only) 834948 835028 80 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834940 835020 80 0.0
BRD4161A+rpc (read only) 822352 822416 64 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822344 822408 64 0.0
window-app BRD4161A (read only) 805536 805600 64 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805528 805592 64 0.0
esp32 all-clusters-app c3devkit (read only) 912364 912466 102 0.0
(read/write) 1316698 1316698 0 0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14292 14292 0 0.0
.flash.rodata 178384 178384 0 0.0
.flash.text 912364 912466 102 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961231 961319 88 0.0
(read/write) 448856 448856 0 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 207672 207672 0 0.0
.flash.text 955847 955935 88 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659156 659156 0 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574360 574360 0 0.0
lock k32w061+release (read/write) 661888 661936 48 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576776 576824 48 0.0
linux chip-tool-ipv6only arm64 (read only) 8123052 8123996 944 0.0
(read/write) 374225 374225 0 0.0
.bss 55217 55217 0 0.0
.data 1112 1112 0 0.0
.data.rel.ro 248696 248696 0 0.0
.dynamic 560 560 0 0.0
.got 65504 65504 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 422244 422244 0 0.0
.text 6903140 6904084 944 0.0
thermostat-no-ble arm64 (read only) 2044156 2044348 192 0.0
(read/write) 145985 145985 0 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129932 129932 0 0.0
.text 1699616 1699808 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350176 2350176 0 0.0
.bss 189220 189220 0 0.0
.data 5328 5328 0 0.0
.text 1312752 1312752 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334632 2334632 0 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297232 1297232 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304984 2304984 0 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267584 1267584 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943491 943539 48 0.0
bss 119628 119628 0 0.0
rodata 108824 108824 0 0.0
text 637456 637496 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 928975 929007 32 0.0
bss 116672 116672 0 0.0
rodata 101276 101276 0 0.0
text 632852 632888 36 0.0
nrf52840dongle_nrf52840 (read/write) 994171 994219 48 0.0
bss 122472 122472 0 0.0
rodata 113580 113580 0 0.0
text 669656 669692 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853334 853366 32 0.0
bss 116416 116416 0 0.0
rodata 102000 102000 0 0.0
text 554380 554416 36 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912851 912899 48 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612904 612944 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822922 822954 32 0.0
bss 115600 115600 0 0.0
rodata 97020 97020 0 0.0
text 529864 529900 36 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915719 915751 32 0.0
bss 118548 118548 0 0.0
rodata 104156 104156 0 0.0
text 615556 615592 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910787 910835 48 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611480 611520 40 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451668 451668 0 0.0
p6 all-clusters-app default (read/write) 2405304 2405592 288 0.0
.bss 117556 117556 0 0.0
.data 2608 2608 0 0.0
.text 1363568 1363856 288 0.0
light-app default (read/write) 2330160 2330176 16 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288424 1288440 16 0.0
lock-app default (read/write) 2299168 2299184 16 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257432 1257448 16 0.0
qpg lighting-app qpg6105+debug (read only) 565160 565192 32 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559840 559872 32 0.0
lock-app qpg6105+debug (read only) 515572 515604 32 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510252 510284 32 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840902 840942 40 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587854 587898 44 0.0

mrjerryjohns
mrjerryjohns reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@mrjerryjohns mrjerryjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Can you fix test-cluster-server.cpp initialization of some of the globals to now not have to explicitly initialize the fields in some of those structs?

@bzbarsky-apple
Add default initializers to cluster-objects structs.
07bc9e0 
These were missed when adding initializers to other things, because
the structs' members are defined in a separate file now.
@bzbarsky-apple
Address review comments
0880fda
@bzbarsky-apple bzbarsky-apple force-pushed the default-init-cluster-structs branch from b97a4cd to 0880fda Compare January 19, 2022 16:28
andy31415
andy31415 requested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: non-typesafe cast of 0 into various enums seems error prone/hard to read. Please use actual enum values.

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13678: Size comparison from 41d3a6c to 0880fda

Increases (21 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 41d3a6c 0880fda change % change
efr32 lighting-app BRD4161A (read only) 834948 835028 80 0.0
.text 834940 835020 80 0.0
BRD4161A+rpc (read only) 822352 822416 64 0.0
.text 822344 822408 64 0.0
window-app BRD4161A (read only) 805536 805600 64 0.0
.text 805528 805592 64 0.0
esp32 all-clusters-app c3devkit (read only) 912352 912470 118 0.0
.dram0.bss 70528 70568 40 0.1
.flash.text 912352 912470 118 0.0
m5stack (read only) 961231 961327 96 0.0
.dram0.bss 74984 75024 40 0.1
.flash.text 955847 955943 96 0.0
k32w lock k32w061+release (read/write) 661888 661920 32 0.0
.text 576776 576808 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2350112 2350176 64 0.0
.bss 189220 189260 40 0.0
.text 1312688 1312752 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2334568 2334632 64 0.0
.text 1297168 1297232 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943491 943523 32 0.0
text 637448 637488 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 928975 929007 32 0.0
text 632844 632880 36 0.0
nrf52840dongle_nrf52840 (read/write) 994171 994203 32 0.0
text 669648 669684 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853318 853350 32 0.0
text 554372 554408 36 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912851 912883 32 0.0
text 612896 612936 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822922 822954 32 0.0
text 529856 529892 36 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915703 915735 32 0.0
text 615548 615584 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910787 910819 32 0.0
text 611472 611512 40 0.0
p6 all-clusters-app default (read/write) 2405304 2405640 336 0.0
.bss 117556 117596 40 0.0
.text 1363568 1363904 336 0.0
light-app default (read/write) 2330160 2330176 16 0.0
.text 1288424 1288440 16 0.0
qpg lighting-app qpg6105+debug (read only) 565152 565184 32 0.0
.text 559832 559864 32 0.0
lock-app qpg6105+debug (read only) 515564 515596 32 0.0
.text 510244 510276 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 840886 840934 48 0.0
text 587842 587886 44 0.0
Decreases (4 builds for esp32, mbed, p6)
platform target config section 41d3a6c 0880fda change % change
esp32 all-clusters-app c3devkit .dram0.data 14292 14252 -40 -0.3
m5stack (read/write) 448856 448848 -8 -0.0
.dram0.data 34072 34024 -48 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5328 5288 -40 -0.8
p6 all-clusters-app default .data 2608 2568 -40 -1.5
Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 41d3a6c 0880fda change % change
efr32 lighting-app BRD4161A (read only) 834948 835028 80 0.0
(read/write) 127636 127636 0 0.0
.bss 125744 125744 0 0.0
.data 1892 1892 0 0.0
.text 834940 835020 80 0.0
BRD4161A+rpc (read only) 822352 822416 64 0.0
(read/write) 144296 144296 0 0.0
.bss 142304 142304 0 0.0
.data 1992 1992 0 0.0
.text 822344 822408 64 0.0
window-app BRD4161A (read only) 805536 805600 64 0.0
(read/write) 126328 126328 0 0.0
.bss 124480 124480 0 0.0
.data 1844 1844 0 0.0
.text 805528 805592 64 0.0
esp32 all-clusters-app c3devkit (read only) 912352 912470 118 0.0
(read/write) 1316698 1316698 0 0.0
.dram0.bss 70528 70568 40 0.1
.dram0.data 14292 14252 -40 -0.3
.flash.rodata 178384 178384 0 0.0
.flash.text 912352 912470 118 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961231 961327 96 0.0
(read/write) 448856 448848 -8 -0.0
.dram0.bss 74984 75024 40 0.1
.dram0.data 34072 34024 -48 -0.1
.flash.rodata 207672 207672 0 0.0
.flash.text 955847 955943 96 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659156 659156 0 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574360 574360 0 0.0
lock k32w061+release (read/write) 661888 661920 32 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576776 576808 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350112 2350176 64 0.0
.bss 189220 189260 40 0.0
.data 5328 5288 -40 -0.8
.text 1312688 1312752 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334568 2334632 64 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297168 1297232 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304984 2304984 0 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267584 1267584 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943491 943523 32 0.0
bss 119628 119628 0 0.0
rodata 108824 108824 0 0.0
text 637448 637488 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 928975 929007 32 0.0
bss 116672 116672 0 0.0
rodata 101276 101276 0 0.0
text 632844 632880 36 0.0
nrf52840dongle_nrf52840 (read/write) 994171 994203 32 0.0
bss 122472 122472 0 0.0
rodata 113580 113580 0 0.0
text 669648 669684 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853318 853350 32 0.0
bss 116416 116416 0 0.0
rodata 102000 102000 0 0.0
text 554372 554408 36 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912851 912883 32 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612896 612936 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822922 822954 32 0.0
bss 115600 115600 0 0.0
rodata 97020 97020 0 0.0
text 529856 529892 36 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915703 915735 32 0.0
bss 118548 118548 0 0.0
rodata 104156 104156 0 0.0
text 615548 615584 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910787 910819 32 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611472 611512 40 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533984 533984 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711454 711454 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451660 451660 0 0.0
p6 all-clusters-app default (read/write) 2405304 2405640 336 0.0
.bss 117556 117596 40 0.0
.data 2608 2568 -40 -1.5
.text 1363568 1363904 336 0.0
light-app default (read/write) 2330160 2330176 16 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288424 1288440 16 0.0
lock-app default (read/write) 2299184 2299184 0 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257448 1257448 0 0.0
qpg lighting-app qpg6105+debug (read only) 565152 565184 32 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559832 559864 32 0.0
lock-app qpg6105+debug (read only) 515564 515596 32 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510244 510276 32 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840886 840934 48 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587842 587886 44 0.0

@andy31415
Copy link
Contributor

fast track: change and checkmark by domain owner. Delta is obviously a net improvement over what we had before (even if considering more could be done, it is already a net positive).

@bzbarsky-apple bzbarsky-apple merged commit 7f766c6 into project-chip:master Jan 19, 2022
@bzbarsky-apple bzbarsky-apple deleted the default-init-cluster-structs branch January 19, 2022 22:42
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Add default initializers to cluster-objects structs. (project-chip#13678
dc18fba 
)

* Add default initializers to cluster-objects structs.

These were missed when adding initializers to other things, because
the structs' members are defined in a separate file now.

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app fast track openthread platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @mrjerryjohns @Damian-Nordic