-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pairing via the SetupCodePairer #13677
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple and
robszewczyk
January 18, 2022 23:37
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
January 18, 2022 23:37
PR #13677: Size comparison from 78a6636 to d3a1dea Decreases (1 build for linux)
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 19, 2022
I need to make some changes to this PR to get it to pass CI. |
Damian-Nordic
approved these changes
Jan 19, 2022
sagar-apple
commented
Jan 19, 2022
bzbarsky-apple
approved these changes
Jan 19, 2022
src/darwin/CHIPTool/CHIPTool/View Controllers/QRCode/QRCodeViewController.m
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
msandstedt
approved these changes
Jan 19, 2022
pan-apple
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
* Fix pairing via the SetupCodePairer * Fix iOS CHIPTool and make sure only PASE is setup for BLE discovery * Fix compile * Restyled by clang-format * Update src/controller/SetUpCodePairer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Fix Darwin test * Fix the zapt file Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SetupCodePairer doesn't need to use the BLE auto commissioning mechanism.
Instead its purpose is to establish PASE by parsing the onboarding payload and figuring out whether the commissionee is on BLE or IP.
Change overview
Only establish a PASE session inside the SetupCodePairer when the node was discovered over BLE and perform a full commissioning when it's on-network.
Also fixed iOS CHIPTool and exposed the Commission API to ObjC.
Testing
How was this tested? (at least one bullet point required)
Verified that chip-tool qrcode/manualcode pairing is no longer broken.