Set valid device types for application endpoints #13634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
mspang
force-pushed
the
for-chip/too-many-roots
branch
from
3357b35 to
abdd0c7
Compare
andy31415
reviewed
Jan 17, 2022
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Jan 17, 2022
|
@mspang - please update the generated files - I think you picked up the 'unstable run' version of zap output :( |
|
PR #13634: Size comparison from 8952d1c to abdd0c7 Decreases (3 builds for p6, qpg, telink)
Full report (11 builds for k32w, linux, p6, qpg, telink)
|
mspang
force-pushed
the
for-chip/too-many-roots
branch
from
abdd0c7 to
a18b711
Compare
|
Re: all-clusters, the menu system seems to indicate that there should be more endpoints than there actually are. There is definitely more cleanup needed for this application. |
|
PR #13634: Size comparison from 8952d1c to a18b711 Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 18, 2022
bzbarsky-apple
approved these changes
Jan 18, 2022
Several samples are using the root node device type for application endpoints. This prevents proper identification of the device. Add types to all non-root endpoints in examples/. all-clusters-app does not correspond well with any single device type. This sets it to on/off light. It may be useful to reorganize this sample into additional endpoints each with a coherent device type. Multiple root nodes is not compliant. From the spec, "Endpoint Composition" section: There SHALL be only one root node endpoint for the node.
mspang
force-pushed
the
for-chip/too-many-roots
branch
from
a1ef5d6 to
48a7eab
Compare
|
PR #13634: Size comparison from 78a6636 to 48a7eab Increases (1 build for esp32)
Decreases (1 build for esp32)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #13634: Size comparison from d5e7431 to a9388a1 Increases (1 build for esp32)
Decreases (1 build for esp32)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
Several samples are using the root node device type for application endpoints. This prevents proper identification of the device. Add types to all non-root endpoints in examples/. all-clusters-app does not correspond well with any single device type. This sets it to on/off light. It may be useful to reorganize this sample into additional endpoints each with a coherent device type. Multiple root nodes is not compliant. From the spec, "Endpoint Composition" section: There SHALL be only one root node endpoint for the node.
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Feb 9, 2022
Several samples are using the root node device type for application endpoints. This prevents proper identification of the device. Add types to all non-root endpoints in examples/. all-clusters-app does not correspond well with any single device type. This sets it to on/off light. It may be useful to reorganize this sample into additional endpoints each with a coherent device type. Multiple root nodes is not compliant. From the spec, "Endpoint Composition" section: There SHALL be only one root node endpoint for the node. (cherry picked from commit a3409d6)
mspang
added a commit
that referenced
this pull request
Feb 9, 2022
Several samples are using the root node device type for application endpoints. This prevents proper identification of the device. Add types to all non-root endpoints in examples/. all-clusters-app does not correspond well with any single device type. This sets it to on/off light. It may be useful to reorganize this sample into additional endpoints each with a coherent device type. Multiple root nodes is not compliant. From the spec, "Endpoint Composition" section: There SHALL be only one root node endpoint for the node. (cherry picked from commit a3409d6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Several samples are using the root node device type for application
endpoints. This prevents proper identification of the device and is
not compliant with the specification:
From the spec, "Endpoint Composition" section: There SHALL be only
one root node endpoint for the node.
Change overview
Add types to all non-root endpoints in examples/.
all-clusters-app does not correspond well with any single device type.
This sets it to on/off light. It may be useful to reorganize this
sample into additional endpoints each with a coherent device type.
Testing
Built & commissioned each app, read descriptor cluster.