-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move IDL copy logic into generate.py so we can individually update files #13626
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:idl/zap_in_generate_py
Jan 17, 2022
Merged
Move IDL copy logic into generate.py so we can individually update files #13626
andy31415
merged 2 commits into
project-chip:master
from
andy31415:idl/zap_in_generate_py
Jan 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast track: NOOP change generally, does not affect SDK functionality (treating it as testing code) |
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel and
LuDuda
January 17, 2022 14:58
pullapprove
bot
requested review from
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
January 17, 2022 14:58
Damian-Nordic
approved these changes
Jan 17, 2022
PR #13626: Size comparison from e4faade to 11c46de Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…les (project-chip#13626) * Move IDL copy logic into generate.py so we can individually update files * Restyle fixes
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…les (project-chip#13626) * Move IDL copy logic into generate.py so we can individually update files * Restyle fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IDL files for matter are only copied/moved when regenerate-all is run, which is slow.
Change overview
Move the logic into generate.py
Testing
Manually ran the generate (with changed zapt) and observed differences.
CI will validate that this is a "no changes" operation.