[ESP32] CLI option to set delayed action time in OTA Provider app and restart OTA Requestor once ApplyUpdate is successful #13620

shubhamdp · 2022-01-16T15:35:50Z

Problem

No option to set delayed action time in ESP32 OTA Provider application
We had to manually restart the ESP32 device once the ApplyUpdate is successful

Change overview

Added an cli option to set delayed action time in ESP32 OTA Provider application
Modified the Linux OTA Provider help for delayed action time cli option
Schedule the restart for ESP32 once apply update is successful
Also, Apply suggestion from Update OTA Requestor Server cluster attributes #13484 in lighting-app
Minor changes in readme files

Testing

Linux OTA provider and ESP32 OTA requestor app
ESP32 OTA provider and tried OTA in ESP32 lighting app

github-actions · 2022-01-17T17:03:04Z

PR #13620: Size comparison from 8bdff01 to 165b8c5

Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`8bdff01`	`165b8c5`
efr32	lighting-app	BRD4161A	(read only)	834852	834852
			(read/write)	127628	127628
			.bss	125744	125744
			.data	1884	1884
			.text	834844	834844
		BRD4161A+rpc	(read only)	822232	822232
			(read/write)	144288	144288
			.bss	142304	142304
			.data	1984	1984
			.text	822224	822224
	window-app	BRD4161A	(read only)	805424	805424
			(read/write)	126320	126320
			.bss	124480	124480
			.data	1836	1836
			.text	805416	805416
k32w	light	k32w061+release	(read/write)	659064	659064
			.bss	77136	77136
			.data	1852	1852
			.text	574276	574276
	lock	k32w061+release	(read/write)	661796	661796
			.bss	77432	77432
			.data	1872	1872
			.text	576692	576692
linux	chip-tool-ipv6only	arm64	(read only)	8042100	8042100
			(read/write)	370641	370641
			.bss	55217	55217
			.data	1096	1096
			.data.rel.ro	245856	245856
			.dynamic	560	560
			.got	64776	64776
			.init	24	24
			.init_array	168	168
			.rodata	419420	419420
			.text	6833684	6833684
	thermostat-no-ble	arm64	(read only)	2042108	2042108
			(read/write)	145969	145969
			.bss	65089	65089
			.data	880	880
			.data.rel.ro	73016	73016
			.dynamic	560	560
			.got	4048	4048
			.init	24	24
			.init_array	304	304
			.rodata	129884	129884
			.text	1697632	1697632
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2349856	2349856
			.bss	189220	189220
			.data	5320	5320
			.text	1312432	1312432
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2334504	2334504
			.bss	180760	180760
			.data	5568	5568
			.text	`1297104`	`1297104`
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2304848`	`2304848`
			.bss	179768	179768
			.data	5544	5544
			.text	1267448	1267448
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139712	1139712
			.bss	11756	11756
			.data	4368	4368
			.text	103096	103096
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2054464	2054464
			.bss	156876	156876
			.data	4864	4864
			.text	1017064	1017064
p6	all-clusters-app	default	(read/write)	2404744	2404744
			.bss	117556	117556
			.data	2600	2600
			.text	`1363008`	`1363008`
	light-app	default	(read/write)	2330048	2330048
			.bss	106128	106128
			.data	2392	2392
			.text	1288312	1288312
	lock-app	default	(read/write)	2299072	2299072
			.bss	104976	104976
			.data	2344	2344
			.text	1257336	1257336
qpg	lighting-app	qpg6105+debug	(read only)	565072	565072
			(read/write)	146940	146940
			.bss	89960	89960
			.data	1048	1048
			.text	559752	559752
	lock-app	qpg6105+debug	(read only)	515484	515484
			(read/write)	146936	146936
			.bss	88584	88584
			.data	972	972
			.text	510164	510164
	persistent-storage-app	qpg6105+debug	(read only)	106848	106848
			(read/write)	146940	146940
			.bss	38512	38512
			.data	288	288
			.text	101528	101528
telink	lighting-app	tlsr9518adk80d	(read/write)	840778	840778
			bss	87316	87316
			noinit	37160	37160
			text	587748	587748

github-actions · 2022-01-18T03:50:37Z

PR #13620: Size comparison from 628d7ba to 1e695c4

Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`628d7ba`	`1e695c4`
efr32	lighting-app	BRD4161A	(read only)	834868	834868
			(read/write)	127628	127628
			.bss	125744	125744
			.data	1884	1884
			.text	834860	834860
		BRD4161A+rpc	(read only)	822264	822264
			(read/write)	144288	144288
			.bss	142304	142304
			.data	1984	1984
			.text	822256	822256
	window-app	BRD4161A	(read only)	805456	805456
			(read/write)	126320	126320
			.bss	124480	124480
			.data	1836	1836
			.text	805448	805448
k32w	light	k32w061+release	(read/write)	659080	659080
			.bss	77136	77136
			.data	1852	1852
			.text	574292	574292
	lock	k32w061+release	(read/write)	661812	661812
			.bss	77432	77432
			.data	1872	1872
			.text	576708	576708
linux	chip-tool-ipv6only	arm64	(read only)	8049492	8049492
			(read/write)	370641	370641
			.bss	55217	55217
			.data	1096	1096
			.data.rel.ro	245856	245856
			.dynamic	560	560
			.got	64776	64776
			.init	24	24
			.init_array	168	168
			.rodata	419420	419420
			.text	`6841076`	`6841076`
	thermostat-no-ble	arm64	(read only)	2042812	2042812
			(read/write)	145969	145969
			.bss	65089	65089
			.data	880	880
			.data.rel.ro	73016	73016
			.dynamic	560	560
			.got	4048	4048
			.init	24	24
			.init_array	304	304
			.rodata	129884	129884
			.text	1698336	1698336
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2350112	2350112
			.bss	189220	189220
			.data	5320	5320
			.text	1312688	1312688
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2334568	2334568
			.bss	180760	180760
			.data	5568	5568
			.text	1297168	1297168
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2304912	2304912
			.bss	179768	179768
			.data	5544	5544
			.text	1267512	1267512
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139712	1139712
			.bss	11756	11756
			.data	4368	4368
			.text	103096	103096
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2054464	2054464
			.bss	156876	156876
			.data	4864	4864
			.text	1017064	1017064
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	943419	943419
			bss	119628	119628
			rodata	108824	108824
			text	637388	637388
		nrf52840dk_nrf52840+rpc	(read/write)	928899	928899
			bss	116672	116672
			rodata	101272	101272
			text	632784	632784
		nrf52840dongle_nrf52840	(read/write)	994095	994095
			bss	122472	122472
			rodata	113576	113576
			text	669588	669588
		nrf5340dk_nrf5340_cpuapp	(read/write)	853242	853242
			bss	116416	116416
			rodata	101996	101996
			text	554312	554312
	lock-app	nrf52840dk_nrf52840	(read/write)	912779	912779
			bss	118784	118784
			rodata	103792	103792
			text	612836	612836
		nrf5340dk_nrf5340_cpuapp	(read/write)	822846	822846
			bss	115600	115600
			rodata	97016	97016
			text	529796	529796
	pigweed-app	nrf52840dk_nrf52840	(read/write)	541835	541835
			bss	52588	52588
			rodata	50104	50104
			text	376940	376940
	pump-app	nrf52840dk_nrf52840	(read/write)	915643	915643
			bss	118548	118548
			rodata	104152	104152
			text	615492	615492
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	910715	910715
			bss	118572	118572
			rodata	103264	103264
			text	611416	611416
	shell	nrf52840dk_nrf52840	(read/write)	798655	798655
			bss	109776	109776
			rodata	78388	78388
			text	533992	533992
		nrf5340dk_nrf5340_cpuapp	(read/write)	711470	711470
			bss	107664	107664
			rodata	72688	72688
			text	451668	451668
p6	all-clusters-app	default	(read/write)	2405224	2405224
			.bss	117556	117556
			.data	2600	2600
			.text	1363488	1363488
	light-app	default	(read/write)	2330080	2330080
			.bss	106128	106128
			.data	2392	2392
			.text	1288344	1288344
	lock-app	default	(read/write)	2299104	2299104
			.bss	104976	104976
			.data	2344	2344
			.text	1257368	1257368
qpg	lighting-app	qpg6105+debug	(read only)	565088	565088
			(read/write)	146940	146940
			.bss	89960	89960
			.data	1048	1048
			.text	559768	559768
	lock-app	qpg6105+debug	(read only)	515500	515500
			(read/write)	146936	146936
			.bss	88584	88584
			.data	972	972
			.text	510180	510180
	persistent-storage-app	qpg6105+debug	(read only)	106848	106848
			(read/write)	146940	146940
			.bss	38512	38512
			.data	288	288
			.text	101528	101528
telink	lighting-app	tlsr9518adk80d	(read/write)	840826	840826
			bss	87316	87316
			noinit	37160	37160
			text	587790	587790

shubhamdp · 2022-01-18T15:33:06Z

/rebase

github-actions · 2022-01-18T15:52:06Z

PR #13620: Size comparison from be806bb to 3168263

Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`be806bb`	`3168263`
efr32	lighting-app	BRD4161A	(read only)	834948	834948
			(read/write)	127636	127636
			.bss	125744	125744
			.data	1892	1892
			.text	834940	834940
		BRD4161A+rpc	(read only)	822352	822352
			(read/write)	144296	144296
			.bss	142304	142304
			.data	1992	1992
			.text	822344	822344
	window-app	BRD4161A	(read only)	805536	805536
			(read/write)	126328	126328
			.bss	124480	124480
			.data	1844	1844
			.text	805528	805528
k32w	light	k32w061+release	(read/write)	659156	659156
			.bss	77136	77136
			.data	1860	1860
			.text	574360	574360
	lock	k32w061+release	(read/write)	661888	661888
			.bss	77432	77432
			.data	1880	1880
			.text	576776	576776
linux	chip-tool-ipv6only	arm64	(read only)	8090660	8090660
			(read/write)	373409	373409
			.bss	55217	55217
			.data	1112	1112
			.data.rel.ro	248088	248088
			.dynamic	560	560
			.got	65296	65296
			.init	24	24
			.init_array	168	168
			.rodata	421100	421100
			.text	`6873764`	`6873764`
	thermostat-no-ble	arm64	(read only)	2044156	2044156
			(read/write)	145985	145985
			.bss	65089	65089
			.data	896	896
			.data.rel.ro	73016	73016
			.dynamic	560	560
			.got	4048	4048
			.init	24	24
			.init_array	304	304
			.rodata	129932	129932
			.text	1699616	1699616
p6	all-clusters-app	default	(read/write)	2405304	2405304
			.bss	117556	117556
			.data	2608	2608
			.text	1363568	1363568
	light-app	default	(read/write)	2330160	2330160
			.bss	106128	106128
			.data	2400	2400
			.text	1288424	1288424
	lock-app	default	(read/write)	2299168	2299168
			.bss	104976	104976
			.data	2352	2352
			.text	1257432	1257432
qpg	lighting-app	qpg6105+debug	(read only)	565160	565160
			(read/write)	146940	146940
			.bss	89960	89960
			.data	1056	1056
			.text	559840	559840
	lock-app	qpg6105+debug	(read only)	515572	515572
			(read/write)	146936	146936
			.bss	88584	88584
			.data	980	980
			.text	510252	510252
	persistent-storage-app	qpg6105+debug	(read only)	106848	106848
			(read/write)	146940	146940
			.bss	38512	38512
			.data	288	288
			.text	101528	101528
telink	lighting-app	tlsr9518adk80d	(read/write)	840902	840902
			bss	87316	87316
			noinit	37160	37160
			text	587854	587854

examples/lighting-app/esp32/README.md

examples/ota-requestor-app/esp32/README.md

src/platform/ESP32/OTAImageProcessorImpl.cpp

github-actions · 2022-01-19T04:53:24Z

PR #13620: Size comparison from be806bb to b0c6eae

Full report (11 builds for nrfconnect)

platform	target	config	section	`be806bb`	`b0c6eae`
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	943491	943491
			bss	119628	119628
			rodata	108824	108824
			text	637456	637456
	lock-app	nrf52840dk_nrf52840	(read/write)	912851	912851
			bss	118784	118784
			rodata	103792	103792
			text	612904	612904
	pigweed-app	nrf52840dk_nrf52840	(read/write)	541835	541835
			bss	52588	52588
			rodata	50104	50104
			text	376940	376940
	pump-app	nrf52840dk_nrf52840	(read/write)	915719	915719
			bss	118548	118548
			rodata	104156	104156
			text	615556	615556
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	910787	910787
			bss	118572	118572
			rodata	103264	103264
			text	611480	611480
	shell	nrf52840dk_nrf52840	(read/write)	798655	798655
			bss	109776	109776
			rodata	78388	78388
			text	533992	533992
	lighting-app	nrf52840dk_nrf52840+rpc	(read/write)	928975	928975
			bss	116672	116672
			rodata	101276	101276
			text	632852	632852
		nrf52840dongle_nrf52840	(read/write)	994171	994171
			bss	122472	122472
			rodata	113580	113580
			text	669656	669656
		nrf5340dk_nrf5340_cpuapp	(read/write)	853334	853334
			bss	116416	116416
			rodata	102000	102000
			text	554380	554380
	lock-app	nrf5340dk_nrf5340_cpuapp	(read/write)	822922	822922
			bss	115600	115600
			rodata	97020	97020
			text	529864	529864
	shell	nrf5340dk_nrf5340_cpuapp	(read/write)	711470	711470
			bss	107664	107664
			rodata	72688	72688
			text	451668	451668

shubhamdp · 2022-01-20T11:32:54Z

/rebase

github-actions · 2022-01-20T11:52:50Z

PR #13620: Size comparison from 914ba3e to adfbf36

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	914ba3e4	`adfbf36`
efr32	lighting-app	BRD4161A	(read only)	832684	832684
			(read/write)	127112	127112
			.bss	125216	125216
			.data	1896	1896
			.text	832676	832676
		BRD4161A+rpc	(read only)	820080	820080
			(read/write)	143776	143776
			.bss	141776	141776
			.data	1996	1996
			.text	820072	820072
	window-app	BRD4161A	(read only)	803268	803268
			(read/write)	125800	125800
			.bss	123952	123952
			.data	1848	1848
			.text	803260	803260
esp32	all-clusters-app	c3devkit	(read only)	910524	910524
			(read/write)	1315850	1315850
			.dram0.bss	70024	70024
			.dram0.data	14236	14236
			.flash.rodata	178096	178096
			.flash.text	910524	910524
			.iram0.text	62056	62056
		m5stack	(read only)	959535	959535
			(read/write)	448008	448008
			.dram0.bss	74480	74480
			.dram0.data	34032	34032
			.flash.rodata	207368	207368
			.flash.text	954151	954151
			.iram0.text	123399	123399
k32w	light	k32w061+release	(read/write)	656696	656696
			.bss	76608	76608
			.data	1864	1864
			.text	572424	572424
	lock	k32w061+release	(read/write)	659400	659400
			.bss	76904	76904
			.data	1884	1884
			.text	574812	574812
linux	chip-tool-ipv6only	arm64	(read only)	`8155868`	`8155868`
			(read/write)	376481	376481
			.bss	56049	56049
			.data	1128	1128
			.data.rel.ro	249928	249928
			.dynamic	560	560
			.got	65632	65632
			.init	24	24
			.init_array	200	200
			.rodata	423044	423044
			.text	`6928708`	`6928708`
	thermostat-no-ble	arm64	(read only)	2033476	2033476
			(read/write)	144417	144417
			.bss	63841	63841
			.data	904	904
			.data.rel.ro	72704	72704
			.dynamic	560	560
			.got	4032	4032
			.init	24	24
			.init_array	304	304
			.rodata	129508	129508
			.text	`1689952`	`1689952`
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2347504	2347504
			.bss	188732	188732
			.data	5296	5296
			.text	1310080	1310080
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2331768	2331768
			.bss	180232	180232
			.data	5576	5576
			.text	1294368	1294368
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2302120	2302120
			.bss	179240	179240
			.data	5552	5552
			.text	1264720	1264720
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139712	1139712
			.bss	11756	11756
			.data	4368	4368
			.text	103096	103096
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2054256	2054256
			.bss	156876	156876
			.data	4864	4864
			.text	`1016856`	`1016856`
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	940967	940967
			bss	119100	119100
			rodata	108492	108492
			text	635796	635796
		nrf52840dk_nrf52840+rpc	(read/write)	926463	926463
			bss	116144	116144
			rodata	100940	100940
			text	631192	631192
		nrf52840dongle_nrf52840	(read/write)	991643	991643
			bss	121944	121944
			rodata	113244	113244
			text	667996	667996
		nrf5340dk_nrf5340_cpuapp	(read/write)	850826	850826
			bss	115888	115888
			rodata	101668	101668
			text	552720	552720
	lock-app	nrf52840dk_nrf52840	(read/write)	910343	910343
			bss	118256	118256
			rodata	103460	103460
			text	611244	611244
		nrf5340dk_nrf5340_cpuapp	(read/write)	820378	820378
			bss	115072	115072
			rodata	96684	96684
			text	528200	528200
	pigweed-app	nrf52840dk_nrf52840	(read/write)	541835	541835
			bss	52588	52588
			rodata	50104	50104
			text	376940	376940
	pump-app	nrf52840dk_nrf52840	(read/write)	913215	913215
			bss	118020	118020
			rodata	103820	103820
			text	613892	613892
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	908263	908263
			bss	118044	118044
			rodata	102932	102932
			text	609820	609820
	shell	nrf52840dk_nrf52840	(read/write)	798479	798479
			bss	109776	109776
			rodata	78324	78324
			text	533872	533872
		nrf5340dk_nrf5340_cpuapp	(read/write)	711278	711278
			bss	107664	107664
			rodata	72624	72624
			text	451548	451548
p6	all-clusters-app	default	(read/write)	`2403648`	`2403648`
			.bss	117068	117068
			.data	2568	2568
			.text	1361912	1361912
	light-app	default	(read/write)	2327768	2327768
			.bss	105600	105600
			.data	2408	2408
			.text	1286032	1286032
	lock-app	default	(read/write)	`2296792`	`2296792`
			.bss	104448	104448
			.data	2352	2352
			.text	`1255056`	`1255056`
qpg	lighting-app	qpg6105+debug	(read only)	563480	563480
			(read/write)	146936	146936
			.bss	89696	89696
			.data	1060	1060
			.text	558160	558160
	lock-app	qpg6105+debug	(read only)	513836	513836
			(read/write)	146940	146940
			.bss	88320	88320
			.data	984	984
			.text	508516	508516
	persistent-storage-app	qpg6105+debug	(read only)	106848	106848
			(read/write)	146940	146940
			.bss	38512	38512
			.data	288	288
			.text	101528	101528
telink	lighting-app	tlsr9518adk80d	(read/write)	838018	838018
			bss	86772	86772
			noinit	37160	37160
			text	585862	585862

examples/ota-provider-app/esp32/main/OTAProviderCommands.cpp

Also, modify Linux OTA Provider help for delayedActionTime cli option

Also, Apply suggestion from project-chip#13484 in lighting-app

github-actions · 2022-01-20T14:58:04Z

PR #13620: Size comparison from 786fdfa to 4b6c2d7

Full report (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`786fdfa`	`4b6c2d7`
efr32	lighting-app	BRD4161A	(read only)	832748	832748
			(read/write)	127032	127032
			.bss	125136	125136
			.data	1896	1896
			.text	832740	832740
		BRD4161A+rpc	(read only)	820128	820128
			(read/write)	143696	143696
			.bss	141696	141696
			.data	1996	1996
			.text	820120	820120
	window-app	BRD4161A	(read only)	803316	803316
			(read/write)	125720	125720
			.bss	123872	123872
			.data	1848	1848
			.text	803308	803308
esp32	all-clusters-app	c3devkit	(read only)	916434	916434
			(read/write)	1317506	1317506
			.dram0.bss	70720	70720
			.dram0.data	14244	14244
			.flash.rodata	178952	178952
			.flash.text	916434	916434
			.iram0.text	62056	62056
		m5stack	(read only)	965003	965003
			(read/write)	449464	449464
			.dram0.bss	75184	75184
			.dram0.data	34032	34032
			.flash.rodata	208120	208120
			.flash.text	959619	959619
			.iram0.text	123399	123399
k32w	light	k32w061+release	(read/write)	658572	658572
			.bss	76584	76584
			.data	1864	1864
			.text	574324	574324
	lock	k32w061+release	(read/write)	659368	659368
			.bss	76824	76824
			.data	1884	1884
			.text	574860	574860
linux	chip-tool-ipv6only	arm64	(read only)	8156012	8156012
			(read/write)	376481	376481
			.bss	56049	56049
			.data	1128	1128
			.data.rel.ro	249928	249928
			.dynamic	560	560
			.got	65632	65632
			.init	24	24
			.init_array	200	200
			.rodata	423044	423044
			.text	6928852	6928852
	thermostat-no-ble	arm64	(read only)	`2040876`	`2040876`
			(read/write)	145393	145393
			.bss	64753	64753
			.data	904	904
			.data.rel.ro	72728	72728
			.dynamic	560	560
			.got	4064	4064
			.init	24	24
			.init_array	312	312
			.rodata	130028	130028
			.text	1696688	1696688
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	940935	940935
			bss	119020	119020
			rodata	108492	108492
			text	635832	635832
		nrf52840dk_nrf52840+rpc	(read/write)	926415	926415
			bss	116064	116064
			rodata	100940	100940
			text	631228	631228
		nrf52840dongle_nrf52840	(read/write)	991611	991611
			bss	121864	121864
			rodata	113244	113244
			text	668032	668032
		nrf5340dk_nrf5340_cpuapp	(read/write)	850762	850762
			bss	115808	115808
			rodata	101668	101668
			text	552756	552756
	lock-app	nrf52840dk_nrf52840	(read/write)	910295	910295
			bss	118176	118176
			rodata	103460	103460
			text	611280	611280
		nrf5340dk_nrf5340_cpuapp	(read/write)	820346	820346
			bss	114992	114992
			rodata	96684	96684
			text	528236	528236
	pigweed-app	nrf52840dk_nrf52840	(read/write)	541835	541835
			bss	52588	52588
			rodata	50104	50104
			text	376940	376940
	pump-app	nrf52840dk_nrf52840	(read/write)	913151	913151
			bss	117940	117940
			rodata	103820	103820
			text	613928	613928
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	908231	908231
			bss	117964	117964
			rodata	102932	102932
			text	609856	609856
	shell	nrf52840dk_nrf52840	(read/write)	798479	798479
			bss	109776	109776
			rodata	78324	78324
			text	533872	533872
		nrf5340dk_nrf5340_cpuapp	(read/write)	711278	711278
			bss	107664	107664
			rodata	72624	72624
			text	451548	451548
p6	all-clusters-app	default	(read/write)	2406600	2406600
			.bss	117764	117764
			.data	2576	2576
			.text	1364864	1364864
	light-app	default	(read/write)	2327832	2327832
			.bss	105520	105520
			.data	2408	2408
			.text	`1286096`	`1286096`
	lock-app	default	(read/write)	`2296840`	`2296840`
			.bss	104368	104368
			.data	2352	2352
			.text	`1255104`	`1255104`
qpg	lighting-app	qpg6105+debug	(read only)	565376	565376
			(read/write)	146936	146936
			.bss	89672	89672
			.data	1060	1060
			.text	560056	560056
	lock-app	qpg6105+debug	(read only)	513868	513868
			(read/write)	146940	146940
			.bss	88240	88240
			.data	984	984
			.text	508548	508548
	persistent-storage-app	qpg6105+debug	(read only)	106848	106848
			(read/write)	146940	146940
			.bss	38512	38512
			.data	288	288
			.text	101528	101528
telink	lighting-app	tlsr9518adk80d	(read/write)	839398	839398
			bss	87468	87468
			noinit	37160	37160
			text	586504	586504

Co-authored-by: Carol Yang <[email protected]>

github-actions · 2022-01-20T19:12:05Z

PR #13620: Size comparison from 786fdfa to 0b90b1e

Increases above 0.2%:

platform	target	config	section	`786fdfa`	`0b90b1e`	change	% change
linux	chip-tool-ipv6only	arm64	(read only)	8156012	8390652	234640	2.9
			(read/write)	376481	386417	9936	2.6
			.data.rel.ro	249928	257432	7504	3.0
			.got	65632	68056	2424	3.7
			.rodata	423044	430228	7184	1.7
			.text	6928852	7131620	202768	2.9

Increases (23 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`786fdfa`	`0b90b1e`	change	% change
efr32	lighting-app	BRD4161A	(read only)	832748	833628	880	0.1
			.text	832740	833620	880	0.1
		BRD4161A+rpc	(read only)	820128	821008	880	0.1
			.text	820120	821000	880	0.1
	window-app	BRD4161A	(read only)	803316	804196	880	0.1
			.text	803308	804188	880	0.1
esp32	all-clusters-app	c3devkit	(read only)	916434	916854	420	0.0
			(read/write)	1317506	1317522	16	0.0
			.flash.rodata	178952	178968	16	0.0
			.flash.text	916434	916854	420	0.0
		m5stack	(read only)	965003	965463	460	0.0
			(read/write)	449464	449480	16	0.0
			.flash.rodata	208120	208136	16	0.0
			.flash.text	959619	960079	460	0.0
k32w	light	k32w061+release	(read/write)	658572	658924	352	0.1
			.text	574324	574676	352	0.1
	lock	k32w061+release	(read/write)	659368	659704	336	0.1
			.text	574860	575196	336	0.1
linux	chip-tool-ipv6only	arm64	(read only)	8156012	8390652	234640	2.9
			(read/write)	376481	386417	9936	2.6
			.data.rel.ro	249928	257432	7504	3.0
			.got	65632	68056	2424	3.7
			.rodata	423044	430228	7184	1.7
			.text	6928852	7131620	202768	2.9
	thermostat-no-ble	arm64	(read only)	`2040876`	2043324	2448	0.1
			(read/write)	145393	145425	32	0.0
			.data.rel.ro	72728	72752	24	0.0
			.text	1696688	1699136	2448	0.1
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	940935	941287	352	0.0
			rodata	108492	108508	16	0.0
			text	635832	636164	332	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	926415	926751	336	0.0
			rodata	100940	100956	16	0.0
			text	631228	631560	332	0.1
		nrf52840dongle_nrf52840	(read/write)	991611	991963	352	0.0
			rodata	113244	113260	16	0.0
			text	668032	668364	332	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	850762	851114	352	0.0
			rodata	101668	101684	16	0.0
			text	552756	553088	332	0.1
	lock-app	nrf52840dk_nrf52840	(read/write)	910295	910631	336	0.0
			rodata	103460	103476	16	0.0
			text	611280	611612	332	0.1
		nrf5340dk_nrf5340_cpuapp	(read/write)	820346	820698	352	0.0
			rodata	96684	96700	16	0.0
			text	528236	528568	332	0.1
	pump-app	nrf52840dk_nrf52840	(read/write)	913151	913503	352	0.0
			rodata	103820	103836	16	0.0
			text	613928	614260	332	0.1
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	908231	908583	352	0.0
			rodata	102932	102948	16	0.0
			text	609856	610188	332	0.1
p6	all-clusters-app	default	(read/write)	2406600	`2407464`	864	0.0
			.text	1364864	1365728	864	0.1
	light-app	default	(read/write)	2327832	`2328696`	864	0.0
			.text	`1286096`	1286960	864	0.1
	lock-app	default	(read/write)	`2296840`	2297704	864	0.0
			.text	`1255104`	`1255968`	864	0.1
qpg	lighting-app	qpg6105+debug	(read only)	565376	565720	344	0.1
			.text	560056	560400	344	0.1
	lock-app	qpg6105+debug	(read only)	513868	514212	344	0.1
			.text	508548	508892	344	0.1
telink	lighting-app	tlsr9518adk80d	(read/write)	839398	839882	484	0.1
			text	586504	586962	458	0.1

Full report (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`786fdfa`	`0b90b1e`	change	% change
efr32	lighting-app	BRD4161A	(read only)	832748	833628	880	0.1
			(read/write)	127032	127032	0	0.0
			.bss	125136	125136	0	0.0
			.data	1896	1896	0	0.0
			.text	832740	833620	880	0.1
		BRD4161A+rpc	(read only)	820128	821008	880	0.1
			(read/write)	143696	143696	0	0.0
			.bss	141696	141696	0	0.0
			.data	1996	1996	0	0.0
			.text	820120	821000	880	0.1
	window-app	BRD4161A	(read only)	803316	804196	880	0.1
			(read/write)	125720	125720	0	0.0
			.bss	123872	123872	0	0.0
			.data	1848	1848	0	0.0
			.text	803308	804188	880	0.1
esp32	all-clusters-app	c3devkit	(read only)	916434	916854	420	0.0
			(read/write)	1317506	1317522	16	0.0
			.dram0.bss	70720	70720	0	0.0
			.dram0.data	14244	14244	0	0.0
			.flash.rodata	178952	178968	16	0.0
			.flash.text	916434	916854	420	0.0
			.iram0.text	62056	62056	0	0.0
		m5stack	(read only)	965003	965463	460	0.0
			(read/write)	449464	449480	16	0.0
			.dram0.bss	75184	75184	0	0.0
			.dram0.data	34032	34032	0	0.0
			.flash.rodata	208120	208136	16	0.0
			.flash.text	959619	960079	460	0.0
			.iram0.text	123399	123399	0	0.0
k32w	light	k32w061+release	(read/write)	658572	658924	352	0.1
			.bss	76584	76584	0	0.0
			.data	1864	1864	0	0.0
			.text	574324	574676	352	0.1
	lock	k32w061+release	(read/write)	659368	659704	336	0.1
			.bss	76824	76824	0	0.0
			.data	1884	1884	0	0.0
			.text	574860	575196	336	0.1
linux	chip-tool-ipv6only	arm64	(read only)	8156012	8390652	234640	2.9
			(read/write)	376481	386417	9936	2.6
			.bss	56049	56049	0	0.0
			.data	1128	1128	0	0.0
			.data.rel.ro	249928	257432	7504	3.0
			.dynamic	560	560	0	0.0
			.got	65632	68056	2424	3.7
			.init	24	24	0	0.0
			.init_array	200	200	0	0.0
			.rodata	423044	430228	7184	1.7
			.text	6928852	7131620	202768	2.9
	thermostat-no-ble	arm64	(read only)	`2040876`	2043324	2448	0.1
			(read/write)	145393	145425	32	0.0
			.bss	64753	64753	0	0.0
			.data	904	904	0	0.0
			.data.rel.ro	72728	72752	24	0.0
			.dynamic	560	560	0	0.0
			.got	4064	4064	0	0.0
			.init	24	24	0	0.0
			.init_array	312	312	0	0.0
			.rodata	130028	130028	0	0.0
			.text	1696688	1699136	2448	0.1
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	940935	941287	352	0.0
			bss	119020	119020	0	0.0
			rodata	108492	108508	16	0.0
			text	635832	636164	332	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	926415	926751	336	0.0
			bss	116064	116064	0	0.0
			rodata	100940	100956	16	0.0
			text	631228	631560	332	0.1
		nrf52840dongle_nrf52840	(read/write)	991611	991963	352	0.0
			bss	121864	121864	0	0.0
			rodata	113244	113260	16	0.0
			text	668032	668364	332	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	850762	851114	352	0.0
			bss	115808	115808	0	0.0
			rodata	101668	101684	16	0.0
			text	552756	553088	332	0.1
	lock-app	nrf52840dk_nrf52840	(read/write)	910295	910631	336	0.0
			bss	118176	118176	0	0.0
			rodata	103460	103476	16	0.0
			text	611280	611612	332	0.1
		nrf5340dk_nrf5340_cpuapp	(read/write)	820346	820698	352	0.0
			bss	114992	114992	0	0.0
			rodata	96684	96700	16	0.0
			text	528236	528568	332	0.1
	pigweed-app	nrf52840dk_nrf52840	(read/write)	541835	541835	0	0.0
			bss	52588	52588	0	0.0
			rodata	50104	50104	0	0.0
			text	376940	376940	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	913151	913503	352	0.0
			bss	117940	117940	0	0.0
			rodata	103820	103836	16	0.0
			text	613928	614260	332	0.1
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	908231	908583	352	0.0
			bss	117964	117964	0	0.0
			rodata	102932	102948	16	0.0
			text	609856	610188	332	0.1
	shell	nrf52840dk_nrf52840	(read/write)	798479	798479	0	0.0
			bss	109776	109776	0	0.0
			rodata	78324	78324	0	0.0
			text	533872	533872	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	711278	711278	0	0.0
			bss	107664	107664	0	0.0
			rodata	72624	72624	0	0.0
			text	451548	451548	0	0.0
p6	all-clusters-app	default	(read/write)	2406600	`2407464`	864	0.0
			.bss	117764	117764	0	0.0
			.data	2576	2576	0	0.0
			.text	1364864	1365728	864	0.1
	light-app	default	(read/write)	2327832	`2328696`	864	0.0
			.bss	105520	105520	0	0.0
			.data	2408	2408	0	0.0
			.text	`1286096`	1286960	864	0.1
	lock-app	default	(read/write)	`2296840`	2297704	864	0.0
			.bss	104368	104368	0	0.0
			.data	2352	2352	0	0.0
			.text	`1255104`	`1255968`	864	0.1
qpg	lighting-app	qpg6105+debug	(read only)	565376	565720	344	0.1
			(read/write)	146936	146936	0	0.0
			.bss	89672	89672	0	0.0
			.data	1060	1060	0	0.0
			.text	560056	560400	344	0.1
	lock-app	qpg6105+debug	(read only)	513868	514212	344	0.1
			(read/write)	146940	146940	0	0.0
			.bss	88240	88240	0	0.0
			.data	984	984	0	0.0
			.text	508548	508892	344	0.1
	persistent-storage-app	qpg6105+debug	(read only)	106848	106848	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	38512	38512	0	0.0
			.data	288	288	0	0.0
			.text	101528	101528	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	839398	839882	484	0.1
			bss	87468	87468	0	0.0
			noinit	37160	37160	0	0.0
			text	586504	586962	458	0.1

… restart OTA Requestor once ApplyUpdate is successful (project-chip#13620) * [ESP32] CLI option to set delayedActionTime in OTA Provider app Also, modify Linux OTA Provider help for delayedActionTime cli option * [ESP32] Schedule the restart once OTA image apply is successful Also, Apply suggestion from project-chip#13484 in lighting-app * Review comments * Fix a small typo * Apply suggestions from code review Co-authored-by: Carol Yang <[email protected]> Co-authored-by: Carol Yang <[email protected]>

boring-cyborg bot added esp32 examples linux platform labels Jan 16, 2022

pullapprove bot requested review from anush-apple, austinh0, balducci-apple, Byungjoo-Lee, bzbarsky-apple, carol-apple, cecille, chrisdecenzo, chshu, chulspro, Damian-Nordic, dhrishi and electrocucaracha January 16, 2022 15:36

shubhamdp force-pushed the delayed_action_time branch from 165b8c5 to 1e695c4 Compare January 18, 2022 03:23

woody-apple force-pushed the delayed_action_time branch from 1e695c4 to 3168263 Compare January 18, 2022 15:33

carol-apple reviewed Jan 18, 2022

View reviewed changes

examples/lighting-app/esp32/README.md Outdated Show resolved Hide resolved

carol-apple reviewed Jan 18, 2022

View reviewed changes

examples/ota-requestor-app/esp32/README.md Outdated Show resolved Hide resolved

carol-apple reviewed Jan 18, 2022

View reviewed changes

src/platform/ESP32/OTAImageProcessorImpl.cpp Show resolved Hide resolved

woody-apple force-pushed the delayed_action_time branch from b0c6eae to adfbf36 Compare January 20, 2022 11:33

dhrishi approved these changes Jan 20, 2022

View reviewed changes

examples/ota-provider-app/esp32/main/OTAProviderCommands.cpp Outdated Show resolved Hide resolved

shubhamdp mentioned this pull request Jan 20, 2022

[ESP32] NotifyUpdateApplied should also be called once the device has booted to a new version #13760

Closed

shubhamdp added 4 commits January 20, 2022 20:03

[ESP32] CLI option to set delayedActionTime in OTA Provider app

6af4cbb

Also, modify Linux OTA Provider help for delayedActionTime cli option

[ESP32] Schedule the restart once OTA image apply is successful

47ee75c

Also, Apply suggestion from project-chip#13484 in lighting-app

Review comments

f4f1558

Fix a small typo

4b6c2d7

shubhamdp force-pushed the delayed_action_time branch from adfbf36 to 4b6c2d7 Compare January 20, 2022 14:36

carol-apple approved these changes Jan 20, 2022

View reviewed changes

Apply suggestions from code review

0b90b1e

Co-authored-by: Carol Yang <[email protected]>

holbrookt approved these changes Jan 20, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Jan 20, 2022

carol-apple merged commit dd209ce into project-chip:master Jan 21, 2022

shubhamdp deleted the delayed_action_time branch January 21, 2022 04:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ESP32] CLI option to set delayed action time in OTA Provider app and restart OTA Requestor once ApplyUpdate is successful #13620

[ESP32] CLI option to set delayed action time in OTA Provider app and restart OTA Requestor once ApplyUpdate is successful #13620

shubhamdp commented Jan 16, 2022

github-actions bot commented Jan 17, 2022 •

edited

Loading

github-actions bot commented Jan 18, 2022 •

edited

Loading

shubhamdp commented Jan 18, 2022

github-actions bot commented Jan 18, 2022 •

edited

Loading

github-actions bot commented Jan 19, 2022

shubhamdp commented Jan 20, 2022

github-actions bot commented Jan 20, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022 •

edited

Loading

[ESP32] CLI option to set delayed action time in OTA Provider app and restart OTA Requestor once ApplyUpdate is successful #13620

[ESP32] CLI option to set delayed action time in OTA Provider app and restart OTA Requestor once ApplyUpdate is successful #13620

Conversation

shubhamdp commented Jan 16, 2022

Problem

Change overview

Testing

github-actions bot commented Jan 17, 2022 • edited Loading

github-actions bot commented Jan 18, 2022 • edited Loading

shubhamdp commented Jan 18, 2022

github-actions bot commented Jan 18, 2022 • edited Loading

github-actions bot commented Jan 19, 2022

shubhamdp commented Jan 20, 2022

github-actions bot commented Jan 20, 2022 • edited Loading

github-actions bot commented Jan 20, 2022 • edited Loading

github-actions bot commented Jan 20, 2022 • edited Loading

github-actions bot commented Jan 17, 2022 •

edited

Loading

github-actions bot commented Jan 18, 2022 •

edited

Loading

github-actions bot commented Jan 18, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022 •

edited

Loading