Make access control cluster attributes nullable #13608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couldn't do this before as the tooling and/or generated code was not up to it. Now it seems to be able to handle the list attributes being nullable.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt and
pan-apple
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
Ideally related PR #13607 is merged first, though I think this will be OK if it does go in beforehand, it just won't actually handle null as an attribute value until it does, it'll just complain with an error if you try. |
|
PR #13608: Size comparison from a11413e to f6431f3 Increases (1 build for linux)
Decreases (5 builds for efr32, p6, qpg, telink)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
| @@ -67,13 +67,13 @@ limitations under the License. | |||
| and enforce Access Control for the Node’s endpoints and their associated | |||
| cluster instances.</description> | |||
| <!-- Base data types --> | |||
| <attribute side="server" code="0x0000" define="ACL" type="ARRAY" entryType="AccessControlEntry" writable="true"> | |||
| <attribute side="server" code="0x0000" define="ACL" type="ARRAY" entryType="AccessControlEntry" isNullable="true" writable="true"> | |||
There was a problem hiding this comment.
This is not nullable in the spec. Why are we marking it nullable?
|
PR #13608: Size comparison from a11413e to d439875 Increases (1 build for linux)
Decreases (1 build for esp32)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
The attributes were originally nullable in the spec, but I see they lost it at some point before we settled on final spec. I'll withdraw this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't do this before as the tooling and/or generated code was not up to it.
Now it seems to be able to handle the list attributes being nullable.
Problem
Access Control cluster attributes should be nullable. This couldn't be done when they were created
as the tooling and generated code were not up to it.
Change overview
Now that this is feasible, make the attributes in access-control-cluster.xml nullable.
Testing
Built and ran all-clusters-app on Linux with REPL to try null lists
as well as lists with items.