Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IDL files *.matter to reside together with input zap files #13603

Merged
merged 2 commits into from
Jan 15, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Jan 14, 2022

Problem

zzz_generated files are generally not expanded for code review, but we do want .matter files to be so (they are designed explicitly for reviewing changes for spec/sanity etc).

Change overview

Change zap generate to move Cluster.matter files to sit and be named as their corresponding .zap file.

To support this, made the 'ZAP Target' a separate class that supports generate and has IDL movement capabilities by understanding its parts (what is input/output/template etc).

Testing

Manually ran generation. Also CI will validate that zap passes.

@andy31415
Copy link
Contributor Author

fast track: a rename of files that do not affect how matter sdk actually runs. A review of the python bits should be sufficient.

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

PR #13603: Size comparison from a11413e to e2d404d

Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section a11413e e2d404d change % change
efr32 lighting-app BRD4161A (read only) 834852 834852 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 834844 834844 0 0.0
BRD4161A+rpc (read only) 822232 822232 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 822224 822224 0 0.0
window-app BRD4161A (read only) 805424 805424 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805416 805416 0 0.0
esp32 all-clusters-app c3devkit (read only) 912094 912094 0 0.0
(read/write) 1316682 1316682 0 0.0
.dram0.bss 70520 70520 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178384 178384 0 0.0
.flash.text 912094 912094 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 960883 960883 0 0.0
(read/write) 448840 448840 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207672 207672 0 0.0
.flash.text 955499 955499 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657920 657920 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 573132 573132 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576692 576692 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8042100 8042100 0 0.0
(read/write) 370641 370641 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245856 245856 0 0.0
.dynamic 560 560 0 0.0
.got 64776 64776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419420 419420 0 0.0
.text 6833684 6833684 0 0.0
thermostat-no-ble arm64 (read only) 2042108 2042108 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697632 1697632 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349856 2349856 0 0.0
.bss 189220 189220 0 0.0
.data 5320 5320 0 0.0
.text 1312432 1312432 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334504 2334504 0 0.0
.bss 180760 180760 0 0.0
.data 5568 5568 0 0.0
.text 1297104 1297104 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304848 2304848 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267448 1267448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
p6 all-clusters-app default (read/write) 2404384 2404384 0 0.0
.bss 117492 117492 0 0.0
.data 2600 2600 0 0.0
.text 1362648 1362648 0 0.0
light-app default (read/write) 2329688 2329688 0 0.0
.bss 106064 106064 0 0.0
.data 2392 2392 0 0.0
.text 1287952 1287952 0 0.0
lock-app default (read/write) 2298712 2298712 0 0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256976 1256976 0 0.0
qpg lighting-app qpg6105+debug (read only) 563984 563984 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1048 1048 0 0.0
.text 558664 558664 0 0.0
lock-app qpg6105+debug (read only) 515484 515484 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510164 510164 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840778 840778 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587748 587748 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 8aee604 into project-chip:master Jan 15, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
…ect-chip#13603)

* A first version of regen all which renames matter IDLs to sit along with source zap file

* Re-generate zap (which moves Clusters.matter to stay with zap files)
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
…ect-chip#13603)

* A first version of regen all which renames matter IDLs to sit along with source zap file

* Re-generate zap (which moves Clusters.matter to stay with zap files)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants