-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move IDL files *.matter to reside together with input zap files #13603
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
andy31415:matter_idl_move
Jan 15, 2022
Merged
Move IDL files *.matter to reside together with input zap files #13603
bzbarsky-apple
merged 2 commits into
project-chip:master
from
andy31415:matter_idl_move
Jan 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
January 14, 2022 22:32
pullapprove
bot
requested review from
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 14, 2022 22:32
fast track: a rename of files that do not affect how matter sdk actually runs. A review of the python bits should be sufficient. |
PR #13603: Size comparison from a11413e to e2d404d Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 15, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…ect-chip#13603) * A first version of regen all which renames matter IDLs to sit along with source zap file * Re-generate zap (which moves Clusters.matter to stay with zap files)
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…ect-chip#13603) * A first version of regen all which renames matter IDLs to sit along with source zap file * Re-generate zap (which moves Clusters.matter to stay with zap files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
zzz_generated files are generally not expanded for code review, but we do want .matter files to be so (they are designed explicitly for reviewing changes for spec/sanity etc).
Change overview
Change zap generate to move Cluster.matter files to sit and be named as their corresponding .zap file.
To support this, made the 'ZAP Target' a separate class that supports generate and has IDL movement capabilities by understanding its parts (what is input/output/template etc).
Testing
Manually ran generation. Also CI will validate that zap passes.