-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Remove hardcoded listening (mistakenly left over debug code) #13592
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jepenven-silabs:remove_hard_coded_listening
Jan 14, 2022
Merged
[Group] Remove hardcoded listening (mistakenly left over debug code) #13592
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jepenven-silabs:remove_hard_coded_listening
Jan 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
jelderton,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple and
sagar-apple
January 14, 2022 18:45
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
January 14, 2022 18:45
PR #13592: Size comparison from 3b8a3c7 to ce6ec82 Decreases (2 builds for efr32)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 14, 2022
andy31415
changed the title
[Group] BugFix
[Group] Remove hardcoded listening (mistakenly left over debug code)
Jan 14, 2022
andy31415
approved these changes
Jan 14, 2022
bzbarsky-apple
approved these changes
Jan 14, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hardcoded listening was added to the master branch
Change overview
Remove Hardcoded listening
Testing
Not tested since it's clearly debug code that wasn't removed before a PR was open