Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manufacturer code from attribute-table APIs. #13560

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Remove manufacturer code from attribute-table APIs. #13560

merged 1 commit into from
Jan 14, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

More manufacturer code arguments that are unused.

Change overview

Remove them.

Testing

No behavior changes.

@restyled-io restyled-io bot mentioned this pull request Jan 14, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 14, 2022 •
edited
Loading

PR #13560: Size comparison from 9c016d4 to 04acbac

Decreases (17 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 9c016d4 04acbac change % change
efr32 lighting-app BRD4161A (read only) 832756 832724 -32 -0.0
.text 832748 832716 -32 -0.0
BRD4161A+rpc (read only) 820160 820128 -32 -0.0
.text 820152 820120 -32 -0.0
window-app BRD4161A (read only) 805400 805368 -32 -0.0
.text 805392 805360 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 910032 909998 -34 -0.0
.flash.text 910032 909998 -34 -0.0
m5stack (read only) 959015 958971 -44 -0.0
.flash.text 953631 953587 -44 -0.0
k32w light k32w061+release (read/write) 657896 657880 -16 -0.0
.text 573108 573092 -16 -0.0
lock k32w061+release (read/write) 661596 661564 -32 -0.0
.text 576492 576460 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 8024788 8024756 -32 -0.0
.text 6819124 6819092 -32 -0.0
thermostat-no-ble arm64 (read only) 2041964 2041916 -48 -0.0
.text 1697504 1697456 -48 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2347824 2347760 -64 -0.0
.text 1310400 1310336 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2332408 2332344 -64 -0.0
.text 1295008 1294944 -64 -0.0
p6 all-clusters-app default (read/write) 2402296 2402280 -16 -0.0
.text 1360560 1360544 -16 -0.0
light-app default (read/write) 2327536 2327504 -32 -0.0
.text 1285800 1285768 -32 -0.0
lock-app default (read/write) 2298448 2298416 -32 -0.0
.text 1256712 1256680 -32 -0.0
qpg lighting-app qpg6105+debug (read only) 561976 561944 -32 -0.0
.text 556656 556624 -32 -0.0
lock-app qpg6105+debug (read only) 515292 515260 -32 -0.0
.text 509972 509940 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 838454 838422 -32 -0.0
text 585616 585582 -34 -0.0
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 9c016d4 04acbac change % change
efr32 lighting-app BRD4161A (read only) 832756 832724 -32 -0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 832748 832716 -32 -0.0
BRD4161A+rpc (read only) 820160 820128 -32 -0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 820152 820120 -32 -0.0
window-app BRD4161A (read only) 805400 805368 -32 -0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805392 805360 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 910032 909998 -34 -0.0
(read/write) 1316498 1316498 0 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178216 178216 0 0.0
.flash.text 910032 909998 -34 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959015 958971 -44 -0.0
(read/write) 448664 448664 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207496 207496 0 0.0
.flash.text 953631 953587 -44 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657896 657880 -16 -0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 573108 573092 -16 -0.0
lock k32w061+release (read/write) 661596 661564 -32 -0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576492 576460 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 8024788 8024756 -32 -0.0
(read/write) 370241 370241 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245760 245760 0 0.0
.dynamic 560 560 0 0.0
.got 64472 64472 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 417772 417772 0 0.0
.text 6819124 6819092 -32 -0.0
thermostat-no-ble arm64 (read only) 2041964 2041916 -48 -0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129868 129868 0 0.0
.text 1697504 1697456 -48 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347824 2347760 -64 -0.0
.bss 189204 189204 0 0.0
.data 5320 5320 0 0.0
.text 1310400 1310336 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332408 2332344 -64 -0.0
.bss 180752 180752 0 0.0
.data 5560 5560 0 0.0
.text 1295008 1294944 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304528 2304528 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267128 1267128 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054456 2054456 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017056 1017056 0 0.0
p6 all-clusters-app default (read/write) 2402296 2402280 -16 -0.0
.bss 117484 117484 0 0.0
.data 2592 2592 0 0.0
.text 1360560 1360544 -16 -0.0
light-app default (read/write) 2327536 2327504 -32 -0.0
.bss 106064 106064 0 0.0
.data 2392 2392 0 0.0
.text 1285800 1285768 -32 -0.0
lock-app default (read/write) 2298448 2298416 -32 -0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256712 1256680 -32 -0.0
qpg lighting-app qpg6105+debug (read only) 561976 561944 -32 -0.0
(read/write) 146936 146936 0 0.0
.bss 89952 89952 0 0.0
.data 1044 1044 0 0.0
.text 556656 556624 -32 -0.0
lock-app qpg6105+debug (read only) 515292 515260 -32 -0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 509972 509940 -32 -0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838454 838422 -32 -0.0
bss 87312 87312 0 0.0
noinit 37160 37160 0 0.0
text 585616 585582 -34 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the remove-mfg-code-attr-table branch from 04acbac to 936793a Compare January 14, 2022 02:11
@github-actions
Copy link

github-actions bot commented Jan 14, 2022 •
edited
Loading

PR #13560: Size comparison from 5e61ce9 to 936793a

Decreases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e61ce9 936793a change % change
efr32 lighting-app BRD4161A (read only) 832764 832732 -32 -0.0
.text 832756 832724 -32 -0.0
BRD4161A+rpc (read only) 820168 820152 -16 -0.0
.text 820160 820144 -16 -0.0
window-app BRD4161A (read only) 805424 805392 -32 -0.0
.text 805416 805384 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 910034 910000 -34 -0.0
.flash.text 910034 910000 -34 -0.0
m5stack (read only) 959027 958983 -44 -0.0
.flash.text 953643 953599 -44 -0.0
k32w light k32w061+release (read/write) 657920 657888 -32 -0.0
.text 573132 573100 -32 -0.0
lock k32w061+release (read/write) 661604 661572 -32 -0.0
.text 576500 576468 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 8024820 8024772 -48 -0.0
.text 6819140 6819092 -48 -0.0
thermostat-no-ble arm64 (read only) 2041980 2041932 -48 -0.0
.text 1697504 1697456 -48 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2347832 2347768 -64 -0.0
.text 1310408 1310344 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2332416 2332352 -64 -0.0
.text 1295016 1294952 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941447 941367 -80 -0.0
text 635576 635500 -76 -0.0
nrf52840dk_nrf52840+rpc (read/write) 926911 926847 -64 -0.0
text 630968 630892 -76 -0.0
nrf52840dongle_nrf52840 (read/write) 992091 992011 -80 -0.0
text 667772 667696 -76 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851270 851190 -80 -0.0
text 552492 552420 -72 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912619 912539 -80 -0.0
text 612672 612596 -76 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822686 822606 -80 -0.0
text 529632 529560 -72 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 913991 913927 -64 -0.0
text 613996 613924 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910747 910683 -64 -0.0
text 611448 611380 -68 -0.0
p6 all-clusters-app default (read/write) 2402304 2402288 -16 -0.0
.text 1360568 1360552 -16 -0.0
light-app default (read/write) 2327544 2327512 -32 -0.0
.text 1285808 1285776 -32 -0.0
lock-app default (read/write) 2298456 2298424 -32 -0.0
.text 1256720 1256688 -32 -0.0
qpg lighting-app qpg6105+debug (read only) 561976 561944 -32 -0.0
.text 556656 556624 -32 -0.0
lock-app qpg6105+debug (read only) 515292 515260 -32 -0.0
.text 509972 509940 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 838462 838430 -32 -0.0
text 585618 585584 -34 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e61ce9 936793a change % change
efr32 lighting-app BRD4161A (read only) 832764 832732 -32 -0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 832756 832724 -32 -0.0
BRD4161A+rpc (read only) 820168 820152 -16 -0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 820160 820144 -16 -0.0
window-app BRD4161A (read only) 805424 805392 -32 -0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805416 805384 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 910034 910000 -34 -0.0
(read/write) 1316506 1316506 0 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178224 178224 0 0.0
.flash.text 910034 910000 -34 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959027 958983 -44 -0.0
(read/write) 448672 448672 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207504 207504 0 0.0
.flash.text 953643 953599 -44 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657920 657888 -32 -0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 573132 573100 -32 -0.0
lock k32w061+release (read/write) 661604 661572 -32 -0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576500 576468 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 8024820 8024772 -48 -0.0
(read/write) 370241 370241 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245760 245760 0 0.0
.dynamic 560 560 0 0.0
.got 64472 64472 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 417788 417788 0 0.0
.text 6819140 6819092 -48 -0.0
thermostat-no-ble arm64 (read only) 2041980 2041932 -48 -0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697504 1697456 -48 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347832 2347768 -64 -0.0
.bss 189204 189204 0 0.0
.data 5320 5320 0 0.0
.text 1310408 1310344 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332416 2332352 -64 -0.0
.bss 180752 180752 0 0.0
.data 5560 5560 0 0.0
.text 1295016 1294952 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304536 2304536 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267136 1267136 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941447 941367 -80 -0.0
bss 119624 119624 0 0.0
rodata 108660 108660 0 0.0
text 635576 635500 -76 -0.0
nrf52840dk_nrf52840+rpc (read/write) 926911 926847 -64 -0.0
bss 116668 116668 0 0.0
rodata 101108 101108 0 0.0
text 630968 630892 -76 -0.0
nrf52840dongle_nrf52840 (read/write) 992091 992011 -80 -0.0
bss 122464 122464 0 0.0
rodata 113412 113412 0 0.0
text 667772 667696 -76 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851270 851190 -80 -0.0
bss 116412 116412 0 0.0
rodata 101832 101832 0 0.0
text 552492 552420 -72 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912619 912539 -80 -0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612672 612596 -76 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822686 822606 -80 -0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529632 529560 -72 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913991 913927 -64 -0.0
bss 118544 118544 0 0.0
rodata 104004 104004 0 0.0
text 613996 613924 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910747 910683 -64 -0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611448 611380 -68 -0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451672 451672 0 0.0
p6 all-clusters-app default (read/write) 2402304 2402288 -16 -0.0
.bss 117484 117484 0 0.0
.data 2592 2592 0 0.0
.text 1360568 1360552 -16 -0.0
light-app default (read/write) 2327544 2327512 -32 -0.0
.bss 106064 106064 0 0.0
.data 2392 2392 0 0.0
.text 1285808 1285776 -32 -0.0
lock-app default (read/write) 2298456 2298424 -32 -0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256720 1256688 -32 -0.0
qpg lighting-app qpg6105+debug (read only) 561976 561944 -32 -0.0
(read/write) 146936 146936 0 0.0
.bss 89952 89952 0 0.0
.data 1044 1044 0 0.0
.text 556656 556624 -32 -0.0
lock-app qpg6105+debug (read only) 515292 515260 -32 -0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 509972 509940 -32 -0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838462 838430 -32 -0.0
bss 87312 87312 0 0.0
noinit 37160 37160 0 0.0
text 585618 585584 -34 -0.0

@andy31415
Copy link
Contributor

fast track: this is a cleanup PR that has been up sufficient time for cross timezone review.

@andy31415 andy31415 merged commit 1a4a061 into project-chip:master Jan 14, 2022
@bzbarsky-apple bzbarsky-apple deleted the remove-mfg-code-attr-table branch January 14, 2022 16:02
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Remove manufacturer code from attribute-table APIs. (project-chip#13560)
d1782ad
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@bzbarsky-apple @step0035
Remove manufacturer code from attribute-table APIs. (project-chip#13560)
d1cbb31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @saurabhst