Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pointers in AndroidDeviceControllerWrapper are init to nullptr #13557

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Ensure pointers in AndroidDeviceControllerWrapper are init to nullptr #13557

merged 1 commit into from
Jan 14, 2022

Conversation

g-coppock
Copy link
Contributor

Testing

Tested locally on an Android device on the reported code path without a crash.

@g-coppock g-coppock force-pushed the pr/coppock/fix_pointer_nulls branch from f82358b to 221baab Compare January 13, 2022 23:29
@g-coppock
Ensure pointers in AndroidDeviceControllerWrapper are init to nullptr
64fb594 
Fixes project-chip#13556

Tested locally on an Android device on the reported code path without a crash.
@g-coppock g-coppock force-pushed the pr/coppock/fix_pointer_nulls branch from 221baab to 64fb594 Compare January 13, 2022 23:33
@g-coppock g-coppock marked this pull request as ready for review January 13, 2022 23:37
@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

PR #13557: Size comparison from 502963f to 64fb594

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 502963f 64fb594 change % change
efr32 lighting-app BRD4161A (read only) 832820 832820 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 832812 832812 0 0.0
BRD4161A+rpc (read only) 820224 820224 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 820216 820216 0 0.0
window-app BRD4161A (read only) 805448 805448 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805440 805440 0 0.0
esp32 all-clusters-app c3devkit (read only) 910080 910080 0 0.0
(read/write) 1316498 1316498 0 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178216 178216 0 0.0
.flash.text 910080 910080 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959051 959051 0 0.0
(read/write) 448664 448664 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207496 207496 0 0.0
.flash.text 953667 953667 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657944 657944 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 573156 573156 0 0.0
lock k32w061+release (read/write) 661660 661660 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576556 576556 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8024884 8024884 0 0.0
(read/write) 370241 370241 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245760 245760 0 0.0
.dynamic 560 560 0 0.0
.got 64472 64472 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 417772 417772 0 0.0
.text 6819220 6819220 0 0.0
thermostat-no-ble arm64 (read only) 2042140 2042140 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129868 129868 0 0.0
.text 1697680 1697680 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347824 2347824 0 0.0
.bss 189204 189204 0 0.0
.data 5320 5320 0 0.0
.text 1310400 1310400 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332408 2332408 0 0.0
.bss 180752 180752 0 0.0
.data 5560 5560 0 0.0
.text 1295008 1295008 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304592 2304592 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267192 1267192 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054456 2054456 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017056 1017056 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941499 941499 0 0.0
bss 119624 119624 0 0.0
rodata 108648 108648 0 0.0
text 635640 635640 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926983 926983 0 0.0
bss 116668 116668 0 0.0
rodata 101100 101100 0 0.0
text 631036 631036 0 0.0
nrf52840dongle_nrf52840 (read/write) 992147 992147 0 0.0
bss 122464 122464 0 0.0
rodata 113404 113404 0 0.0
text 667840 667840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851326 851326 0 0.0
bss 116412 116412 0 0.0
rodata 101824 101824 0 0.0
text 552560 552560 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912671 912671 0 0.0
bss 118784 118784 0 0.0
rodata 103780 103780 0 0.0
text 612740 612740 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822742 822742 0 0.0
bss 115600 115600 0 0.0
rodata 97008 97008 0 0.0
text 529696 529696 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914047 914047 0 0.0
bss 118544 118544 0 0.0
rodata 103996 103996 0 0.0
text 614064 614064 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910783 910783 0 0.0
bss 118572 118572 0 0.0
rodata 103252 103252 0 0.0
text 611496 611496 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798643 798643 0 0.0
bss 109776 109776 0 0.0
rodata 78376 78376 0 0.0
text 533988 533988 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711462 711462 0 0.0
bss 107664 107664 0 0.0
rodata 72680 72680 0 0.0
text 451668 451668 0 0.0
p6 all-clusters-app default (read/write) 2402392 2402392 0 0.0
.bss 117484 117484 0 0.0
.data 2592 2592 0 0.0
.text 1360656 1360656 0 0.0
light-app default (read/write) 2327600 2327600 0 0.0
.bss 106064 106064 0 0.0
.data 2392 2392 0 0.0
.text 1285864 1285864 0 0.0
lock-app default (read/write) 2298512 2298512 0 0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256776 1256776 0 0.0
qpg lighting-app qpg6105+debug (read only) 562040 562040 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89952 89952 0 0.0
.data 1044 1044 0 0.0
.text 556720 556720 0 0.0
lock-app qpg6105+debug (read only) 515356 515356 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510036 510036 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838494 838494 0 0.0
bss 87312 87312 0 0.0
noinit 37160 37160 0 0.0
text 585654 585654 0 0.0

@andy31415
Copy link
Contributor

fast track: trivial platform-specific change.

@andy31415 andy31415 merged commit ede482a into project-chip:master Jan 14, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@g-coppock @selissia
Ensure pointers in AndroidDeviceControllerWrapper are init to nullptr (…
e86d249 
…project-chip#13557)

Fixes project-chip#13556

Tested locally on an Android device on the reported code path without a crash.
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@g-coppock @step0035
Ensure pointers in AndroidDeviceControllerWrapper are init to nullptr (…
b1de87c 
…project-chip#13557)

Fixes project-chip#13556

Tested locally on an Android device on the reported code path without a crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspang mspang mspang approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] OnCommissioningComplete handling in AndroidDeviceControllerWrapper.cpp occasionally crashes
3 participants
@g-coppock @andy31415 @mspang