-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZAP to fix endpoint_config handling of manufacturer-specific ids. #13553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
January 13, 2022 22:44
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 13, 2022 22:44
PR #13553: Size comparison from 79db3db to f6e586e Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
fessehaeve
approved these changes
Jan 14, 2022
bzbarsky-apple
force-pushed
the
zap-update
branch
from
January 15, 2022 00:06
f6e586e
to
6a0a46b
Compare
PR #13553: Size comparison from a11413e to 6a0a46b Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jan 17, 2022
bzbarsky-apple
force-pushed
the
zap-update
branch
from
January 18, 2022 23:53
6a0a46b
to
294f6c9
Compare
PR #13553: Size comparison from 4f84672 to 294f6c9 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
vivien-apple
approved these changes
Jan 19, 2022
We now generate full 32-bit ids, instead of dropping the top 16 bits.
bzbarsky-apple
force-pushed
the
zap-update
branch
from
January 19, 2022 16:54
294f6c9
to
05a8d62
Compare
mrjerryjohns
approved these changes
Jan 19, 2022
msandstedt
approved these changes
Jan 19, 2022
PR #13553: Size comparison from 5274676 to 05a8d62 Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…ds. (project-chip#13553) We now generate full 32-bit ids, instead of dropping the top 16 bits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now generate full 32-bit ids, instead of dropping the top 16 bits.
Problem
Attribute/cluster/etc ids in endpoint_config.h just have the low 16 bits of the MEI.
Change overview
Update ZAP to a version that outputs the full MEI.
Testing
No behavior changes expected in CI because we don't use manufacturer-specific things here. @fessehaeve confirmed that this fixes manufacturer-specific bits for them.