Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have commissioner call cleanup on error. #13518

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Jan 13, 2022

Problem

Commissioning doesn't auto-reset itself on error

Change overview

Calls commissioning cleanup on error

Testing

Forced an error in commissioning (added code to cause one of the steps to error on the first attempt). Tested in chip-device-ctrl by establishing a pase connection, then calling commission (failure), then commission again (success).

@github-actions
Copy link

github-actions bot commented Jan 13, 2022

PR #13518: Size comparison from 60347b6 to b074726

Increases (1 build for linux)
platform target config section 60347b6 b074726 change % change
linux chip-tool-ipv6only arm64 (read only) 7215212 7215596 384 0.0
.rodata 392436 392532 96 0.0
.text 6089508 6089796 288 0.0
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 60347b6 b074726 change % change
efr32 lighting-app BRD4161A (read only) 831200 831200 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 831192 831192 0 0.0
BRD4161A+rpc (read only) 818604 818604 0 0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 818596 818596 0 0.0
window-app BRD4161A (read only) 805096 805096 0 0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 805088 805088 0 0.0
k32w light k32w061+release (read/write) 656952 656952 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572476 572476 0 0.0
lock k32w061+release (read/write) 661252 661252 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576460 576460 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7215212 7215596 384 0.0
(read/write) 345921 345921 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 227824 227824 0 0.0
.dynamic 560 560 0 0.0
.got 58440 58440 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 392436 392532 96 0.0
.text 6089508 6089796 288 0.0
thermostat-no-ble arm64 (read only) 2039628 2039628 0 0.0
(read/write) 145617 145617 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129756 129756 0 0.0
.text 1695312 1695312 0 0.0
p6 all-clusters-app default (read/write) 2400272 2400272 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1358536 1358536 0 0.0
light-app default (read/write) 2325968 2325968 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1284232 1284232 0 0.0
lock-app default (read/write) 2298200 2298200 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1256464 1256464 0 0.0
qpg lighting-app qpg6105+debug (read only) 535004 535004 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89024 89024 0 0.0
.data 1008 1008 0 0.0
.text 529684 529684 0 0.0
lock-app qpg6105+debug (read only) 506908 506908 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88160 88160 0 0.0
.data 956 956 0 0.0
.text 501588 501588 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836510 836510 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 584166 584166 0 0.0

@andy31415 andy31415 merged commit 45214cf into project-chip:master Jan 14, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants