Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ameba Build Issue #13498

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Ameba Build Issue #13498

merged 1 commit into from
Jan 12, 2022

Conversation

chrisbeach59
Copy link
Contributor

Problem:
amebaD sdk uses u32 as a typedef. CHIPTLVReader.cpp uses u32 in a function as an identifier. This causes a build failure

Solution:
Renamed "u32" to "unsigned32" in CHIPTLVReader.cpp
Change limited only to name change within a single function
Testing:
Verified builds gn_build.sh
Verified all clusters app for amebad

@chrisbeach59
Ameba Build Issue
91a3e29 
When moving the files from examples/thermostat/ameba/main to top level of project. GLOBAL_CFLAGS += -DCHIP_PROJECT=1  must be included in the make file.  make all would fail with CHIP_PROJECT=1 becuase the type def's for u32, and u64 were removed
But when u32 is undefined during the chip_main build connectedhomeip/src/lib/core/CHIPTLVReader.cpp will fail since u32 is used a a variable name.
@boring-cyborg boring-cyborg bot added the lib label Jan 12, 2022
@andy31415
Copy link
Contributor

fast track: small delta, simple change.

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR #13498: Size comparison from 1181e94 to 91a3e29

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1181e94 91a3e29 change % change
efr32 lighting-app BRD4161A (read only) 830532 830532 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830524 830524 0 0.0
BRD4161A+rpc (read only) 817936 817936 0 0.0
(read/write) 143964 143964 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817928 817928 0 0.0
window-app BRD4161A (read only) 804476 804476 0 0.0
(read/write) 126004 126004 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804468 804468 0 0.0
esp32 all-clusters-app c3devkit (read only) 908118 908118 0 0.0
(read/write) 1315962 1315962 0 0.0
.dram0.bss 70176 70176 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178016 178016 0 0.0
.flash.text 908118 908118 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 956875 956875 0 0.0
(read/write) 448128 448128 0 0.0
.dram0.bss 74640 74640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207296 207296 0 0.0
.flash.text 951491 951491 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656644 656644 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572168 572168 0 0.0
lock k32w061+release (read/write) 660980 660980 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576188 576188 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7200028 7200028 0 0.0
(read/write) 344801 344801 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 226744 226744 0 0.0
.dynamic 560 560 0 0.0
.got 58392 58392 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 392004 392004 0 0.0
.text 6076212 6076212 0 0.0
thermostat-no-ble arm64 (read only) 2038540 2038540 0 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129628 129628 0 0.0
.text 1694608 1694608 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2345776 2345776 0 0.0
.bss 188868 188868 0 0.0
.data 5320 5320 0 0.0
.text 1308352 1308352 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330808 2330808 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293408 1293408 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304032 2304032 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266632 1266632 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939571 939571 0 0.0
bss 119284 119284 0 0.0
rodata 108448 108448 0 0.0
text 634268 634268 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 925039 925039 0 0.0
bss 116328 116328 0 0.0
rodata 100900 100900 0 0.0
text 629624 629624 0 0.0
nrf52840dongle_nrf52840 (read/write) 990247 990247 0 0.0
bss 122128 122128 0 0.0
rodata 113200 113200 0 0.0
text 666468 666468 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849430 849430 0 0.0
bss 116072 116072 0 0.0
rodata 101624 101624 0 0.0
text 551192 551192 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911843 911843 0 0.0
bss 118472 118472 0 0.0
rodata 103720 103720 0 0.0
text 612260 612260 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821882 821882 0 0.0
bss 115288 115288 0 0.0
rodata 96948 96948 0 0.0
text 529224 529224 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913123 913123 0 0.0
bss 118232 118232 0 0.0
rodata 103936 103936 0 0.0
text 613520 613520 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909923 909923 0 0.0
bss 118260 118260 0 0.0
rodata 103192 103192 0 0.0
text 611012 611012 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798439 798439 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533880 533880 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711254 711254 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451560 451560 0 0.0
p6 all-clusters-app default (read/write) 2399640 2399640 0 0.0
.bss 117140 117140 0 0.0
.data 2592 2592 0 0.0
.text 1357904 1357904 0 0.0
light-app default (read/write) 2325376 2325376 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283640 1283640 0 0.0
lock-app default (read/write) 2297600 2297600 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255864 1255864 0 0.0
qpg lighting-app qpg6105+debug (read only) 534308 534308 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528988 528988 0 0.0
lock-app qpg6105+debug (read only) 506228 506228 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500908 500908 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836102 836102 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583852 583852 0 0.0

@andy31415 andy31415 merged commit 0c498e0 into project-chip:master Jan 12, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@chrisbeach59 @selissia
Ameba Build Issue (project-chip#13498)
abb3040 
When moving the files from examples/thermostat/ameba/main to top level of project. GLOBAL_CFLAGS += -DCHIP_PROJECT=1  must be included in the make file.  make all would fail with CHIP_PROJECT=1 becuase the type def's for u32, and u64 were removed
But when u32 is undefined during the chip_main build connectedhomeip/src/lib/core/CHIPTLVReader.cpp will fail since u32 is used a a variable name.
@chrisbeach59 chrisbeach59 deleted the renameu32 branch January 31, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@andy31415 andy31415 Awaiting requested review from andy31415

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbeach59 @andy31415