Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infineon CYW30739 - lighting-app support #13491

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Infineon CYW30739 - lighting-app support #13491

merged 1 commit into from
Jan 21, 2022

Conversation

ItoddchouFX
Copy link
Contributor

Problem

There is no Support for Infineon CYW30739 board on Matter

Change overview

Adding Support for Infineon CYW930739M2EVB-01 board on Matter along with lighting-app example

Testing

How was this tested? (at least one bullet point required)

  • If manually tested, what platforms controller and device platforms were manually tested, and how?
    Raspberry Pi OTBR + CYW930739M2EVB-01, Detailed steps are added in lighting-app README.md
    Build command
    ./scripts/examples/gn_build_example.sh examples/lighting-app/cyw30739 out/lighting-app

@ItoddchouFX
Copy link
Contributor Author

ItoddchouFX commented Jan 12, 2022 •
edited
Loading

There is the reason of Error restyling. Can someone help?
! [remote rejected] restyled/cyw30739_lighting -> restyled/cyw30739_lighting (refusing to allow a GitHub App to create or update workflow .github/workflows/examples-cyw30739.yaml without workflows permission)

@andy31415
Copy link
Contributor

There is the reason of Error restyling. Can someone help? ! [remote rejected] restyled/cyw30739_lighting -> restyled/cyw30739_lighting (refusing to allow a GitHub App to create or update workflow .github/workflows/examples-cyw30739.yaml without workflows permission)

Restyler cannot create PRs to update style for anything that changes workflows.

However manually restyling (e.g. via ./scripts/helpers/restyle-diff.sh) should work and will make restyler not try to create PRs.

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR #13491: Size comparison from 54f4e43 to 10b62b8

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 54f4e43 10b62b8 change % change
efr32 lighting-app BRD4161A (read only) 830532 830532 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830524 830524 0 0.0
BRD4161A+rpc (read only) 817936 817936 0 0.0
(read/write) 143964 143964 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817928 817928 0 0.0
window-app BRD4161A (read only) 804476 804476 0 0.0
(read/write) 126004 126004 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804468 804468 0 0.0
esp32 all-clusters-app c3devkit (read only) 895402 895402 0 0.0
(read/write) 1315570 1315570 0 0.0
.dram0.bss 70160 70160 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 177704 177704 0 0.0
.flash.text 895402 895402 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 956755 956755 0 0.0
(read/write) 448064 448064 0 0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207216 207216 0 0.0
.flash.text 951371 951371 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656644 656644 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572168 572168 0 0.0
lock k32w061+release (read/write) 660980 660980 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576188 576188 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7199996 7199996 0 0.0
(read/write) 344801 344801 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 226744 226744 0 0.0
.dynamic 560 560 0 0.0
.got 58392 58392 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 392004 392004 0 0.0
.text 6076180 6076180 0 0.0
thermostat-no-ble arm64 (read only) 2038540 2038540 0 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129628 129628 0 0.0
.text 1694608 1694608 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2345776 2345776 0 0.0
.bss 188868 188868 0 0.0
.data 5320 5320 0 0.0
.text 1308352 1308352 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330808 2330808 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293408 1293408 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304032 2304032 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266632 1266632 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939571 939571 0 0.0
bss 119284 119284 0 0.0
rodata 108448 108448 0 0.0
text 634268 634268 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 925039 925039 0 0.0
bss 116328 116328 0 0.0
rodata 100900 100900 0 0.0
text 629624 629624 0 0.0
nrf52840dongle_nrf52840 (read/write) 990247 990247 0 0.0
bss 122128 122128 0 0.0
rodata 113200 113200 0 0.0
text 666468 666468 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849430 849430 0 0.0
bss 116072 116072 0 0.0
rodata 101624 101624 0 0.0
text 551192 551192 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911843 911843 0 0.0
bss 118472 118472 0 0.0
rodata 103720 103720 0 0.0
text 612260 612260 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821882 821882 0 0.0
bss 115288 115288 0 0.0
rodata 96948 96948 0 0.0
text 529224 529224 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913123 913123 0 0.0
bss 118232 118232 0 0.0
rodata 103936 103936 0 0.0
text 613520 613520 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909923 909923 0 0.0
bss 118260 118260 0 0.0
rodata 103192 103192 0 0.0
text 611012 611012 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798439 798439 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533880 533880 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711254 711254 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451560 451560 0 0.0
p6 all-clusters-app default (read/write) 2399640 2399640 0 0.0
.bss 117140 117140 0 0.0
.data 2592 2592 0 0.0
.text 1357904 1357904 0 0.0
light-app default (read/write) 2325376 2325376 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283640 1283640 0 0.0
lock-app default (read/write) 2297600 2297600 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255864 1255864 0 0.0
qpg lighting-app qpg6105+debug (read only) 534308 534308 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528988 528988 0 0.0
lock-app qpg6105+debug (read only) 506228 506228 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500908 500908 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836102 836102 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583852 583852 0 0.0

woody-apple
woody-apple reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking given platform changes by a platform maintainer.

@ItoddchouFX ItoddchouFX marked this pull request as draft January 17, 2022 11:54
@ItoddchouFX ItoddchouFX marked this pull request as ready for review January 17, 2022 12:32
@ItoddchouFX ItoddchouFX requested a review from andy31415 January 19, 2022 01:35
@ItoddchouFX
Copy link
Contributor Author

@bzbarsky-apple @andy31415 @woody-apple Please help review this PR.

@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13491: Size comparison from c24c34b to d63046a

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c24c34b0 d63046a change % change
efr32 lighting-app BRD4161A (read only) 833628 833628 0 0.0
(read/write) 127216 127216 0 0.0
.bss 125320 125320 0 0.0
.data 1896 1896 0 0.0
.text 833620 833620 0 0.0
BRD4161A+rpc (read only) 821024 821024 0 0.0
(read/write) 143880 143880 0 0.0
.bss 141880 141880 0 0.0
.data 1996 1996 0 0.0
.text 821016 821016 0 0.0
window-app BRD4161A (read only) 804212 804212 0 0.0
(read/write) 125792 125792 0 0.0
.bss 123944 123944 0 0.0
.data 1848 1848 0 0.0
.text 804204 804204 0 0.0
esp32 all-clusters-app c3devkit (read only) 917012 917012 0 0.0
(read/write) 1317522 1317522 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178968 178968 0 0.0
.flash.text 917012 917012 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965567 965567 0 0.0
(read/write) 449480 449480 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208136 208136 0 0.0
.flash.text 960183 960183 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 658924 658924 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574676 574676 0 0.0
lock k32w061+release (read/write) 659704 659704 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575196 575196 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8428284 8428284 0 0.0
(read/write) 388769 388769 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 259416 259416 0 0.0
.dynamic 560 560 0 0.0
.got 68424 68424 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 434308 434308 0 0.0
.text 7160228 7160228 0 0.0
thermostat-no-ble arm64 (read only) 2043324 2043324 0 0.0
(read/write) 145425 145425 0 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699136 1699136 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350096 2350096 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312672 1312672 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332728 2332728 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1295328 1295328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303080 2303080 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265680 1265680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941287 941287 0 0.0
bss 119020 119020 0 0.0
rodata 108508 108508 0 0.0
text 636172 636172 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926767 926767 0 0.0
bss 116064 116064 0 0.0
rodata 100956 100956 0 0.0
text 631568 631568 0 0.0
nrf52840dongle_nrf52840 (read/write) 991963 991963 0 0.0
bss 121864 121864 0 0.0
rodata 113260 113260 0 0.0
text 668372 668372 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851114 851114 0 0.0
bss 115808 115808 0 0.0
rodata 101684 101684 0 0.0
text 553096 553096 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910631 910631 0 0.0
bss 118176 118176 0 0.0
rodata 103476 103476 0 0.0
text 611612 611612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820698 820698 0 0.0
bss 114992 114992 0 0.0
rodata 96700 96700 0 0.0
text 528568 528568 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913503 913503 0 0.0
bss 117940 117940 0 0.0
rodata 103836 103836 0 0.0
text 614260 614260 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908583 908583 0 0.0
bss 117964 117964 0 0.0
rodata 102948 102948 0 0.0
text 610188 610188 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2407720 2407720 0 0.0
.bss 117772 117772 0 0.0
.data 2584 2584 0 0.0
.text 1365984 1365984 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2297704 2297704 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255968 1255968 0 0.0
qpg lighting-app qpg6105+debug (read only) 565840 565840 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89664 89664 0 0.0
.data 1060 1060 0 0.0
.text 560520 560520 0 0.0
lock-app qpg6105+debug (read only) 514328 514328 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88232 88232 0 0.0
.data 984 984 0 0.0
.text 509008 509008 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839890 839890 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586972 586972 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 1af90eb into project-chip:master Jan 21, 2022
@ItoddchouFX ItoddchouFX deleted the cyw30739_lighting branch January 21, 2022 06:37
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@ItoddchouFX @selissia
Infineon CYW30739 - lighting-app support (project-chip#13491)
cf82b23
@turon
Copy link
Contributor

turon commented Jan 31, 2022 •
edited
Loading

May have introduced issue #14318.

@turon turon mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples fast track github lib lwip scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ItoddchouFX @andy31415 @turon @woody-apple @bzbarsky-apple