Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document mHoldSync and mHoldReport #13476

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Document mHoldSync and mHoldReport #13476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/app/ReadHandler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ class ReadHandler : public Messaging::ExchangeDelegate
uint16_t mMinIntervalFloorSeconds = 0;
uint16_t mMaxIntervalCeilingSeconds = 0;
SessionHolder mSessionHandle;
// mHoldReport is used to prevent subscription data delivery while we are
// waiting for the min reporting interval to elapse. If we have to send a
// report immediately due to an urgent event being queued,
// UnblockUrgentEventDelivery can be used to force mHoldReport to false.
bool mHoldReport = false;
bool mDirty = false;
bool mActiveSubscription = false;
Expand All @@ -226,8 +230,12 @@ class ReadHandler : public Messaging::ExchangeDelegate
NodeId mInitiatorNodeId = kUndefinedNodeId;
AttributePathExpandIterator mAttributePathExpandIterator = AttributePathExpandIterator(nullptr);
bool mIsFabricFiltered = false;
bool mHoldSync = false;
uint32_t mLastWrittenEventsBytes = 0;
// mHoldSync is used to prevent subscription empty report delivery while we
// are waiting for the max reporting interval to elaps. When mHoldSync
// becomes false, we are allowed to send an empty report to keep the
// subscription alive on the client.
bool mHoldSync = false;
uint32_t mLastWrittenEventsBytes = 0;
SubjectDescriptor mSubjectDescriptor;
// The detailed encoding state for a single attribute, used by list chunking feature.
AttributeValueEncoder::AttributeEncodeState mAttributeEncoderState;
Expand Down