Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Make cluster id a constant instead of a method #13469

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

austinh0
Copy link
Contributor

Problem

  • In Java clusters code, generated clusterId() can be a constant instead

Change overview

  • Change method to final long

Testing

  • Compiles (cluster id is not used by Android CHIPTool)

@github-actions
Copy link

github-actions bot commented Jan 11, 2022

PR #13469: Size comparison from f334c27 to a6076f8

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f334c27 a6076f8 change % change
efr32 lighting-app BRD4161A (read only) 830320 830320 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830312 830312 0 0.0
BRD4161A+rpc (read only) 817724 817724 0 0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817716 817716 0 0.0
window-app BRD4161A (read only) 804264 804264 0 0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804256 804256 0 0.0
esp32 all-clusters-app c3devkit (read only) 898344 898344 0 0.0
(read/write) 1316082 1316082 0 0.0
.dram0.bss 70168 70168 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178200 178200 0 0.0
.flash.text 898344 898344 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959459 959459 0 0.0
(read/write) 448536 448536 0 0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207688 207688 0 0.0
.flash.text 954075 954075 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656396 656396 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571920 571920 0 0.0
lock k32w061+release (read/write) 660736 660736 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575944 575944 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7183468 7183468 0 0.0
(read/write) 344625 344625 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 226744 226744 0 0.0
.dynamic 560 560 0 0.0
.got 58232 58232 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390308 390308 0 0.0
.text 6061988 6061988 0 0.0
thermostat-no-ble arm64 (read only) 2037500 2037500 0 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129276 129276 0 0.0
.text 1693920 1693920 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348976 2348976 0 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1311552 1311552 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330560 2330560 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293160 1293160 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303784 2303784 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266384 1266384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939327 939327 0 0.0
bss 119284 119284 0 0.0
rodata 108332 108332 0 0.0
text 634136 634136 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 924795 924795 0 0.0
bss 116328 116328 0 0.0
rodata 100784 100784 0 0.0
text 629488 629488 0 0.0
nrf52840dongle_nrf52840 (read/write) 989987 989987 0 0.0
bss 122128 122128 0 0.0
rodata 113084 113084 0 0.0
text 666332 666332 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849186 849186 0 0.0
bss 116072 116072 0 0.0
rodata 101508 101508 0 0.0
text 551056 551056 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911599 911599 0 0.0
bss 118472 118472 0 0.0
rodata 103604 103604 0 0.0
text 612128 612128 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821638 821638 0 0.0
bss 115288 115288 0 0.0
rodata 96832 96832 0 0.0
text 529088 529088 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912879 912879 0 0.0
bss 118232 118232 0 0.0
rodata 103820 103820 0 0.0
text 613388 613388 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909679 909679 0 0.0
bss 118260 118260 0 0.0
rodata 103076 103076 0 0.0
text 610876 610876 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798439 798439 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533880 533880 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711254 711254 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451560 451560 0 0.0
p6 all-clusters-app default (read/write) 2403264 2403264 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361528 1361528 0 0.0
light-app default (read/write) 2325152 2325152 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283416 1283416 0 0.0
lock-app default (read/write) 2297384 2297384 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255648 1255648 0 0.0
qpg lighting-app qpg6105+debug (read only) 534084 534084 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528764 528764 0 0.0
lock-app qpg6105+debug (read only) 506004 506004 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500684 500684 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835910 835910 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583782 583782 0 0.0

@andy31415
Copy link
Contributor

fast track: small delta, created by a domain owner.

@austinh0 austinh0 merged commit 5c2c4bd into project-chip:master Jan 11, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants