Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CommissioneeDeviceProxy state #13466

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Fix CommissioneeDeviceProxy state #13466

merged 2 commits into from
Jan 11, 2022

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Jan 11, 2022 •
edited
Loading

Problem

The pairing call was moved to external so the commissionee
device proxy never gets set to connected. LoadSecureSessionParameters
takes care of setting up the pairing in the session manager anyway, so it makes sense to call through the DeviceProxy.
Fixes #13431

Change overview

Added a new function that gets called when the pairing is complete
to set the state and setup the pairing in the session manager.

Testing

paseonly then commission in chip-device-ctrl

@cecille
Fix CommissioneeDeviceProxy state
a4b0aaa 
The pairing call was moved to external so the commissionee
device proxy never gets set to connected. LoadSecureSessionParameters
will take care of setting up the pairing in the session manager
so added a new function that gets called when the pairing is complete
to set the state and setup the pairing in the session manager.
@cecille cecille force-pushed the commissioning_after_pase branch from f9d7657 to a4b0aaa Compare January 11, 2022 20:30
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13466: Size comparison from ed95611 to a4b0aaa

Decreases (1 build for linux)
platform target config section ed95611 a4b0aaa change % change
linux chip-tool-ipv6only arm64 (read only) 7183436 7183292 -144 -0.0
.text 6061956 6061812 -144 -0.0
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section ed95611 a4b0aaa change % change
efr32 lighting-app BRD4161A (read only) 830256 830256 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830248 830248 0 0.0
BRD4161A+rpc (read only) 817660 817660 0 0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817652 817652 0 0.0
window-app BRD4161A (read only) 804200 804200 0 0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804192 804192 0 0.0
k32w light k32w061+release (read/write) 656380 656380 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571904 571904 0 0.0
lock k32w061+release (read/write) 660720 660720 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575928 575928 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7183436 7183292 -144 -0.0
(read/write) 344625 344625 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 226744 226744 0 0.0
.dynamic 560 560 0 0.0
.got 58232 58232 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390308 390308 0 0.0
.text 6061956 6061812 -144 -0.0
thermostat-no-ble arm64 (read only) 2037468 2037468 0 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129276 129276 0 0.0
.text 1693888 1693888 0 0.0
p6 all-clusters-app default (read/write) 2403200 2403200 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361464 1361464 0 0.0
light-app default (read/write) 2325088 2325088 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283352 1283352 0 0.0
lock-app default (read/write) 2297320 2297320 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255584 1255584 0 0.0
qpg lighting-app qpg6105+debug (read only) 534060 534060 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528740 528740 0 0.0
lock-app qpg6105+debug (read only) 505980 505980 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500660 500660 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 835878 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583752 583752 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13466: Size comparison from ed95611 to d110ac7

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ed95611 d110ac7 change % change
efr32 lighting-app BRD4161A (read only) 830256 830256 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830248 830248 0 0.0
BRD4161A+rpc (read only) 817660 817660 0 0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817652 817652 0 0.0
window-app BRD4161A (read only) 804200 804200 0 0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804192 804192 0 0.0
esp32 all-clusters-app c3devkit (read only) 898316 898316 0 0.0
(read/write) 1316082 1316082 0 0.0
.dram0.bss 70168 70168 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178200 178200 0 0.0
.flash.text 898316 898316 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959427 959427 0 0.0
(read/write) 448536 448536 0 0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207688 207688 0 0.0
.flash.text 954043 954043 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656380 656380 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571904 571904 0 0.0
lock k32w061+release (read/write) 660720 660720 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575928 575928 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7183436 7183436 0 0.0
(read/write) 344625 344625 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 226744 226744 0 0.0
.dynamic 560 560 0 0.0
.got 58232 58232 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390308 390308 0 0.0
.text 6061956 6061956 0 0.0
thermostat-no-ble arm64 (read only) 2037468 2037468 0 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129276 129276 0 0.0
.text 1693888 1693888 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348912 2348912 0 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1311488 1311488 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330560 2330560 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293160 1293160 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303784 2303784 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266384 1266384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939295 939295 0 0.0
bss 119284 119284 0 0.0
rodata 108332 108332 0 0.0
text 634112 634112 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 924763 924763 0 0.0
bss 116328 116328 0 0.0
rodata 100784 100784 0 0.0
text 629464 629464 0 0.0
nrf52840dongle_nrf52840 (read/write) 989971 989971 0 0.0
bss 122128 122128 0 0.0
rodata 113084 113084 0 0.0
text 666308 666308 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849154 849154 0 0.0
bss 116072 116072 0 0.0
rodata 101508 101508 0 0.0
text 551032 551032 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911567 911567 0 0.0
bss 118472 118472 0 0.0
rodata 103604 103604 0 0.0
text 612104 612104 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821606 821606 0 0.0
bss 115288 115288 0 0.0
rodata 96832 96832 0 0.0
text 529064 529064 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912863 912863 0 0.0
bss 118232 118232 0 0.0
rodata 103820 103820 0 0.0
text 613364 613364 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909647 909647 0 0.0
bss 118260 118260 0 0.0
rodata 103076 103076 0 0.0
text 610852 610852 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798423 798423 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533856 533856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711238 711238 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451536 451536 0 0.0
p6 all-clusters-app default (read/write) 2403200 2403200 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361464 1361464 0 0.0
light-app default (read/write) 2325088 2325088 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283352 1283352 0 0.0
lock-app default (read/write) 2297320 2297320 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255584 1255584 0 0.0
qpg lighting-app qpg6105+debug (read only) 534060 534060 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528740 528740 0 0.0
lock-app qpg6105+debug (read only) 505980 505980 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500660 500660 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 835878 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583752 583752 0 0.0

@andy31415
Copy link
Contributor

fast track: small delta, created by domain owner

@bzbarsky-apple bzbarsky-apple merged commit aaa7ad0 into project-chip:master Jan 11, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@cecille @selissia
Fix CommissioneeDeviceProxy state (project-chip#13466)
5ec6074 
* Fix CommissioneeDeviceProxy state

The pairing call was moved to external so the commissionee
device proxy never gets set to connected. LoadSecureSessionParameters
will take care of setting up the pairing in the session manager
so added a new function that gets called when the pairing is complete
to set the state and setup the pairing in the session manager.

* Address review comments.
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@cecille @step0035
Fix CommissioneeDeviceProxy state (project-chip#13466)
a7c67c2 
* Fix CommissioneeDeviceProxy state

The pairing call was moved to external so the commissionee
device proxy never gets set to connected. LoadSecureSessionParameters
will take care of setting up the pairing in the session manager
so added a new function that gets called when the pairing is complete
to set the state and setup the pairing in the session manager.

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller fast track review - pending
Projects
None yet
Milestone
No milestone
5 participants
@cecille @andy31415 @tcarmelveilleux @mrjerryjohns @bzbarsky-apple