Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change InteractionModel::Status to be 8-bit. #13463

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Change InteractionModel::Status to be 8-bit. #13463

merged 1 commit into from
Jan 11, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

This change is happening on the spec side in
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/4814

Problem

Harder to fit InteractionModel::Status into a CHIP_ERROR if it's 16-bit.

Change overview

Make InteractionModel::Status 8-bit.

Testing

Tree compiles. No behavior changes expected.

@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13463: Size comparison from 9f3493d to e41f2ac

Increases (16 builds for esp32, k32w, linux, mbed, nrfconnect, telink)
platform target config section 9f3493d e41f2ac change % change
esp32 all-clusters-app c3devkit (read/write) 1316082 1316090 8 0.0
.flash.rodata 178200 178208 8 0.0
m5stack (read/write) 448536 448544 8 0.0
.flash.rodata 207688 207696 8 0.0
k32w light k32w061+release (read/write) 656380 656388 8 0.0
.text 571904 571912 8 0.0
lock k32w061+release (read/write) 660720 660724 4 0.0
.text 575928 575932 4 0.0
linux chip-tool-ipv6only arm64 (read only) 7114060 7114556 496 0.0
.rodata 390148 390612 464 0.1
.text 6026020 6026052 32 0.0
thermostat-no-ble arm64 (read only) 2037468 2037756 288 0.0
.rodata 129276 129516 240 0.2
.text 1693888 1693936 48 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348912 2348920 8 0.0
.text 1311488 1311496 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 634112 634116 4 0.0
nrf52840dk_nrf52840+rpc text 629464 629468 4 0.0
nrf52840dongle_nrf52840 (read/write) 989971 989975 4 0.0
rodata 113084 113088 4 0.0
text 666308 666312 4 0.0
nrf5340dk_nrf5340_cpuapp text 551032 551036 4 0.0
lock-app nrf52840dk_nrf52840 text 612104 612108 4 0.0
nrf5340dk_nrf5340_cpuapp text 529064 529068 4 0.0
pump-app nrf52840dk_nrf52840 text 613364 613368 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 610852 610856 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 835882 4 0.0
Decreases (8 builds for efr32, esp32, p6)
platform target config section 9f3493d e41f2ac change % change
efr32 lighting-app BRD4161A (read only) 830256 830240 -16 -0.0
.text 830248 830232 -16 -0.0
BRD4161A+rpc (read only) 817660 817644 -16 -0.0
.text 817652 817636 -16 -0.0
window-app BRD4161A (read only) 804200 804184 -16 -0.0
.text 804192 804176 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 898316 898150 -166 -0.0
.flash.text 898316 898150 -166 -0.0
m5stack (read only) 959427 959319 -108 -0.0
.flash.text 954043 953935 -108 -0.0
p6 all-clusters-app default (read/write) 2403200 2403192 -8 -0.0
.text 1361464 1361456 -8 -0.0
light-app default (read/write) 2325088 2325080 -8 -0.0
.text 1283352 1283344 -8 -0.0
lock-app default (read/write) 2297320 2297312 -8 -0.0
.text 1255584 1255576 -8 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9f3493d e41f2ac change % change
efr32 lighting-app BRD4161A (read only) 830256 830240 -16 -0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830248 830232 -16 -0.0
BRD4161A+rpc (read only) 817660 817644 -16 -0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817652 817636 -16 -0.0
window-app BRD4161A (read only) 804200 804184 -16 -0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804192 804176 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 898316 898150 -166 -0.0
(read/write) 1316082 1316090 8 0.0
.dram0.bss 70168 70168 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178200 178208 8 0.0
.flash.text 898316 898150 -166 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959427 959319 -108 -0.0
(read/write) 448536 448544 8 0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207688 207696 8 0.0
.flash.text 954043 953935 -108 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656380 656388 8 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571904 571912 8 0.0
lock k32w061+release (read/write) 660720 660724 4 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575928 575932 4 0.0
linux chip-tool-ipv6only arm64 (read only) 7114060 7114556 496 0.0
(read/write) 327473 327473 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209624 209624 0 0.0
.dynamic 560 560 0 0.0
.got 58208 58208 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390148 390612 464 0.1
.text 6026020 6026052 32 0.0
thermostat-no-ble arm64 (read only) 2037468 2037756 288 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129276 129516 240 0.2
.text 1693888 1693936 48 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348912 2348920 8 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1311488 1311496 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330560 2330560 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293160 1293160 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303784 2303784 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266384 1266384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939295 939295 0 0.0
bss 119284 119284 0 0.0
rodata 108332 108332 0 0.0
text 634112 634116 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 924763 924763 0 0.0
bss 116328 116328 0 0.0
rodata 100784 100784 0 0.0
text 629464 629468 4 0.0
nrf52840dongle_nrf52840 (read/write) 989971 989975 4 0.0
bss 122128 122128 0 0.0
rodata 113084 113088 4 0.0
text 666308 666312 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849154 849154 0 0.0
bss 116072 116072 0 0.0
rodata 101508 101508 0 0.0
text 551032 551036 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911567 911567 0 0.0
bss 118472 118472 0 0.0
rodata 103604 103604 0 0.0
text 612104 612108 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821606 821606 0 0.0
bss 115288 115288 0 0.0
rodata 96832 96832 0 0.0
text 529064 529068 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912863 912863 0 0.0
bss 118232 118232 0 0.0
rodata 103820 103820 0 0.0
text 613364 613368 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909647 909647 0 0.0
bss 118260 118260 0 0.0
rodata 103076 103076 0 0.0
text 610852 610856 4 0.0
shell nrf52840dk_nrf52840 (read/write) 798423 798423 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533856 533856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711238 711238 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451536 451536 0 0.0
p6 all-clusters-app default (read/write) 2403200 2403192 -8 -0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361464 1361456 -8 -0.0
light-app default (read/write) 2325088 2325080 -8 -0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283352 1283344 -8 -0.0
lock-app default (read/write) 2297320 2297312 -8 -0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255584 1255576 -8 -0.0
qpg lighting-app qpg6105+debug (read only) 534060 534060 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528740 528740 0 0.0
lock-app qpg6105+debug (read only) 505980 505980 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500660 500660 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 835882 4 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583752 583752 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 535a7d8 into project-chip:master Jan 11, 2022
@bzbarsky-apple bzbarsky-apple deleted the status-8-bit branch January 11, 2022 22:00
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Change InteractionModel::Status to be 8-bit. (project-chip#13463)
6c05cfa 
This change is happening on the spec side in
CHIP-Specifications/connectedhomeip-spec#4814
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@bzbarsky-apple @step0035
Change InteractionModel::Status to be 8-bit. (project-chip#13463)
4ed748e 
This change is happening on the spec side in
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/4814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhst saurabhst saurabhst approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 andy31415 approved these changes

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @mrjerryjohns @saurabhst