Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all-clusters-app: Disable OTA Provider Server #13454

Merged
merged 4 commits into from
Jan 12, 2022
Merged

all-clusters-app: Disable OTA Provider Server #13454

merged 4 commits into from
Jan 12, 2022

Conversation

shubhamdp
Copy link
Contributor

Problem

ZAP CI in non determinism due co existence of OTA provider client and server in same app

Change overview

Having same cluster's client and server in same app is not supported in the zap.
Disabled OTA provider server from all-clusters-app. So, that OTA requestor functionality can work.

Testing

  • CI should be all green
  • Tested ESP32 OTA Requestor in all-clusters-app and Linux OTA Provider app

@shubhamdp shubhamdp mentioned this pull request Jan 11, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13454: Size comparison from f1e33cc to 71326a3

Decreases (1 build for p6)
platform target config section f1e33cc 71326a3 change % change
p6 all-clusters-app default (read/write) 2402888 2401096 -1792 -0.1
.bss 117148 117140 -8 -0.0
.text 1361152 1359360 -1792 -0.1
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section f1e33cc 71326a3 change % change
efr32 lighting-app BRD4161A (read only) 829972 829972 0 0.0
(read/write) 127056 127056 0 0.0
.bss 125176 125176 0 0.0
.data 1880 1880 0 0.0
.text 829964 829964 0 0.0
BRD4161A+rpc (read only) 817168 817168 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141736 141736 0 0.0
.data 1980 1980 0 0.0
.text 817160 817160 0 0.0
window-app BRD4161A (read only) 803436 803436 0 0.0
(read/write) 125996 125996 0 0.0
.bss 124160 124160 0 0.0
.data 1836 1836 0 0.0
.text 803428 803428 0 0.0
k32w light k32w061+release (read/write) 656148 656148 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571672 571672 0 0.0
lock k32w061+release (read/write) 660488 660488 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575696 575696 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7113260 7113260 0 0.0
(read/write) 327377 327377 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209544 209544 0 0.0
.dynamic 560 560 0 0.0
.got 58184 58184 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390132 390132 0 0.0
.text 6025556 6025556 0 0.0
thermostat-no-ble arm64 (read only) 2036652 2036652 0 0.0
(read/write) 145409 145409 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72832 72832 0 0.0
.dynamic 560 560 0 0.0
.got 4016 4016 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129244 129244 0 0.0
.text 1693424 1693424 0 0.0
p6 all-clusters-app default (read/write) 2402888 2401096 -1792 -0.1
.bss 117148 117140 -8 -0.0
.data 2592 2592 0 0.0
.text 1361152 1359360 -1792 -0.1
light-app default (read/write) 2324800 2324800 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283064 1283064 0 0.0
lock-app default (read/write) 2297024 2297024 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255288 1255288 0 0.0
qpg lighting-app qpg6105+debug (read only) 533852 533852 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528532 528532 0 0.0
lock-app qpg6105+debug (read only) 505772 505772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500452 500452 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835562 835562 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583540 583540 0 0.0

@shubhamdp shubhamdp mentioned this pull request Jan 11, 2022
Merged
@shubhamdp shubhamdp force-pushed the remove_ota_provider_server_all_clusters_app branch from 1708c0d to a9a839f Compare January 11, 2022 15:45
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13454: Size comparison from 79530ef to a9a839f

Decreases (3 builds for esp32, p6)
platform target config section 79530ef a9a839f change % change
esp32 all-clusters-app c3devkit (read only) 898260 896952 -1308 -0.1
(read/write) 1316042 1315538 -504 -0.0
.dram0.bss 70168 70160 -8 -0.0
.flash.rodata 178160 177672 -488 -0.3
.flash.text 898260 896952 -1308 -0.1
m5stack (read only) 959367 958171 -1196 -0.1
(read/write) 448504 448040 -464 -0.1
.flash.rodata 207656 207192 -464 -0.2
.flash.text 953983 952787 -1196 -0.1
p6 all-clusters-app default (read/write) 2403088 2401304 -1784 -0.1
.bss 117148 117140 -8 -0.0
.text 1361352 1359568 -1784 -0.1
Full report (25 builds for efr32, esp32, k32w, nrfconnect, p6, qpg, telink)
platform target config section 79530ef a9a839f change % change
efr32 lighting-app BRD4161A (read only) 830148 830148 0 0.0
(read/write) 127056 127056 0 0.0
.bss 125176 125176 0 0.0
.data 1880 1880 0 0.0
.text 830140 830140 0 0.0
BRD4161A+rpc (read only) 817344 817344 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141736 141736 0 0.0
.data 1980 1980 0 0.0
.text 817336 817336 0 0.0
window-app BRD4161A (read only) 803612 803612 0 0.0
(read/write) 125996 125996 0 0.0
.bss 124160 124160 0 0.0
.data 1836 1836 0 0.0
.text 803604 803604 0 0.0
esp32 all-clusters-app c3devkit (read only) 898260 896952 -1308 -0.1
(read/write) 1316042 1315538 -504 -0.0
.dram0.bss 70168 70160 -8 -0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178160 177672 -488 -0.3
.flash.text 898260 896952 -1308 -0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959367 958171 -1196 -0.1
(read/write) 448504 448040 -464 -0.1
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207656 207192 -464 -0.2
.flash.text 953983 952787 -1196 -0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656260 656260 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571784 571784 0 0.0
lock k32w061+release (read/write) 660600 660600 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575808 575808 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939179 939179 0 0.0
bss 119284 119284 0 0.0
rodata 108296 108296 0 0.0
text 634036 634036 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 924659 924659 0 0.0
bss 116328 116328 0 0.0
rodata 100744 100744 0 0.0
text 629392 629392 0 0.0
nrf52840dongle_nrf52840 (read/write) 989855 989855 0 0.0
bss 122128 122128 0 0.0
rodata 113048 113048 0 0.0
text 666236 666236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849050 849050 0 0.0
bss 116072 116072 0 0.0
rodata 101468 101468 0 0.0
text 550960 550960 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911467 911467 0 0.0
bss 118472 118472 0 0.0
rodata 103568 103568 0 0.0
text 612032 612032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821502 821502 0 0.0
bss 115288 115288 0 0.0
rodata 96792 96792 0 0.0
text 528996 528996 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912743 912743 0 0.0
bss 118232 118232 0 0.0
rodata 103780 103780 0 0.0
text 613292 613292 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909547 909547 0 0.0
bss 118260 118260 0 0.0
rodata 103040 103040 0 0.0
text 610784 610784 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798303 798303 0 0.0
bss 109776 109776 0 0.0
rodata 78244 78244 0 0.0
text 533788 533788 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711122 711122 0 0.0
bss 107664 107664 0 0.0
rodata 72548 72548 0 0.0
text 451464 451464 0 0.0
p6 all-clusters-app default (read/write) 2403088 2401304 -1784 -0.1
.bss 117148 117140 -8 -0.0
.data 2592 2592 0 0.0
.text 1361352 1359568 -1784 -0.1
light-app default (read/write) 2325000 2325000 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283264 1283264 0 0.0
lock-app default (read/write) 2297208 2297208 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255472 1255472 0 0.0
qpg lighting-app qpg6105+debug (read only) 533964 533964 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528644 528644 0 0.0
lock-app qpg6105+debug (read only) 505884 505884 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500564 500564 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835790 835790 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583698 583698 0 0.0

tima-q added a commit to tima-q/connectedhomeip that referenced this pull request Jan 11, 2022
@tima-q
updating to remove OTA Provider from all-clusters-app - aligning with p…
c383a56 
…roject-chip#13454
@shubhamdp shubhamdp force-pushed the remove_ota_provider_server_all_clusters_app branch from 0b34729 to c8f84de Compare January 12, 2022 04:01
@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR #13454: Size comparison from 6e7ad99 to c8f84de

Decreases (4 builds for esp32, mbed, p6)
platform target config section 6e7ad99 c8f84de change % change
esp32 all-clusters-app c3devkit (read only) 896762 895454 -1308 -0.1
(read/write) 1316074 1315570 -504 -0.0
.dram0.bss 70168 70160 -8 -0.0
.flash.rodata 178192 177704 -488 -0.3
.flash.text 896762 895454 -1308 -0.1
m5stack (read only) 958023 956811 -1212 -0.1
(read/write) 448528 448064 -464 -0.1
.flash.rodata 207680 207216 -464 -0.2
.flash.text 952639 951427 -1212 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2347392 2345776 -1616 -0.1
.bss 188876 188868 -8 -0.0
.text 1309968 1308352 -1616 -0.1
p6 all-clusters-app default (read/write) 2401448 2399656 -1792 -0.1
.bss 117148 117140 -8 -0.0
.text 1359712 1357920 -1792 -0.1
Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6e7ad99 c8f84de change % change
efr32 lighting-app BRD4161A (read only) 830532 830532 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830524 830524 0 0.0
BRD4161A+rpc (read only) 817936 817936 0 0.0
(read/write) 143964 143964 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817928 817928 0 0.0
window-app BRD4161A (read only) 804492 804492 0 0.0
(read/write) 126004 126004 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804484 804484 0 0.0
esp32 all-clusters-app c3devkit (read only) 896762 895454 -1308 -0.1
(read/write) 1316074 1315570 -504 -0.0
.dram0.bss 70168 70160 -8 -0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178192 177704 -488 -0.3
.flash.text 896762 895454 -1308 -0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 958023 956811 -1212 -0.1
(read/write) 448528 448064 -464 -0.1
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207680 207216 -464 -0.2
.flash.text 952639 951427 -1212 -0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656644 656644 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572168 572168 0 0.0
lock k32w061+release (read/write) 660980 660980 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576188 576188 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347392 2345776 -1616 -0.1
.bss 188876 188868 -8 -0.0
.data 5320 5320 0 0.0
.text 1309968 1308352 -1616 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330808 2330808 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293408 1293408 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304032 2304032 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266632 1266632 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939555 939555 0 0.0
bss 119284 119284 0 0.0
rodata 108448 108448 0 0.0
text 634256 634256 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 925023 925023 0 0.0
bss 116328 116328 0 0.0
rodata 100900 100900 0 0.0
text 629608 629608 0 0.0
nrf52840dongle_nrf52840 (read/write) 990231 990231 0 0.0
bss 122128 122128 0 0.0
rodata 113200 113200 0 0.0
text 666452 666452 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849414 849414 0 0.0
bss 116072 116072 0 0.0
rodata 101624 101624 0 0.0
text 551176 551176 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911827 911827 0 0.0
bss 118472 118472 0 0.0
rodata 103720 103720 0 0.0
text 612248 612248 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821866 821866 0 0.0
bss 115288 115288 0 0.0
rodata 96948 96948 0 0.0
text 529208 529208 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913123 913123 0 0.0
bss 118232 118232 0 0.0
rodata 103936 103936 0 0.0
text 613508 613508 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909907 909907 0 0.0
bss 118260 118260 0 0.0
rodata 103192 103192 0 0.0
text 610996 610996 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798439 798439 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533880 533880 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711254 711254 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451560 451560 0 0.0
p6 all-clusters-app default (read/write) 2401448 2399656 -1792 -0.1
.bss 117148 117140 -8 -0.0
.data 2592 2592 0 0.0
.text 1359712 1357920 -1792 -0.1
light-app default (read/write) 2325392 2325392 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283656 1283656 0 0.0
lock-app default (read/write) 2297616 2297616 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255880 1255880 0 0.0
qpg lighting-app qpg6105+debug (read only) 534308 534308 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528988 528988 0 0.0
lock-app qpg6105+debug (read only) 506228 506228 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500908 500908 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836158 836158 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583910 583910 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 7948da7 into project-chip:master Jan 12, 2022
@shubhamdp shubhamdp deleted the remove_ota_provider_server_all_clusters_app branch January 12, 2022 05:27
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@shubhamdp @selissia
all-clusters-app: Disable OTA Provider Server (project-chip#13454)
de4b724 
* all-clusters-app: Disable OTA Provider Server

Having same cluster's client and server in same app is not supported in
the zap. Removed OTA provider server from all-clusters-app

* Remove OTA Provider server test cases

* Remove OTA Provider files from all-clusters-app/mbed CMakeLists.txt

* Disable OtaSoftwareUpdateProvider cluster tests for Darwin
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@shubhamdp @step0035
all-clusters-app: Disable OTA Provider Server (project-chip#13454)
0e7e4d0 
* all-clusters-app: Disable OTA Provider Server

Having same cluster's client and server in same app is not supported in
the zap. Removed OTA provider server from all-clusters-app

* Remove OTA Provider server test cases

* Remove OTA Provider files from all-clusters-app/mbed CMakeLists.txt

* Disable OtaSoftwareUpdateProvider cluster tests for Darwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@tima-q tima-q tima-q approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shubhamdp @andy31415 @dhrishi @tima-q @Damian-Nordic @bzbarsky-apple