Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share more code between examples/chip-tool and examples/placeholder #13452

Conversation

vivien-apple
Copy link
Contributor

Problem

Both examples/chip-tool and examples/palceholder are used as YAML test runners. Some of the YAML methods are replicated in both.

examples/chip-tool/templates/partials/test_cluster.zapt

Change overview

  • Share more between both by adding it to src/app/tests/suites/
  • Update generated test content (this is the only reason for the line count increase)

Testing

There is no feature changes. Just more code sharing.

…ds signature living into TestCommand.h

Use CharSpan instead of Span<const char> and add a few const prefix
@github-actions
Copy link

github-actions bot commented Jan 11, 2022

PR #13452: Size comparison from a841e21 to 74ccfee

Increases above 0.2%:

platform target config section a841e21 74ccfee change % change
linux chip-tool-ipv6only arm64 (read only) 7113260 7182636 69376 1.0
(read/write) 327377 344513 17136 5.2
.data.rel.ro 209544 226664 17120 8.2
.text 6025556 6061492 35936 0.6
Increases (1 build for linux)
platform target config section a841e21 74ccfee change % change
linux chip-tool-ipv6only arm64 (read only) 7113260 7182636 69376 1.0
(read/write) 327377 344513 17136 5.2
.data.rel.ro 209544 226664 17120 8.2
.got 58184 58208 24 0.0
.rodata 390132 390276 144 0.0
.text 6025556 6061492 35936 0.6
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section a841e21 74ccfee change % change
efr32 lighting-app BRD4161A (read only) 829972 829972 0 0.0
(read/write) 127056 127056 0 0.0
.bss 125176 125176 0 0.0
.data 1880 1880 0 0.0
.text 829964 829964 0 0.0
BRD4161A+rpc (read only) 817168 817168 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141736 141736 0 0.0
.data 1980 1980 0 0.0
.text 817160 817160 0 0.0
window-app BRD4161A (read only) 803436 803436 0 0.0
(read/write) 125996 125996 0 0.0
.bss 124160 124160 0 0.0
.data 1836 1836 0 0.0
.text 803428 803428 0 0.0
esp32 all-clusters-app c3devkit (read only) 892608 892608 0 0.0
(read/write) 1314786 1314786 0 0.0
.dram0.bss 69824 69824 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 177656 177656 0 0.0
.flash.text 892608 892608 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 952483 952483 0 0.0
(read/write) 446360 446360 0 0.0
.dram0.bss 74304 74304 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206984 206984 0 0.0
.flash.text 947099 947099 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 656148 656148 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571672 571672 0 0.0
lock k32w061+release (read/write) 660488 660488 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575696 575696 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7113260 7182636 69376 1.0
(read/write) 327377 344513 17136 5.2
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209544 226664 17120 8.2
.dynamic 560 560 0 0.0
.got 58184 58208 24 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390132 390276 144 0.0
.text 6025556 6061492 35936 0.6
thermostat-no-ble arm64 (read only) 2036572 2036572 0 0.0
(read/write) 145377 145377 0 0.0
.bss 64721 64721 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72832 72832 0 0.0
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129244 129244 0 0.0
.text 1693360 1693360 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349496 2349496 0 0.0
.bss 189068 189068 0 0.0
.data 5320 5320 0 0.0
.text 1312072 1312072 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331144 2331144 0 0.0
.bss 180600 180600 0 0.0
.data 5552 5552 0 0.0
.text 1293744 1293744 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304432 2304432 0 0.0
.bss 179648 179648 0 0.0
.data 5544 5544 0 0.0
.text 1267032 1267032 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054432 2054432 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1017032 1017032 0 0.0
p6 all-clusters-app default (read/write) 2402808 2402808 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361072 1361072 0 0.0
light-app default (read/write) 2324800 2324800 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283064 1283064 0 0.0
lock-app default (read/write) 2297024 2297024 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255288 1255288 0 0.0
qpg lighting-app qpg6105+debug (read only) 533852 533852 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528532 528532 0 0.0
lock-app qpg6105+debug (read only) 505772 505772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500452 500452 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835562 835562 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583540 583540 0 0.0

@vivien-apple vivien-apple changed the title Chip tool placeholder common content Share more code between examples/chip-tool and examples/placeholder Jan 11, 2022
@woody-apple woody-apple merged commit ed95611 into project-chip:master Jan 11, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
…roject-chip#13452)

* [chip-tool] Create ValueChecker.h and ConstraintsChecker.h from methods signature living into TestCommand.h

Use CharSpan instead of Span<const char> and add a few const prefix

* Move ValueChecker.h and ConstraintsChecker.h to src/app/tests/suites/include

* [chip-tool] Create LogCommands class and move it under src/app/tests/suites/commands/log

* Use LogCommands from src/app/tests/suites/commands/log into examples/placeholder instead of a custom implementation

* [chip-tool] Add src/app/tests/suites/include/PICSChecker.h and use it into examples/chip-tool and examples/placeholder

* Update generated test content
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
…roject-chip#13452)

* [chip-tool] Create ValueChecker.h and ConstraintsChecker.h from methods signature living into TestCommand.h

Use CharSpan instead of Span<const char> and add a few const prefix

* Move ValueChecker.h and ConstraintsChecker.h to src/app/tests/suites/include

* [chip-tool] Create LogCommands class and move it under src/app/tests/suites/commands/log

* Use LogCommands from src/app/tests/suites/commands/log into examples/placeholder instead of a custom implementation

* [chip-tool] Add src/app/tests/suites/include/PICSChecker.h and use it into examples/chip-tool and examples/placeholder

* Update generated test content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants