-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share more code between examples/chip-tool and examples/placeholder #13452
Merged
woody-apple
merged 6 commits into
project-chip:master
from
vivien-apple:ChipTool_Placeholder_CommonContent
Jan 11, 2022
Merged
Share more code between examples/chip-tool and examples/placeholder #13452
woody-apple
merged 6 commits into
project-chip:master
from
vivien-apple:ChipTool_Placeholder_CommonContent
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds signature living into TestCommand.h Use CharSpan instead of Span<const char> and add a few const prefix
…suites/commands/log
…placeholder instead of a custom implementation
… into examples/chip-tool and examples/placeholder
vivien-apple
force-pushed
the
ChipTool_Placeholder_CommonContent
branch
from
January 11, 2022 13:24
31ed97d
to
74ccfee
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248 and
holbrookt
January 11, 2022 13:25
pullapprove
bot
requested review from
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple and
xylophone21
January 11, 2022 13:25
PR #13452: Size comparison from a841e21 to 74ccfee Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
vivien-apple
changed the title
Chip tool placeholder common content
Share more code between examples/chip-tool and examples/placeholder
Jan 11, 2022
bzbarsky-apple
approved these changes
Jan 11, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…roject-chip#13452) * [chip-tool] Create ValueChecker.h and ConstraintsChecker.h from methods signature living into TestCommand.h Use CharSpan instead of Span<const char> and add a few const prefix * Move ValueChecker.h and ConstraintsChecker.h to src/app/tests/suites/include * [chip-tool] Create LogCommands class and move it under src/app/tests/suites/commands/log * Use LogCommands from src/app/tests/suites/commands/log into examples/placeholder instead of a custom implementation * [chip-tool] Add src/app/tests/suites/include/PICSChecker.h and use it into examples/chip-tool and examples/placeholder * Update generated test content
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…roject-chip#13452) * [chip-tool] Create ValueChecker.h and ConstraintsChecker.h from methods signature living into TestCommand.h Use CharSpan instead of Span<const char> and add a few const prefix * Move ValueChecker.h and ConstraintsChecker.h to src/app/tests/suites/include * [chip-tool] Create LogCommands class and move it under src/app/tests/suites/commands/log * Use LogCommands from src/app/tests/suites/commands/log into examples/placeholder instead of a custom implementation * [chip-tool] Add src/app/tests/suites/include/PICSChecker.h and use it into examples/chip-tool and examples/placeholder * Update generated test content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Both
examples/chip-tool
andexamples/palceholder
are used as YAML test runners. Some of the YAML methods are replicated in both.examples/chip-tool/templates/partials/test_cluster.zapt
Change overview
src/app/tests/suites/
Testing
There is no feature changes. Just more code sharing.