Add additional commissioning bindings to support BLE/IP auto-commissioning #13427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-coppock
force-pushed
the
pr/g-coppock/fix_android_bindings
branch
from
83664d5 to
cb28386
Compare
|
PR #13427: Size comparison from 19f61eb to cb28386 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
austinh0
approved these changes
Jan 11, 2022
…oning 1. Fixes a bug in ApplyNetworkCredentials, where the Wi-Fi objects were being referenced instead of the Thread objects. Additionally, added an exit block and ensured this method passes successfully before continuing on to Commission(). 2. Added a binding for establishPaseSession to support IP commissioning. 3. Added a binding for Commission, which is in addition to the existing PairDevice binding. This is needed when PASE establishment happens separately from commissioning initiation.
g-coppock
force-pushed
the
pr/g-coppock/fix_android_bindings
branch
from
cb28386 to
5be008e
Compare
|
fast track: java only change, approved by a domain owner, had sufficient time for cross-platform review. |
|
PR #13427: Size comparison from 79530ef to 5be008e Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…oning (project-chip#13427) 1. Fixes a bug in ApplyNetworkCredentials, where the Wi-Fi objects were being referenced instead of the Thread objects. Additionally, added an exit block and ensured this method passes successfully before continuing on to Commission(). 2. Added a binding for establishPaseSession to support IP commissioning. 3. Added a binding for Commission, which is in addition to the existing PairDevice binding. This is needed when PASE establishment happens separately from commissioning initiation.
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…oning (project-chip#13427) 1. Fixes a bug in ApplyNetworkCredentials, where the Wi-Fi objects were being referenced instead of the Thread objects. Additionally, added an exit block and ensured this method passes successfully before continuing on to Commission(). 2. Added a binding for establishPaseSession to support IP commissioning. 3. Added a binding for Commission, which is in addition to the existing PairDevice binding. This is needed when PASE establishment happens separately from commissioning initiation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in ApplyNetworkCredentials, where the Wi-Fi objects were
being referenced instead of the Thread objects. Additionally, added
an exit block and ensured this method passes successfully before
continuing on to Commission().
Added a binding for establishPaseSession to support IP commissioning.
Added a binding for Commission, which is in addition to the existing
PairDevice binding. This is needed when PASE establishment happens
separately from commissioning initiation.
Testing
Tested bindings manually by establishing a PASE connection to an nRF52840 and running the Commission() step.