Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shell to build_examples for host #13426

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Add shell to build_examples for host #13426

merged 3 commits into from
Jan 11, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Need to have build_examples be able to build as much as possible.

Change overview

Add shell builds to build_example.

Testing

Manually compiled, CI also validates.

@github-actions
Copy link

github-actions bot commented Jan 10, 2022 •
edited
Loading

PR #13426: Size comparison from 7d2771f to 3ece84e

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7d2771f7 3ece84e change % change
efr32 lighting-app BRD4161A (read only) 828900 828900 0 0.0
(read/write) 126996 126996 0 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 828892 828892 0 0.0
BRD4161A+rpc (read only) 816112 816112 0 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816104 816104 0 0.0
window-app BRD4161A (read only) 802364 802364 0 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802356 802356 0 0.0
esp32 all-clusters-app c3devkit (read only) 890352 890352 0 0.0
(read/write) 1313594 1313594 0 0.0
.dram0.bss 69472 69472 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176816 176816 0 0.0
.flash.text 890352 890352 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 950515 950515 0 0.0
(read/write) 445204 445204 0 0.0
.dram0.bss 73968 73968 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206164 206164 0 0.0
.flash.text 945131 945131 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655316 655316 0 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570892 570892 0 0.0
lock k32w061+release (read/write) 659640 659640 0 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574900 574900 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7105180 7105180 0 0.0
(read/write) 327041 327041 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209264 209264 0 0.0
.dynamic 560 560 0 0.0
.got 58136 58136 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 389860 389860 0 0.0
.text 6018468 6018468 0 0.0
thermostat-no-ble arm64 (read only) 2031916 2031916 0 0.0
(read/write) 145137 145137 0 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72656 72656 0 0.0
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 129004 129004 0 0.0
.text 1689136 1689136 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346760 2346760 0 0.0
.bss 188716 188716 0 0.0
.data 5312 5312 0 0.0
.text 1309336 1309336 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330496 2330496 0 0.0
.bss 180544 180544 0 0.0
.data 5552 5552 0 0.0
.text 1293096 1293096 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303648 2303648 0 0.0
.bss 179592 179592 0 0.0
.data 5544 5544 0 0.0
.text 1266248 1266248 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054432 2054432 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1017032 1017032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 938271 938271 0 0.0
bss 119232 119232 0 0.0
rodata 108156 108156 0 0.0
text 633336 633336 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 923735 923735 0 0.0
bss 116276 116276 0 0.0
rodata 100604 100604 0 0.0
text 628688 628688 0 0.0
nrf52840dongle_nrf52840 (read/write) 988947 988947 0 0.0
bss 122076 122076 0 0.0
rodata 112908 112908 0 0.0
text 665532 665532 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848142 848142 0 0.0
bss 116020 116020 0 0.0
rodata 101328 101328 0 0.0
text 550260 550260 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910415 910415 0 0.0
bss 118420 118420 0 0.0
rodata 103428 103428 0 0.0
text 611200 611200 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820498 820498 0 0.0
bss 115236 115236 0 0.0
rodata 96652 96652 0 0.0
text 528164 528164 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 911691 911691 0 0.0
bss 118180 118180 0 0.0
rodata 103640 103640 0 0.0
text 612412 612412 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908495 908495 0 0.0
bss 118208 118208 0 0.0
rodata 102900 102900 0 0.0
text 609948 609948 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798063 798063 0 0.0
bss 109768 109768 0 0.0
rodata 78180 78180 0 0.0
text 533608 533608 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 710882 0 0.0
bss 107656 107656 0 0.0
rodata 72484 72484 0 0.0
text 451288 451288 0 0.0
p6 all-clusters-app default (read/write) 2399648 2399648 0 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1357912 1357912 0 0.0
light-app default (read/write) 2323728 2323728 0 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1281992 1281992 0 0.0
lock-app default (read/write) 2295952 2295952 0 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254216 1254216 0 0.0
qpg lighting-app qpg6105+debug (read only) 533200 533200 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527880 527880 0 0.0
lock-app qpg6105+debug (read only) 504976 504976 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499656 499656 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834550 834550 0 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582760 582760 0 0.0

@andy31415
Copy link
Contributor Author

fast track: build infrastructure change, has been up for sufficient time for cross timezone review.

@andy31415 andy31415 merged commit 781f540 into project-chip:master Jan 11, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@andy31415 @selissia
Add shell to build_examples for host (project-chip#13426)
9646678 
* Add shell to build_examples for host

* Update unit tests

* Fix naming for app: chip-shell instead of chip-shell-app
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@andy31415 @step0035
Add shell to build_examples for host (project-chip#13426)
14c1227 
* Add shell to build_examples for host

* Update unit tests

* Fix naming for app: chip-shell instead of chip-shell-app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turon turon turon approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @turon