Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ActiveLocale in ConfigurationMgr #13403

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add support for ActiveLocale in ConfigurationMgr #13403

merged 1 commit into from
Jan 10, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Need new config key ActiveLocale for localization configuration cluster.

Change overview

Add support for ActiveLocale in ConfigurationMgr

Testing

How was this tested? (at least one bullet point required)

  • Covered by the new added unit test case 'TestConfigurationMgr_ActiveLocale'

@github-actions
Copy link

github-actions bot commented Jan 10, 2022 •
edited
Loading

PR #13403: Size comparison from b7ff37e to a304222

Increases (10 builds for k32w, linux, p6, qpg, telink)
platform target config section b7ff37e a304222 change % change
k32w light k32w061+release (read/write) 655324 655380 56 0.0
.text 570900 570956 56 0.0
lock k32w061+release (read/write) 659632 659688 56 0.0
.text 574892 574948 56 0.0
linux chip-tool-ipv6only arm64 (read only) 7105148 7105452 304 0.0
(read/write) 327009 327041 32 0.0
.data.rel.ro 209392 209424 32 0.0
.got 57968 57976 8 0.0
.rodata 388884 388900 16 0.0
.text 6019716 6019892 176 0.0
thermostat-no-ble arm64 (read only) 2033868 2034188 320 0.0
(read/write) 145089 145137 48 0.0
.data.rel.ro 72624 72656 32 0.0
.got 4000 4008 8 0.2
.rodata 128988 129004 16 0.0
.text 1691232 1691408 176 0.0
p6 all-clusters-app default (read/write) 2401656 2401784 128 0.0
.text 1359920 1360048 128 0.0
light-app default (read/write) 2323680 2323808 128 0.0
.text 1281944 1282072 128 0.0
lock-app default (read/write) 2295904 2296032 128 0.0
.text 1254168 1254296 128 0.0
qpg lighting-app qpg6105+debug (read only) 533192 533240 48 0.0
.text 527872 527920 48 0.0
lock-app qpg6105+debug (read only) 504968 505016 48 0.0
.text 499648 499696 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 834522 834606 84 0.0
text 582766 582816 50 0.0
Full report (11 builds for k32w, linux, p6, qpg, telink)
platform target config section b7ff37e a304222 change % change
k32w light k32w061+release (read/write) 655324 655380 56 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570900 570956 56 0.0
lock k32w061+release (read/write) 659632 659688 56 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574892 574948 56 0.0
linux chip-tool-ipv6only arm64 (read only) 7105148 7105452 304 0.0
(read/write) 327009 327041 32 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209392 209424 32 0.0
.dynamic 560 560 0 0.0
.got 57968 57976 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 388884 388900 16 0.0
.text 6019716 6019892 176 0.0
thermostat-no-ble arm64 (read only) 2033868 2034188 320 0.0
(read/write) 145089 145137 48 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72656 32 0.0
.dynamic 560 560 0 0.0
.got 4000 4008 8 0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 129004 16 0.0
.text 1691232 1691408 176 0.0
p6 all-clusters-app default (read/write) 2401656 2401784 128 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1359920 1360048 128 0.0
light-app default (read/write) 2323680 2323808 128 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1282072 128 0.0
lock-app default (read/write) 2295904 2296032 128 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254168 1254296 128 0.0
qpg lighting-app qpg6105+debug (read only) 533192 533240 48 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527872 527920 48 0.0
lock-app qpg6105+debug (read only) 504968 505016 48 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499648 499696 48 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834522 834606 84 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582766 582816 50 0.0

@github-actions
Copy link

github-actions bot commented Jan 10, 2022 •
edited
Loading

PR #13403: Size comparison from b7ff37e to d37e0c4

Increases (26 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b7ff37e d37e0c4 change % change
efr32 lighting-app BRD4161A (read only) 829244 829316 72 0.0
.text 829236 829308 72 0.0
BRD4161A+rpc (read only) 816888 816960 72 0.0
.text 816880 816952 72 0.0
window-app BRD4161A (read only) 802692 802780 88 0.0
.text 802684 802772 88 0.0
k32w light k32w061+release (read/write) 655324 655380 56 0.0
.text 570900 570956 56 0.0
lock k32w061+release (read/write) 659632 659688 56 0.0
.text 574892 574948 56 0.0
linux chip-tool-ipv6only arm64 (read only) 7105148 7105452 304 0.0
(read/write) 327009 327041 32 0.0
.data.rel.ro 209392 209424 32 0.0
.got 57968 57976 8 0.0
.rodata 388884 388900 16 0.0
.text 6019716 6019892 176 0.0
thermostat-no-ble arm64 (read only) 2033868 2034188 320 0.0
(read/write) 145089 145137 48 0.0
.data.rel.ro 72624 72656 32 0.0
.got 4000 4008 8 0.2
.rodata 128988 129004 16 0.0
.text 1691232 1691408 176 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348560 2348664 104 0.0
.text 1311136 1311240 104 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330752 2330792 40 0.0
.text 1293352 1293392 40 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2303904 2303944 40 0.0
.text 1266504 1266544 40 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054256 2054368 112 0.0
.text 1016856 1016968 112 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937115 937199 84 0.0
rodata 108120 108156 36 0.0
text 633324 633384 60 0.0
nrf52840dk_nrf52840+rpc (read/write) 923511 923607 96 0.0
rodata 101548 101580 32 0.0
text 628636 628696 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848094 848190 96 0.0
rodata 101296 101328 32 0.0
text 550256 550316 60 0.0
lock-app nrf52840dk_nrf52840 (read/write) 909259 909343 84 0.0
rodata 103392 103428 36 0.0
text 611188 611248 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820418 820514 96 0.0
rodata 96620 96652 32 0.0
text 528164 528224 60 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910523 910619 96 0.0
rodata 103608 103640 32 0.0
text 612404 612464 60 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 907339 907423 84 0.0
rodata 102864 102900 36 0.0
text 609936 609996 60 0.0
shell nrf52840dk_nrf52840 (read/write) 797935 798031 96 0.0
rodata 78148 78180 32 0.0
text 533508 533568 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710750 710850 100 0.0
rodata 72448 72484 36 0.0
text 451188 451248 60 0.0
p6 all-clusters-app default (read/write) 2401656 2401784 128 0.0
.text 1359920 1360048 128 0.0
light-app default (read/write) 2323680 2323808 128 0.0
.text 1281944 1282072 128 0.0
lock-app default (read/write) 2295904 2296032 128 0.0
.text 1254168 1254296 128 0.0
qpg lighting-app qpg6105+debug (read only) 533192 533240 48 0.0
.text 527872 527920 48 0.0
lock-app qpg6105+debug (read only) 504968 505016 48 0.0
.text 499648 499696 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 834522 834606 84 0.0
text 582766 582816 50 0.0
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b7ff37e d37e0c4 change % change
efr32 lighting-app BRD4161A (read only) 829244 829316 72 0.0
(read/write) 126996 126996 0 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 829236 829308 72 0.0
BRD4161A+rpc (read only) 816888 816960 72 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816880 816952 72 0.0
window-app BRD4161A (read only) 802692 802780 88 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802684 802772 88 0.0
k32w light k32w061+release (read/write) 655324 655380 56 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570900 570956 56 0.0
lock k32w061+release (read/write) 659632 659688 56 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574892 574948 56 0.0
linux chip-tool-ipv6only arm64 (read only) 7105148 7105452 304 0.0
(read/write) 327009 327041 32 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209392 209424 32 0.0
.dynamic 560 560 0 0.0
.got 57968 57976 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 388884 388900 16 0.0
.text 6019716 6019892 176 0.0
thermostat-no-ble arm64 (read only) 2033868 2034188 320 0.0
(read/write) 145089 145137 48 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72656 32 0.0
.dynamic 560 560 0 0.0
.got 4000 4008 8 0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 129004 16 0.0
.text 1691232 1691408 176 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348560 2348664 104 0.0
.bss 188724 188724 0 0.0
.data 5312 5312 0 0.0
.text 1311136 1311240 104 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330752 2330792 40 0.0
.bss 180544 180544 0 0.0
.data 5552 5552 0 0.0
.text 1293352 1293392 40 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303904 2303944 40 0.0
.bss 179592 179592 0 0.0
.data 5544 5544 0 0.0
.text 1266504 1266544 40 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054368 112 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016968 112 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937115 937199 84 0.0
bss 118112 118112 0 0.0
rodata 108120 108156 36 0.0
text 633324 633384 60 0.0
nrf52840dk_nrf52840+rpc (read/write) 923511 923607 96 0.0
bss 115156 115156 0 0.0
rodata 101548 101580 32 0.0
text 628636 628696 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848094 848190 96 0.0
bss 116004 116004 0 0.0
rodata 101296 101328 32 0.0
text 550256 550316 60 0.0
lock-app nrf52840dk_nrf52840 (read/write) 909259 909343 84 0.0
bss 117300 117300 0 0.0
rodata 103392 103428 36 0.0
text 611188 611248 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820418 820514 96 0.0
bss 115220 115220 0 0.0
rodata 96620 96652 32 0.0
text 528164 528224 60 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910523 910619 96 0.0
bss 117060 117060 0 0.0
rodata 103608 103640 32 0.0
text 612404 612464 60 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 907339 907423 84 0.0
bss 117088 117088 0 0.0
rodata 102864 102900 36 0.0
text 609936 609996 60 0.0
shell nrf52840dk_nrf52840 (read/write) 797935 798031 96 0.0
bss 109768 109768 0 0.0
rodata 78148 78180 32 0.0
text 533508 533568 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710750 710850 100 0.0
bss 107656 107656 0 0.0
rodata 72448 72484 36 0.0
text 451188 451248 60 0.0
p6 all-clusters-app default (read/write) 2401656 2401784 128 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1359920 1360048 128 0.0
light-app default (read/write) 2323680 2323808 128 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1282072 128 0.0
lock-app default (read/write) 2295904 2296032 128 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254168 1254296 128 0.0
qpg lighting-app qpg6105+debug (read only) 533192 533240 48 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527872 527920 48 0.0
lock-app qpg6105+debug (read only) 504968 505016 48 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499648 499696 48 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834522 834606 84 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582766 582816 50 0.0

@yufengwangca yufengwangca merged commit 8281d59 into project-chip:master Jan 10, 2022
@yufengwangca yufengwangca deleted the pr/configuration/locale branch January 10, 2022 17:26
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@yufengwangca @step0035
Add support for ActiveLocale in ConfigurationMgr (project-chip#13403)
33d5198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
darwin efr32 esp32 linux platform review - approved zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @yunhanw-google @Damian-Nordic