Switch to having only one struct named LabelStruct. #13380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
label-structs
branch
from
d983a53 to
2d4dbe9
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #13380: Size comparison from 585cdcb to 2d4dbe9 Decreases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
austinh0
approved these changes
Jan 7, 2022
|
/rebase |
This is shared across the fixed label and user label clusters. The struct definition is in the "detail" namespace, with alias namespaces in the two clusters that use it. Consumers are generally expected to use the per-cluster aliases.
woody-apple
force-pushed
the
label-structs
branch
from
2d4dbe9 to
9fc02bf
Compare
|
PR #13380: Size comparison from c25c4b3 to 9fc02bf Decreases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
That's a different situation: those are different struct definitions in the spec, not a single struct definition used in both clusters. For that one, we should leave them as separate structs in the XML, to match the spec, and I guess we need to change one of the names to disambiguate them... |
jmartinez-silabs
approved these changes
Jan 10, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
This is shared across the fixed label and user label clusters. The struct definition is in the "detail" namespace, with alias namespaces in the two clusters that use it. Consumers are generally expected to use the per-cluster aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is shared across the fixed label and user label clusters.
The struct definition is in the "detail" namespace, with alias
namespaces in the two clusters that use it. Consumers are generally
expected to use the per-cluster aliases.
Problem
Multiple structs with the same name are a problem, because various places look up structs by name.
Change overview
Have only one struct with that name in XML.
Also have only one struct with that name in C++, so C++ consumers who only have a name without the cluster context (if any) don't necessarily have to guess the right cluster name and we can't get weird divergence between the per-cluster views of this struct.
Testing
Tree compiles, extra assignments are gone in Darwin code.