Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[shell] Add 'server' command to shell app. (#13060)" #13368

Merged
merged 1 commit into from
Jan 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/.wordlist.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@

14
15
16
17
ContentApp's
18
19
20
21
22

AAAA
aabbccddeeff
aarch
Expand All @@ -24,9 +25,9 @@ ACL
AdapterAddress
AdapterName
adb
addr
AddOrUpdateThreadNetwork
AddOrUpdateWiFiNetwork
addr
adk
adoc
AdvAutonomous
Expand Down Expand Up @@ -216,13 +217,11 @@ ConnectionData
ConnectIP
ConnectivityManager
ConnectivityManagerImpl
ConnectNetwork
connstring
conntype
const
ContentApp
ContentAppPlatform
ContentApp's
ContentLaunch
ContentLauncher
contrib
Expand Down Expand Up @@ -355,6 +354,7 @@ elftools
elock
emberAfExternalAttributeReadCallback
emberAfExternalAttributeWriteCallback
ConnectNetwork
EnableWiFiNetwork
EndpointId
endpointName
Expand Down Expand Up @@ -383,7 +383,6 @@ ExtendedPAN
extern
extpanid
FabricId
fabricIdx
factoryreset
fb
fbb
Expand Down Expand Up @@ -751,8 +750,6 @@ pcaps
PDFs
PDK
peerAddrStr
peerNodeId
peerSessionId
pem
percentageLiftValue
pexpect
Expand Down Expand Up @@ -1009,9 +1006,8 @@ ttyUSB
TXD
txt
UART
udc
UDC
udcport
udc
udhcpc
UDP
UDPEndPoint
Expand Down
2 changes: 1 addition & 1 deletion examples/platform/efr32/matter_shell.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ void WaitForShellActivity()

void startShellTask()
{
int status = chip::Shell::Engine::Root().Init();
int status = chip::Shell::streamer_init(chip::Shell::streamer_get());
assert(status == 0);

// For now also register commands from shell_common (shell app).
Expand Down
1 change: 0 additions & 1 deletion examples/shell/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ Done
- [otcli](README_OTCLI.md)
- [ping](#ping)
- [rand](#rand)
- [server](README_SERVER.md)
- [version](#version)

## Matter Shell Command Details
Expand Down
206 changes: 0 additions & 206 deletions examples/shell/README_SERVER.md

This file was deleted.

4 changes: 0 additions & 4 deletions examples/shell/esp32/main/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ extern "C" void app_main(void)
chip::Platform::MemoryInit();
chip::DeviceLayer::PlatformMgr().InitChipStack();
chip::DeviceLayer::PlatformMgr().StartEventLoopTask();

int ret = Engine::Root().Init();
assert(ret == 0);

cmd_ping_init();
xTaskCreate(&chip_shell_task, "chip_shell", 2048, NULL, 5, NULL);
}
2 changes: 1 addition & 1 deletion examples/shell/mbed/main/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ int main()
}

// Initialize the default streamer that was linked.
ret = Engine::Root().Init();
ret = streamer_init(streamer_get());
if (ret)
{
ChipLogError(Shell, "Streamer initialization failed [%d]", ret);
Expand Down
24 changes: 0 additions & 24 deletions examples/shell/shell_common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ import("//build_overrides/openthread.gni")

import("${chip_root}/src/platform/device.gni")

declare_args() {
# Enable server command only on linux for now.
chip_shell_cmd_server = current_os == "linux" || current_os == "mac"
}

config("shell_common_config") {
include_dirs = [
".",
Expand All @@ -32,7 +27,6 @@ config("shell_common_config") {
defines = [
"ENABLE_CHIP_SHELL",
"OPENTHREAD_CONFIG_CLI_TRANSPORT=OT_CLI_TRANSPORT_CONSOLE",
"CHIP_SHELL_ENABLE_CMD_SERVER=${chip_shell_cmd_server}",
]
}

Expand Down Expand Up @@ -67,23 +61,5 @@ static_library("shell_common") {
}
}

if (chip_shell_cmd_server) {
sources += [ "cmd_server.cpp" ]

import("${chip_root}/src/app/chip_data_model.gni")

sources += [
"${chip_root}/examples/all-clusters-app/all-clusters-common/src/bridged-actions-stub.cpp",
"${chip_root}/examples/all-clusters-app/all-clusters-common/src/ota-requestor-stub.cpp",
"${chip_root}/examples/all-clusters-app/all-clusters-common/src/static-supported-modes-manager.cpp",
]

include_dirs =
[ "${chip_root}/examples/all-clusters-app/all-clusters-common/include" ]

public_deps +=
[ "${chip_root}/examples/all-clusters-app/all-clusters-common" ]
}

public_configs = [ ":shell_common_config" ]
}
Loading