-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing parts in Localization Configuration cluster #13322
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/configuration
Jan 6, 2022
Merged
Add missing parts in Localization Configuration cluster #13322
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/configuration
Jan 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
msandstedt,
mspang and
pan-apple
January 5, 2022 15:17
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
January 5, 2022 15:17
PR #13322: Size comparison from 6ddb3e4 to 6f0556c Decreases (6 builds for efr32, k32w, p6, qpg, telink)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #13322: Size comparison from e0475db to 9fa616f Increases (1 build for esp32)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Jan 5, 2022
saurabhst
approved these changes
Jan 5, 2022
@yufengwangca Is there a followup to enable these attribute in all-clusters-app? |
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…#13322) * Add missing parts in Localization Configuration cluster * Run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Add missing parts in Localization Configuration cluster
Testing
How was this tested? (at least one bullet point required)