Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow creating secure session handle on the fly #13313

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Do not allow creating secure session handle on the fly #13313

merged 1 commit into from
Jan 5, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Jan 5, 2022

Problem

SessionHandle can only be created by session manager

Change overview

Remove session handle constructor and all its usage.

Testing

Verified by unit-tets.

@github-actions
Copy link

github-actions bot commented Jan 5, 2022 •
edited
Loading

PR #13313: Size comparison from 206e173 to 075ec22

Increases (23 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 206e173 075ec22 change % change
efr32 lighting-app BRD4161A (read only) 829620 829732 112 0.0
.text 829612 829724 112 0.0
BRD4161A+rpc (read only) 817248 817344 96 0.0
.text 817240 817336 96 0.0
window-app BRD4161A (read only) 803068 803180 112 0.0
.text 803060 803172 112 0.0
esp32 all-clusters-app c3devkit (read only) 889156 889178 22 0.0
.flash.text 889156 889178 22 0.0
m5stack (read only) 949015 949071 56 0.0
.flash.text 943631 943687 56 0.0
k32w light k32w061+release (read/write) 648440 648472 32 0.0
.text 564520 564552 32 0.0
lock k32w061+release (read/write) 633264 633296 32 0.0
.text 549676 549708 32 0.0
linux thermostat-no-ble arm64 (read only) 2023868 2024396 528 0.0
.rodata 128508 128524 16 0.0
.text 1682688 1683200 512 0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2329448 2329512 64 0.0
.text 1292048 1292112 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302608 2302672 64 0.0
.text 1265208 1265272 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935715 935763 48 0.0
text 631908 631948 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 922083 922115 32 0.0
text 627220 627260 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 846674 846706 32 0.0
text 548844 548888 44 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907827 907875 48 0.0
text 609776 609820 44 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 818998 819046 48 0.0
text 526756 526796 40 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909103 909151 48 0.0
text 610992 611032 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905939 905987 48 0.0
text 608524 608568 44 0.0
p6 all-clusters-app default (read/write) 2401176 2401288 112 0.0
.text 1359440 1359552 112 0.0
light-app default (read/write) 2324456 2324568 112 0.0
.text 1282720 1282832 112 0.0
lock-app default (read/write) 2296656 2296768 112 0.0
.text 1254920 1255032 112 0.0
qpg lighting-app qpg6105+debug (read only) 531624 531664 40 0.0
.text 526304 526344 40 0.0
lock-app qpg6105+debug (read only) 503420 503444 24 0.0
.text 498100 498124 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 832186 832242 56 0.0
text 580624 580682 58 0.0
Decreases (4 builds for linux, mbed, nrfconnect)
platform target config section 206e173 075ec22 change % change
linux chip-tool-ipv6only arm64 (read only) 7010492 7010428 -64 -0.0
.text 5935188 5935124 -64 -0.0
mbed shell CY8CPROTO_062_4343W+release (read/write) 2053952 2053888 -64 -0.0
.text 1016552 1016488 -64 -0.0
nrfconnect shell nrf52840dk_nrf52840 (read/write) 796891 796843 -48 -0.0
text 532708 532664 -44 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709718 709670 -48 -0.0
text 450384 450340 -44 -0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 206e173 075ec22 change % change
efr32 lighting-app BRD4161A (read only) 829620 829732 112 0.0
(read/write) 127068 127068 0 0.0
.bss 125192 125192 0 0.0
.data 1876 1876 0 0.0
.text 829612 829724 112 0.0
BRD4161A+rpc (read only) 817248 817344 96 0.0
(read/write) 143736 143736 0 0.0
.bss 141760 141760 0 0.0
.data 1976 1976 0 0.0
.text 817240 817336 96 0.0
window-app BRD4161A (read only) 803068 803180 112 0.0
(read/write) 126008 126008 0 0.0
.bss 124176 124176 0 0.0
.data 1832 1832 0 0.0
.text 803060 803172 112 0.0
esp32 all-clusters-app c3devkit (read only) 889156 889178 22 0.0
(read/write) 1313770 1313770 0 0.0
.dram0.bss 69288 69288 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177184 177184 0 0.0
.flash.text 889156 889178 22 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 949015 949071 56 0.0
(read/write) 445352 445352 0 0.0
.dram0.bss 73776 73776 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206504 206504 0 0.0
.flash.text 943631 943687 56 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648440 648472 32 0.0
.bss 76216 76216 0 0.0
.data 1904 1904 0 0.0
.text 564520 564552 32 0.0
lock k32w061+release (read/write) 633264 633296 32 0.0
.bss 75928 75928 0 0.0
.data 1860 1860 0 0.0
.text 549676 549708 32 0.0
linux chip-tool-ipv6only arm64 (read only) 7010492 7010428 -64 -0.0
(read/write) 324785 324785 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208920 208920 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383108 383108 0 0.0
.text 5935188 5935124 -64 -0.0
thermostat-no-ble arm64 (read only) 2023868 2024396 528 0.0
(read/write) 144049 144049 0 0.0
.bss 64001 64001 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128508 128524 16 0.0
.text 1682688 1683200 512 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346288 2346288 0 0.0
.bss 188548 188548 0 0.0
.data 5312 5312 0 0.0
.text 1308864 1308864 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329448 2329512 64 0.0
.bss 180624 180624 0 0.0
.data 5552 5552 0 0.0
.text 1292048 1292112 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302608 2302672 64 0.0
.bss 179672 179672 0 0.0
.data 5544 5544 0 0.0
.text 1265208 1265272 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053952 2053888 -64 -0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016552 1016488 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935715 935763 48 0.0
bss 118188 118188 0 0.0
rodata 108048 108048 0 0.0
text 631908 631948 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 922083 922115 32 0.0
bss 115232 115232 0 0.0
rodata 101464 101464 0 0.0
text 627220 627260 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 846674 846706 32 0.0
bss 116080 116080 0 0.0
rodata 101220 101220 0 0.0
text 548844 548888 44 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907827 907875 48 0.0
bss 117376 117376 0 0.0
rodata 103320 103320 0 0.0
text 609776 609820 44 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 818998 819046 48 0.0
bss 115296 115296 0 0.0
rodata 96544 96544 0 0.0
text 526756 526796 40 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909103 909151 48 0.0
bss 117136 117136 0 0.0
rodata 103532 103532 0 0.0
text 610992 611032 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905939 905987 48 0.0
bss 117164 117164 0 0.0
rodata 102792 102792 0 0.0
text 608524 608568 44 0.0
shell nrf52840dk_nrf52840 (read/write) 796891 796843 -48 -0.0
bss 109536 109536 0 0.0
rodata 78188 78188 0 0.0
text 532708 532664 -44 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709718 709670 -48 -0.0
bss 107424 107424 0 0.0
rodata 72492 72492 0 0.0
text 450384 450340 -44 -0.0
p6 all-clusters-app default (read/write) 2401176 2401288 112 0.0
.bss 116748 116748 0 0.0
.data 2592 2592 0 0.0
.text 1359440 1359552 112 0.0
light-app default (read/write) 2324456 2324568 112 0.0
.bss 105872 105872 0 0.0
.data 2384 2384 0 0.0
.text 1282720 1282832 112 0.0
lock-app default (read/write) 2296656 2296768 112 0.0
.bss 104752 104752 0 0.0
.data 2336 2336 0 0.0
.text 1254920 1255032 112 0.0
qpg lighting-app qpg6105+debug (read only) 531624 531664 40 0.0
(read/write) 146936 146936 0 0.0
.bss 86672 86672 0 0.0
.data 1004 1004 0 0.0
.text 526304 526344 40 0.0
lock-app qpg6105+debug (read only) 503420 503444 24 0.0
(read/write) 146940 146940 0 0.0
.bss 85808 85808 0 0.0
.data 952 952 0 0.0
.text 498100 498124 24 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832186 832242 56 0.0
bss 86856 86856 0 0.0
noinit 37160 37160 0 0.0
text 580624 580682 58 0.0

@msandstedt
Copy link
Contributor

I have a roadmap question about the session holder feature and migration.

Will session manager be notified of the destruction of session holders so that it knows not to call back into a session holder object after it has been destructed? This will be critical.

@andy31415 andy31415 merged commit 6ddb3e4 into project-chip:master Jan 5, 2022
vivien-apple pushed a commit to vivien-apple/connectedhomeip-1 that referenced this pull request Jan 6, 2022
@kghost @vivien-apple
Do not allow creating secure session handle on the fly (project-chip#…
573dfda 
…13313)
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@kghost @step0035
Do not allow creating secure session handle on the fly (project-chip#…
1578bf7 
…13313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @msandstedt @andy31415