-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Make requestor use endpoint from AnnounceOTAProvider command #13305
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_announce_endpoint
Jan 4, 2022
Merged
[OTA] Make requestor use endpoint from AnnounceOTAProvider command #13305
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_announce_endpoint
Jan 4, 2022
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
January 4, 2022 05:08
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
January 4, 2022 05:08
PR #13305: Size comparison from b0af6ba to 8a3691f Full report (29 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
carol-apple
force-pushed
the
ota_requestor_announce_endpoint
branch
from
January 4, 2022 17:50
8a3691f
to
d1d576a
Compare
andy31415
approved these changes
Jan 4, 2022
fast track: trivial change, made by a domain owner |
PR #13305: Size comparison from b006321 to d1d576a Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
approved these changes
Jan 4, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the OTA Requestor is using the default root endpoint when connecting to the OTA Provider
Change overview
Testing
Manually tested provider/requestor on Linux