Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTA] Make requestor use endpoint from AnnounceOTAProvider command #13305

Merged

Conversation

carol-apple
Copy link
Contributor

Problem

Currently, the OTA Requestor is using the default root endpoint when connecting to the OTA Provider

Change overview

  • Use the endpoint field in the AnnounceOTAProvider command when connecting to OTA Provider

Testing

Manually tested provider/requestor on Linux

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

PR #13305: Size comparison from b0af6ba to 8a3691f

Full report (29 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section b0af6ba 8a3691f change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
esp32 all-clusters-app c3devkit (read only) 888138 888138 0 0.0
(read/write) 1313666 1313666 0 0.0
.dram0.bss 69264 69264 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 177112 177112 0 0.0
.flash.text 888138 888138 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 948215 948215 0 0.0
(read/write) 445252 445252 0 0.0
.dram0.bss 73760 73760 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 206428 206428 0 0.0
.flash.text 942831 942831 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 632264 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548708 548708 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2345456 2345456 0 0.0
.bss 188524 188524 0 0.0
.data 5304 5304 0 0.0
.text 1308032 1308032 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2302200 0 0.0
.bss 179656 179656 0 0.0
.data 5544 5544 0 0.0
.text 1264800 1264800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 907507 0 0.0
bss 117360 117360 0 0.0
rodata 103304 103304 0 0.0
text 609460 609460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831422 831422 0 0.0
bss 115672 115672 0 0.0
rodata 98268 98268 0 0.0
text 536940 536940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2399776 2399776 0 0.0
.bss 116732 116732 0 0.0
.data 2584 2584 0 0.0
.text 1358040 1358040 0 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2295880 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254144 1254144 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@carol-apple carol-apple force-pushed the ota_requestor_announce_endpoint branch from 8a3691f to d1d576a Compare January 4, 2022 17:50
@andy31415
Copy link
Contributor

fast track: trivial change, made by a domain owner

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

PR #13305: Size comparison from b006321 to d1d576a

Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b006321 d1d576a change % change
efr32 lighting-app BRD4161A (read only) 829620 829620 0 0.0
(read/write) 127068 127068 0 0.0
.bss 125192 125192 0 0.0
.data 1876 1876 0 0.0
.text 829612 829612 0 0.0
BRD4161A+rpc (read only) 817248 817248 0 0.0
(read/write) 143736 143736 0 0.0
.bss 141760 141760 0 0.0
.data 1976 1976 0 0.0
.text 817240 817240 0 0.0
window-app BRD4161A (read only) 803068 803068 0 0.0
(read/write) 126008 126008 0 0.0
.bss 124176 124176 0 0.0
.data 1832 1832 0 0.0
.text 803060 803060 0 0.0
esp32 all-clusters-app c3devkit (read only) 889122 889122 0 0.0
(read/write) 1313770 1313770 0 0.0
.dram0.bss 69288 69288 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177184 177184 0 0.0
.flash.text 889122 889122 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 948991 948991 0 0.0
(read/write) 445352 445352 0 0.0
.dram0.bss 73776 73776 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206504 206504 0 0.0
.flash.text 943607 943607 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648440 648440 0 0.0
.bss 76216 76216 0 0.0
.data 1904 1904 0 0.0
.text 564520 564520 0 0.0
lock k32w061+release (read/write) 633264 633264 0 0.0
.bss 75928 75928 0 0.0
.data 1860 1860 0 0.0
.text 549676 549676 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7010492 7010492 0 0.0
(read/write) 324785 324785 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208920 208920 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383108 383108 0 0.0
.text 5935188 5935188 0 0.0
thermostat-no-ble arm64 (read only) 2023772 2023772 0 0.0
(read/write) 144017 144017 0 0.0
.bss 64001 64001 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72272 72272 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128508 128508 0 0.0
.text 1682624 1682624 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346224 2346224 0 0.0
.bss 188548 188548 0 0.0
.data 5312 5312 0 0.0
.text 1308800 1308800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329384 2329384 0 0.0
.bss 180624 180624 0 0.0
.data 5552 5552 0 0.0
.text 1291984 1291984 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302544 2302544 0 0.0
.bss 179672 179672 0 0.0
.data 5544 5544 0 0.0
.text 1265144 1265144 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053952 2053952 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016552 1016552 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935615 935615 0 0.0
bss 118188 118188 0 0.0
rodata 108012 108012 0 0.0
text 631844 631844 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921987 921987 0 0.0
bss 115232 115232 0 0.0
rodata 101432 101432 0 0.0
text 627156 627156 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 846578 846578 0 0.0
bss 116080 116080 0 0.0
rodata 101188 101188 0 0.0
text 548780 548780 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907827 907827 0 0.0
bss 117376 117376 0 0.0
rodata 103320 103320 0 0.0
text 609776 609776 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 818998 818998 0 0.0
bss 115296 115296 0 0.0
rodata 96544 96544 0 0.0
text 526756 526756 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909103 909103 0 0.0
bss 117136 117136 0 0.0
rodata 103532 103532 0 0.0
text 610992 610992 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905939 905939 0 0.0
bss 117164 117164 0 0.0
rodata 102792 102792 0 0.0
text 608524 608524 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796891 796891 0 0.0
bss 109536 109536 0 0.0
rodata 78188 78188 0 0.0
text 532708 532708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709718 709718 0 0.0
bss 107424 107424 0 0.0
rodata 72492 72492 0 0.0
text 450384 450384 0 0.0
p6 all-clusters-app default (read/write) 2401096 2401096 0 0.0
.bss 116748 116748 0 0.0
.data 2592 2592 0 0.0
.text 1359360 1359360 0 0.0
light-app default (read/write) 2324456 2324456 0 0.0
.bss 105872 105872 0 0.0
.data 2384 2384 0 0.0
.text 1282720 1282720 0 0.0
lock-app default (read/write) 2296656 2296656 0 0.0
.bss 104752 104752 0 0.0
.data 2336 2336 0 0.0
.text 1254920 1254920 0 0.0
qpg lighting-app qpg6105+debug (read only) 531624 531624 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86672 86672 0 0.0
.data 1004 1004 0 0.0
.text 526304 526304 0 0.0
lock-app qpg6105+debug (read only) 503420 503420 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85808 85808 0 0.0
.data 952 952 0 0.0
.text 498100 498100 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832122 832122 0 0.0
bss 86856 86856 0 0.0
noinit 37160 37160 0 0.0
text 580562 580562 0 0.0

@carol-apple carol-apple merged commit 939ca0b into project-chip:master Jan 4, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Endpoint number to OTA cluster
3 participants