Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zephyr] Added Kconfig options to control Matter logs level #13288

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[zephyr] Added Kconfig options to control Matter logs level #13288

merged 1 commit into from
Jan 4, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

Zephyr logging platform currently uses hardcoded DEBUG log level and it's not possible to change it through KConfig options.

Change overview

Added MATTER logging module to Zephyr subsys and enabled setting Matter logs level using CONFIG_MATTER_LOG_LEVEL option.

Testing

Manually tested that changing log levels works properly.

@github-actions
Copy link

github-actions bot commented Dec 30, 2021 •
edited
Loading

PR #13288: Size comparison from 99c1985 to d78adb6

Decreases (11 builds for nrfconnect, telink)
platform target config section 99c1985 d78adb6 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 text 631528 631520 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921607 -44 -0.0
rodata 101416 101404 -12 -0.0
text 626840 626808 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 858998 -16 -0.0
text 558964 558960 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 907491 -16 -0.0
text 609460 609456 -4 -0.0
nrf5340dk_nrf5340_cpuapp text 536940 536932 -8 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542307 -44 -0.0
rodata 50668 50656 -12 -0.0
text 376892 376860 -32 -0.0
pump-app nrf52840dk_nrf52840 text 610676 610668 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905571 -16 -0.0
text 608208 608204 -4 -0.0
shell nrf52840dk_nrf52840 text 532680 532672 -8 -0.0
nrf5340dk_nrf5340_cpuapp text 450172 450164 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831738 -16 -0.0
text 580232 580218 -14 -0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 99c1985 d78adb6 change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
esp32 all-clusters-app c3devkit (read only) 882900 882900 0 0.0
(read/write) 1312498 1312498 0 0.0
.dram0.bss 69104 69104 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 176104 176104 0 0.0
.flash.text 882900 882900 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 943439 943439 0 0.0
(read/write) 441600 441600 0 0.0
.dram0.bss 73600 73600 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202936 202936 0 0.0
.flash.text 938055 938055 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 632264 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548708 548708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7010188 7010188 0 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383300 0 0.0
.text 5934516 5934516 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338944 2338944 0 0.0
.bss 188364 188364 0 0.0
.data 5272 5272 0 0.0
.text 1301520 1301520 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2302200 0 0.0
.bss 179656 179656 0 0.0
.data 5544 5544 0 0.0
.text 1264800 1264800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631520 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921607 -44 -0.0
bss 115216 115216 0 0.0
rodata 101416 101404 -12 -0.0
text 626840 626808 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 858998 -16 -0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558960 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 907491 -16 -0.0
bss 117360 117360 0 0.0
rodata 103304 103304 0 0.0
text 609460 609456 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831422 831422 0 0.0
bss 115672 115672 0 0.0
rodata 98268 98268 0 0.0
text 536940 536932 -8 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542307 -44 -0.0
bss 52588 52588 0 0.0
rodata 50668 50656 -12 -0.0
text 376892 376860 -32 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610668 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905571 -16 -0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608204 -4 -0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532672 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450164 -8 -0.0
p6 all-clusters-app default (read/write) 2391112 2391112 0 0.0
.bss 116564 116564 0 0.0
.data 2552 2552 0 0.0
.text 1349376 1349376 0 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2295880 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254144 1254144 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831738 -16 -0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580218 -14 -0.0

@kkasperczyk-no
[zephyr] Added Kconfig options to control Matter logs level
a412055 
Zephyr logging platform currently uses hardcoded DEBUG log level
and it's not possible to change it through KConfig options.

Added MATTER logging module to Zephyr subsys and enabled setting
Matter logs level using CONFIG_MATTER_LOG_LEVEL option.
@github-actions
Copy link

github-actions bot commented Jan 4, 2022 •
edited
Loading

PR #13288: Size comparison from b0af6ba to a412055

Decreases (1 build for telink)
platform target config section b0af6ba a412055 change % change
telink lighting-app tlsr9518adk80d (read/write) 831754 831738 -16 -0.0
text 580232 580218 -14 -0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b0af6ba a412055 change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
esp32 all-clusters-app c3devkit (read only) 888138 888138 0 0.0
(read/write) 1313666 1313666 0 0.0
.dram0.bss 69264 69264 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 177112 177112 0 0.0
.flash.text 888138 888138 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 948215 948215 0 0.0
(read/write) 445252 445252 0 0.0
.dram0.bss 73760 73760 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 206428 206428 0 0.0
.flash.text 942831 942831 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 632264 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548708 548708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7014204 7014204 0 0.0
(read/write) 324865 324865 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208984 208984 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383332 383332 0 0.0
.text 5938436 5938436 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2345456 2345456 0 0.0
.bss 188524 188524 0 0.0
.data 5304 5304 0 0.0
.text 1308032 1308032 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2302200 0 0.0
.bss 179656 179656 0 0.0
.data 5544 5544 0 0.0
.text 1264800 1264800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 907507 0 0.0
bss 117360 117360 0 0.0
rodata 103304 103304 0 0.0
text 609460 609460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831422 831422 0 0.0
bss 115672 115672 0 0.0
rodata 98268 98268 0 0.0
text 536940 536940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2399776 2399776 0 0.0
.bss 116732 116732 0 0.0
.data 2584 2584 0 0.0
.text 1358040 1358040 0 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2295880 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254144 1254144 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831738 -16 -0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580218 -14 -0.0

@andy31415 andy31415 merged commit 65ba5df into project-chip:master Jan 4, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@kkasperczyk-no @step0035
[zephyr] Added Kconfig options to control Matter logs level (project-…
f8d0667 
…chip#13288)

Zephyr logging platform currently uses hardcoded DEBUG log level
and it's not possible to change it through KConfig options.

Added MATTER logging module to Zephyr subsys and enabled setting
Matter logs level using CONFIG_MATTER_LOG_LEVEL option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuDuda LuDuda LuDuda approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
config platform review - approved zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkasperczyk-no @andy31415 @LuDuda