[ble] Fixed controller not being able to commission device after first attempt failure #13287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
mspang,
pan-apple and
robszewczyk
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #13287: Size comparison from 99c1985 to 0967321 Increases (16 builds for efr32, esp32, mbed, nrfconnect, p6, qpg)
Decreases (1 build for linux)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 30, 2021
jmartinez-silabs
approved these changes
Jan 5, 2022
andy31415
approved these changes
Jan 6, 2022
LuDuda
approved these changes
Jan 7, 2022
kkasperczyk-no
force-pushed
the
controller_incorrect_state_fix_pr
branch
from
0967321 to
333afb1
Compare
|
PR #13287: Size comparison from b7ff37e to 333afb1 Increases (6 builds for k32w, p6, qpg)
Decreases (1 build for linux)
Full report (11 builds for k32w, linux, p6, qpg, telink)
|
…t attempt failure Sometimes it happens that if in specific moment of device commissioning over Bluetooth LE the connection will be closed (e.g. by turning off HCI adapter to simulate hardware problems) the controller is not able to commission the device on the second attempt due to incorrect state. * Added setting BLE state to kInitialized if BLE connection establishment failed. * Added cleaning rendezvous data if some PASE establisment error appeared.
kkasperczyk-no
force-pushed
the
controller_incorrect_state_fix_pr
branch
from
333afb1 to
f3df25e
Compare
|
PR #13287: Size comparison from b7ff37e to f3df25e Increases (16 builds for efr32, esp32, k32w, nrfconnect, p6, qpg)
Decreases (1 build for linux)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 10, 2022
kkasperczyk-no
added a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
Jan 19, 2022
In project-chip#13287 the regression was introduced that starting commissioning, while an existing commissioning is in progress will cancel it. * Brought back previous error handling and added clearing mDeviceBeingCommissioned to allow starting new commissioning after previous ones fail.
woody-apple
pushed a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
Jan 19, 2022
In project-chip#13287 the regression was introduced that starting commissioning, while an existing commissioning is in progress will cancel it. * Brought back previous error handling and added clearing mDeviceBeingCommissioned to allow starting new commissioning after previous ones fail.
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…roject-chip#13697) In project-chip#13287 the regression was introduced that starting commissioning, while an existing commissioning is in progress will cancel it. * Brought back previous error handling and added clearing mDeviceBeingCommissioned to allow starting new commissioning after previous ones fail.
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…t attempt failure (project-chip#13287) Sometimes it happens that if in specific moment of device commissioning over Bluetooth LE the connection will be closed (e.g. by turning off HCI adapter to simulate hardware problems) the controller is not able to commission the device on the second attempt due to incorrect state. * Added setting BLE state to kInitialized if BLE connection establishment failed. * Added cleaning rendezvous data if some PASE establisment error appeared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes it happens that if in specific moment of device commissioning over Bluetooth LE the connection will be closed
(e.g. by turning off HCI adapter to simulate hardware problems) the controller is not able to commission the device on the second attempt due to incorrect state. See #13286 for more details.
Change overview
Testing
Verified with Python CHIP controller and nrfconnect lock-app example that it is possible to attempt several commissioning attempts after breaking BLE connection during communication by turning off Bluetooth HCI adapter.
Fixes: #13286