Fix lighting-app build error for nrf52840dongle #13285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restyled is blocking review due to workflow permission, not sure what I need to do, would still appreciate if this one gets looked at. |
|
@lmpprk, try these changes: lmpprk#1. Line 44 replaces the tab with 4 spaces. Line 47 double quotes Restyled is trying to force push the workflow file since it is part of the commit but is blocked here: connectedhomeip/.restyled.yaml Line 43 in d4d57f6 If the fixes I linked are applied, I don't think restyled will find any changes and will therefore not try and push anything. These changes were found by running the scripts locally that were found to modify the source in https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/1394929. The flags used were extracted from https://github.com/lmpprk/connectedhomeip/blob/nrf-dongle/.restyled.yaml. docker run --rm -it -v $PWD/scripts/examples/nrfconnect_example.sh:/tmp/nrfconnect_example.sh restyled/restyler-shfmt:v3.0.1 shfmt -i 4 -ci /tmp/nrfconnect_example.sh > /tmp/nrfconnect_example.sh
vimdiff scripts/examples/nrfconnect_example.sh /tmp/nrfconnect_example.sh
docker run --rm -it -v $PWD/scripts/examples/nrfconnect_example.sh:/tmp/nrfconnect_example.sh restyled/restyler-shellharden:v4.1.1-2 shellharden --transform /tmp/nrfconnect_example.sh > /tmp/nrfconnect_example.sh
vimdiff scripts/examples/nrfconnect_example.sh /tmp/nrfconnect_example.sh |
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02 and
mlepage-google
For tests, run them and replace with the generated files. I do something like: gn gen aabb
cd aabb
ninja -t targets | grep script | grep test # Because I always forget what target to run
ninja scripts/build:build_examples.testsThis will tell you what is different and you can copy the expected files into |
andy31415
reviewed
Jan 6, 2022
|
PR #13285: Size comparison from b81facc to 3134ce5 Increases above 0.2%:
Increases (7 builds for nrfconnect)
Decreases (7 builds for nrfconnect)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
requested changes
Jan 7, 2022
|
PR #13285: Size comparison from b81facc to 35ddfef Increases above 0.2%:
Increases (6 builds for k32w, linux, qpg, telink)
Decreases (4 builds for k32w, qpg, telink)
Full report (8 builds for k32w, linux, qpg, telink)
|
|
PR #13285: Size comparison from 0e5bc69 to e65ed93 Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 7, 2022
|
PR #13285: Size comparison from 36a759d to 1e97bf3 Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
|
/rebase |
woody-apple
force-pushed
the
nrf-dongle
branch
from
1e97bf3 to
82c892a
Compare
|
PR #13285: Size comparison from f2c2650 to 82c892a Increases above 0.2%:
Increases (7 builds for nrfconnect)
Decreases (6 builds for nrfconnect)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 10, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
* Update for building nrf52840dongle with zephyr 2.7 * Fix example script not loading the board overlays * restyle update * Use array for params avoid empty string in param * fix style * update to support nrf52840 dongle * fix for restyle * limit dongle to lighting-app target; update test data * avoid empty args; fix root path * fix CMakeList.txt isntead of fixing the scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed?
The nrf light example app gets error when building for
nrf52840dongle_nrf52840with following unrecognized symbols in kconfigChange overview
CONFIG_USBwithCONFIG_USB_DEVICE_STACKCONFIG_USB_UART_CONSOLECONFIG_UART_SHELL_ON_DEV_NAME="CDC_ACM_0"Build example nRF Connect SDK Lighting App on nRF52840 Donglein the nrfconnect example workflowboards/$BOARD.conffile exists for the exampleTesting
How was this tested? (at least one bullet point required)
west build -b nrf52840dongle_nrf52840built successfully