ESP: Add ESP32 platform driver for full NetworkCommissioning cluster #13283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02 and
msandstedt
wqx6
force-pushed
the
full-network-commissioning-esp
branch
3 times, most recently
from
15e4cce to
e385442
Compare
|
PR #13283: Size comparison from a0e8e3a to e385442 Increases above 0.2%:
Increases (2 builds for esp32)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Jan 6, 2022
wqx6
force-pushed
the
full-network-commissioning-esp
branch
from
e385442 to
b37fcba
Compare
|
PR #13283: Size comparison from b81facc to b37fcba Full report (8 builds for k32w, linux, qpg, telink)
|
wqx6
force-pushed
the
full-network-commissioning-esp
branch
from
b37fcba to
72b4922
Compare
wqx6
force-pushed
the
full-network-commissioning-esp
branch
2 times, most recently
from
fa8d49c to
d318413
Compare
|
PR #13283: Size comparison from b81facc to d318413 Increases above 0.2%:
Increases (2 builds for esp32)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
gjc13
approved these changes
Jan 7, 2022
|
@wqx6 - when pushing changes, please create separate 'fix' commits. That way we can view history. The merged PR will be squashed at the end, no need to squash it incrementally (squash and force push every time makes reviewer harder as it needs to be restarted from scratch). |
wqx6
force-pushed
the
full-network-commissioning-esp
branch
from
a3324c2 to
95e9f8a
Compare
|
PR #13283: Size comparison from b7ff37e to 95e9f8a Increases above 0.2%:
Increases (2 builds for esp32)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
wqx6
force-pushed
the
full-network-commissioning-esp
branch
from
95e9f8a to
ff2d470
Compare
|
PR #13283: Size comparison from 19f61eb to ff2d470 Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
wqx6
force-pushed
the
full-network-commissioning-esp
branch
from
ff2d470 to
2219651
Compare
|
PR #13283: Size comparison from 19f61eb to 2219651 Increases above 0.2%:
Increases (2 builds for esp32)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…roject-chip#13283) * Add ESP32 platform driver for full NetworkCommissioning cluster * Restyled by whitespace * Restyled by clang-format * Add check for index when reorder network Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#13170 Add ESP32 platform driver for NetworkCommissioning cluster
Change overview
Add ESP32 platform driver for NetworkCommissioning cluster
Testing
Test Manually. The commands of NetworkCommissioning cluster works with python controller. After #13267 merged, the chip tool can also use commands of NetworkCommissioning cluster with ESP32 platform.