[ESP32] Init OTA requestor in all-clusters-app #13246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang and
pan-apple
|
PR #13246: Size comparison from b0af6ba to 055acd3 Increases (4 builds for esp32, mbed, p6)
Full report (29 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
|
/rebase |
woody-apple
force-pushed
the
init_ota_requestor_esp32_all_clusters_app
branch
from
055acd3 to
868d8c5
Compare
|
PR #13246: Size comparison from b006321 to 868d8c5 Increases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
shubhamdp
force-pushed
the
init_ota_requestor_esp32_all_clusters_app
branch
from
868d8c5 to
c959872
Compare
|
PR #13246: Size comparison from 206e173 to c959872 Increases (1 build for p6)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
shubhamdp
force-pushed
the
init_ota_requestor_esp32_all_clusters_app
branch
from
c959872 to
2e27319
Compare
|
PR #13246: Size comparison from 206e173 to 2e27319 Increases (2 builds for esp32)
Decreases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
shubhamdp
force-pushed
the
init_ota_requestor_esp32_all_clusters_app
branch
2 times, most recently
from
e6a2f7d to
e3e33d4
Compare
|
PR #13246: Size comparison from b81facc to e3e33d4 Increases (3 builds for esp32, linux)
Decreases (3 builds for esp32, p6)
Full report (23 builds for esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
|
@shubhamdp What is the state of this? Is this dependent on any PR? |
|
/rebase |
Waiting on CI to pass, just rebased. |
woody-apple
force-pushed
the
init_ota_requestor_esp32_all_clusters_app
branch
from
e3e33d4 to
b14f034
Compare
|
PR #13246: Size comparison from 5d0c314 to b14f034 Increases (1 build for linux)
Decreases (1 build for p6)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
Also, enabled OTA_PROVIDER_CLIENT. Removed the weak function definitions from OTA command handlers.
shubhamdp
force-pushed
the
init_ota_requestor_esp32_all_clusters_app
branch
from
b14f034 to
a2b8441
Compare
|
PR #13246: Size comparison from 5d0c314 to a2b8441 Increases (4 builds for esp32, linux, p6)
Decreases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
carol-apple
approved these changes
Jan 9, 2022
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jan 11, 2022
To support OTA requestor functionality, we need OTA requestor server and OTA provider client. OTA provider client was enabled in project-chip#13246 which broke the ZAP regen. Having same cluster's client and server in same app is not supported in the zap. Removed OTA provider client from all-clusters-app Removing the OTA requestor support from all-clusters-app/esp32
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jan 11, 2022
To support OTA requestor functionality, we need OTA requestor server and OTA provider client. OTA provider client was enabled in project-chip#13246 which broke the ZAP regen. Having same cluster's client and server in same app is not supported in the zap. Removed OTA provider client from all-clusters-app Removing the OTA requestor support from all-clusters-app/esp32
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jan 11, 2022
To support OTA requestor functionality, we need OTA requestor server and OTA provider client. OTA provider client was enabled in project-chip#13246 which broke the ZAP regen. Having same cluster's client and server in same app is not supported in the zap. Removed OTA provider client from all-clusters-app Removing the OTA requestor support from all-clusters-app/esp32
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Also, enabled OTA_PROVIDER_CLIENT. Removed the weak function definitions from OTA command handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OTA requestor is not initialized in all-clusters-app/esp32.
Chip shell is using the weak function definitions for handling OTA commands.
Change overview
Initialize OTA requestor in all-clusters-app.
Also, enabled OTA_PROVIDER_CLIENT in all-cluster-app zap file.
Removed the weak function definitions from OTA command handlers.
Testing
Tested manually, all-clusters-app/esp32 and ota-provider-app/linux.
Triggered OTA using
matter ota querychip shell command and./chip-tool otasoftwareupdaterequestor announce-ota-providerchip-tool command.