Fixed a couple of memory leaks in chip-im-initiator and echo-requester example apps

[harsha-rajendran]

Problem

A couple of memory leaks in chip-im-initiator and echo-requester examples

Change overview

• Noticed the memory leaks during a regular valgrind run and fixed them.

Testing

• Ran both the applications with valgrind (Linux) and verified that the memory was being freed properly.
• Excerpts from the valgrind logs below for each of the applications.

chip-echo-Requester (BEFORE)
==3617== LEAK SUMMARY:
==3617== definitely lost: 88 bytes in 1 blocks
==3617== indirectly lost: 0 bytes in 0 blocks
==3617== possibly lost: 3,408 bytes in 29 blocks
==3617== still reachable: 92,413 bytes in 1,074 blocks
==3617== of which reachable via heuristic:
==3617== length64 : 768 bytes in 15 blocks
==3617== newarray : 1,728 bytes in 28 blocks
==3617== suppressed: 0 bytes in 0 blocks
==3617==
==3617== ERROR SUMMARY: 30 errors from 30 contexts (suppressed: 0 from 0)

chip-echo-Requester (AFTER)
==4242== LEAK SUMMARY:
==4242== definitely lost: 0 bytes in 0 blocks
==4242== indirectly lost: 0 bytes in 0 blocks
==4242== possibly lost: 3,400 bytes in 29 blocks
==4242== still reachable: 98,081 bytes in 1,095 blocks
==4242== of which reachable via heuristic:
==4242== length64 : 768 bytes in 15 blocks
==4242== newarray : 1,728 bytes in 28 blocks
==4242== suppressed: 0 bytes in 0 blocks
==4242==
==4242== ERROR SUMMARY: 29 errors from 29 contexts (suppressed: 0 from 0)

chip-im-initiator (BEFORE)
==4620== LEAK SUMMARY:
==4620== definitely lost: 1,344 bytes in 4 blocks
==4620== indirectly lost: 0 bytes in 0 blocks
==4620== possibly lost: 3,400 bytes in 29 blocks
==4620== still reachable: 110,488 bytes in 1,225 blocks
==4620== of which reachable via heuristic:
==4620== length64 : 768 bytes in 15 blocks
==4620== newarray : 1,728 bytes in 28 blocks
==4620== suppressed: 0 bytes in 0 blocks
==4620==
==4620== ERROR SUMMARY: 31 errors from 31 contexts (suppressed: 0 from 0)

chip-im-initiator (AFTER)
==11462== LEAK SUMMARY:
==11462== definitely lost: 0 bytes in 0 blocks
==11462== indirectly lost: 0 bytes in 0 blocks
==11462== possibly lost: 3,400 bytes in 29 blocks
==11462== still reachable: 97,745 bytes in 1,081 blocks
==11462== of which reachable via heuristic:
==11462== length64 : 768 bytes in 15 blocks
==11462== newarray : 1,728 bytes in 28 blocks
==11462== suppressed: 0 bytes in 0 blocks
==11462==
==11462== ERROR SUMMARY: 29 errors from 29 contexts (suppressed: 0 from 0)

[CLAassistant]

All committers have signed the CLA.

[harsha-rajendran]

Thanks for the quick approvals, @Damian-Nordic @bzbarsky-apple . Given that I am a first time contributor, I need a maintainer to approve workflows on my PR. Could either of you or any others approve this? TIA.

[github-actions]

PR #13216: Size comparison from feb07d5 to bbbb42b

Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	feb07d5	bbbb42b	change	% change
efr32	lighting-app	BRD4161A	(read only)	828908	828908	0	0.0
			(read/write)	127052	127052	0	0.0
			.bss	125176	125176	0	0.0
			.data	1876	1876	0	0.0
			.text	828900	828900	0	0.0
		BRD4161A+rpc	(read only)	816552	816552	0	0.0
			(read/write)	143720	143720	0	0.0
			.bss	141744	141744	0	0.0
			.data	1976	1976	0	0.0
			.text	816544	816544	0	0.0
	window-app	BRD4161A	(read only)	802372	802372	0	0.0
			(read/write)	125992	125992	0	0.0
			.bss	124160	124160	0	0.0
			.data	1832	1832	0	0.0
			.text	802364	802364	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	882588	882588	0	0.0
			(read/write)	1312402	1312402	0	0.0
			.dram0.bss	69072	69072	0	0.0
			.dram0.data	14220	14220	0	0.0
			.flash.rodata	176056	176056	0	0.0
			.flash.text	882588	882588	0	0.0
			.iram0.text	62254	62254	0	0.0
		m5stack	(read only)	942807	942807	0	0.0
			(read/write)	441512	441512	0	0.0
			.dram0.bss	73568	73568	0	0.0
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	202880	202880	0	0.0
			.flash.text	937423	937423	0	0.0
			.iram0.text	122671	122671	0	0.0
k32w	light	k32w061+release	(read/write)	647520	647520	0	0.0
			.bss	76184	76184	0	0.0
			.data	1904	1904	0	0.0
			.text	563632	563632	0	0.0
	lock	k32w061+release	(read/write)	632248	632248	0	0.0
			.bss	75896	75896	0	0.0
			.data	1860	1860	0	0.0
			.text	548692	548692	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	6997300	6997300	0	0.0
			(read/write)	325841	325841	0	0.0
			.bss	54209	54209	0	0.0
			.data	1096	1096	0	0.0
			.data.rel.ro	210056	210056	0	0.0
			.dynamic	560	560	0	0.0
			.got	56776	56776	0	0.0
			.init	24	24	0	0.0
			.init_array	168	168	0	0.0
			.rodata	383884	383884	0	0.0
			.text	5920036	5920036	0	0.0
	thermostat-no-ble	arm64	(read only)	2011508	2011508	0	0.0
			(read/write)	143937	143937	0	0.0
			.bss	63985	63985	0	0.0
			.data	880	880	0	0.0
			.data.rel.ro	72200	72200	0	0.0
			.dynamic	560	560	0	0.0
			.got	3936	3936	0	0.0
			.init	24	24	0	0.0
			.init_array	296	296	0	0.0
			.rodata	128468	128468	0	0.0
			.text	1670512	1670512	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2338880	2338880	0	0.0
			.bss	188332	188332	0	0.0
			.data	5272	5272	0	0.0
			.text	1301456	1301456	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2329160	2329160	0	0.0
			.bss	180608	180608	0	0.0
			.data	5552	5552	0	0.0
			.text	1291760	1291760	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2302192	2302192	0	0.0
			.bss	179656	179656	0	0.0
			.data	5544	5544	0	0.0
			.text	1264792	1264792	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1140008	1140008	0	0.0
			.bss	11756	11756	0	0.0
			.data	4368	4368	0	0.0
			.text	103392	103392	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2053888	2053888	0	0.0
			.bss	156972	156972	0	0.0
			.data	4864	4864	0	0.0
			.text	1016488	1016488	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	935343	935343	0	0.0
			bss	118172	118172	0	0.0
			rodata	107996	107996	0	0.0
			text	631620	631620	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	921747	921747	0	0.0
			bss	115216	115216	0	0.0
			rodata	101416	101416	0	0.0
			text	626932	626932	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	859110	859110	0	0.0
			bss	116456	116456	0	0.0
			rodata	102924	102924	0	0.0
			text	559060	559060	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	907491	907491	0	0.0
			bss	117360	117360	0	0.0
			rodata	103304	103304	0	0.0
			text	609448	609448	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	831406	831406	0	0.0
			bss	115672	115672	0	0.0
			rodata	98268	98268	0	0.0
			text	536924	536924	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	542351	542351	0	0.0
			bss	52588	52588	0	0.0
			rodata	50668	50668	0	0.0
			text	376892	376892	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	908755	908755	0	0.0
			bss	117120	117120	0	0.0
			rodata	103520	103520	0	0.0
			text	610684	610684	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	905571	905571	0	0.0
			bss	117148	117148	0	0.0
			rodata	102776	102776	0	0.0
			text	608196	608196	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	796871	796871	0	0.0
			bss	109536	109536	0	0.0
			rodata	78200	78200	0	0.0
			text	532680	532680	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	709502	709502	0	0.0
			bss	107424	107424	0	0.0
			rodata	72500	72500	0	0.0
			text	450172	450172	0	0.0
p6	all-clusters-app	default	(read/write)	2390792	2390792	0	0.0
			.bss	116532	116532	0	0.0
			.data	2552	2552	0	0.0
			.text	1349056	1349056	0	0.0
	light-app	default	(read/write)	2323648	2323648	0	0.0
			.bss	105856	105856	0	0.0
			.data	2384	2384	0	0.0
			.text	1281912	1281912	0	0.0
	lock-app	default	(read/write)	2295864	2295864	0	0.0
			.bss	104736	104736	0	0.0
			.data	2336	2336	0	0.0
			.text	1254128	1254128	0	0.0
qpg	lighting-app	qpg6105+debug	(read only)	531192	531192	0	0.0
			(read/write)	146936	146936	0	0.0
			.bss	86656	86656	0	0.0
			.data	1004	1004	0	0.0
			.text	525872	525872	0	0.0
	lock-app	qpg6105+debug	(read only)	502860	502860	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	85792	85792	0	0.0
			.data	952	952	0	0.0
			.text	497540	497540	0	0.0
	persistent-storage-app	qpg6105+debug	(read only)	106448	106448	0	0.0
			(read/write)	146938	146938	0	0.0
			.bss	36146	36146	0	0.0
			.data	288	288	0	0.0
			.text	101128	101128	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	831682	831682	0	0.0
			bss	86840	86840	0	0.0
			noinit	37160	37160	0	0.0
			text	580162	580162	0	0.0