[crypto] Changed mbedTLS API calls to fit 3.0.0 version. #13208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkasperczyk-no
force-pushed
the
mbedtls_3_0_0_support_pr
branch
from
72438d0 to
da9dcbb
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple and
robszewczyk
pullapprove
bot
requested review from
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
In mbedTLS 3.0.0 there are some API changes comparing to previous versions that require aligning Matter source code calling this API. This change is a first step for future mbedTLS 3.0.0 support, so contains only API calls changes, no version update or building configuration done. Added ifdefs checking mbedTLS version and changing: * mbedtls_*_ret() calls to mbedtls_*() * direct mbedtls structure's fields accessing to using MBEDTLS_PRIVATE() macro (no getters API available for now)
kkasperczyk-no
force-pushed
the
mbedtls_3_0_0_support_pr
branch
from
da9dcbb to
640cbff
Compare
|
PR #13208: Size comparison from 9a80f75 to 640cbff Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
FYI: @gilles-peskine-arm |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
andy31415
approved these changes
Jan 4, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…p#13208) In mbedTLS 3.0.0 there are some API changes comparing to previous versions that require aligning Matter source code calling this API. This change is a first step for future mbedTLS 3.0.0 support, so contains only API calls changes, no version update or building configuration done. Added ifdefs checking mbedTLS version and changing: * mbedtls_*_ret() calls to mbedtls_*() * direct mbedtls structure's fields accessing to using MBEDTLS_PRIVATE() macro (no getters API available for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In mbedTLS 3.0.0 there are some API changes comparing to previous versions that require aligning Matter source code calling this API.
This change is a first step for future mbedTLS 3.0.0 support, so it contains only API calls changes, no version update or building
configuration done.
Change overview
Added ifdefs checking mbedTLS version and changing:
mbedtls_*_ret()calls tombedtls_*()MBEDTLS_PRIVATE()macro (no getters API available for now)Testing
Manually checkout mbedTLS v.3.0.0 tag from
thirdparty/mbedtls/repoand verified that building chip_tool and linux lighting_app examples works after API changes.Run manually CHIP Crypto PAL unit tests and made sure it all pass.